ci: fix remaining deprecation notices (#5700)

* ci: fix remaining deprecation notices

* cleanup

* relax deprecations for Windows

* a bit more strict

* fix

Author: dunglas

.github/workflows/ci.yml

@@ -10,7 +10,6 @@ concurrency:
 
 env:
   COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  SYMFONY_DEPRECATIONS_HELPER: max[self]=0
 
 jobs:
   commitlint:
@@ -552,8 +551,6 @@ jobs:
         php:
           - '8.2'
       fail-fast: false
-    env:
-      SYMFONY_DEPRECATIONS_HELPER: max[total]=0
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -592,9 +589,6 @@ jobs:
         php:
           - '8.2'
       fail-fast: false
-    # env:
-      # See https://github.com/doctrine/DoctrineMongoDBBundle/pull/673
-      #SYMFONY_DEPRECATIONS_HELPER: max[direct]=0
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -713,6 +707,8 @@ jobs:
         run: tests/Fixtures/app/console cache:clear --ansi
       - name: Run PHPUnit tests
         run: vendor/bin/simple-phpunit --log-junit build/logs/phpunit/junit.xml
+        env:
+          SYMFONY_DEPRECATIONS_HELPER: max[direct]=0&ignoreFile=./tests/.ignored-deprecations
 
   windows-behat:
     name: Windows Behat (PHP ${{ matrix.php }}) (SQLite)
@@ -765,9 +761,6 @@ jobs:
         php:
           - '8.2'
       fail-fast: false
-      # env:
-      # See https://github.com/doctrine/DoctrineMongoDBBundle/pull/673
-      #SYMFONY_DEPRECATIONS_HELPER: max[direct]=0
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -798,6 +791,8 @@ jobs:
         run: tests/Fixtures/app/console cache:clear --ansi
       - name: Run PHPUnit tests
         run: vendor/bin/simple-phpunit
+        env:
+          SYMFONY_DEPRECATIONS_HELPER: max[self]=0&ignoreFile=./tests/.ignored-deprecations
 
   behat-symfony-lowest:
     name: Behat (PHP ${{ matrix.php }}) (Symfony lowest)

phpunit.xml.dist

@@ -4,7 +4,7 @@
     <php>
         <ini name="error_reporting" value="-1" />
         <ini name="memory_limit" value="-1" />
-        <server name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0" />
+        <server name="SYMFONY_DEPRECATIONS_HELPER" value="max[total]=0&amp;ignoreFile=./tests/.ignored-deprecations" />
         <!-- This is necessary for GitHub Actions to work properly -->
         <server name="SYMFONY_PHPUNIT_DIR" value="vendor/bin/.phpunit" />
         <server name="SYMFONY_PHPUNIT_REMOVE" value="symfony/yaml" />

tests/.ignored-deprecations

@@ -0,0 +1,9 @@
+# No fix available yet, see https://github.com/doctrine/dbal/issues/5784
+%Subscribing to onSchemaCreateTable events is deprecated\.%
+
+# Fixed by https://github.com/doctrine/orm/pull/10855
+%Column::setCustomSchemaOptions\(\) is deprecated\. Use setPlatformOptions\(\) instead\.%
+
+# Fixed in DoctrineMongoDBBundle 4.6
+%Accessing Doctrine\\Common\\Lexer\\Token properties via ArrayAccess is deprecated, use the value, type or position property instead%
+%Do the same.*Doctrine\\Bundle\\MongoDBBundle%

tests/Fixtures/TestBundle/Entity/Person.php

@@ -34,7 +34,7 @@ class Person
     #[ORM\GeneratedValue(strategy: 'AUTO')]
     private ?int $id = null;
 
-    #[ORM\Column(type: 'string', enumType: GenderTypeEnum::class, nullable: true)]
+    #[ORM\Column(type: 'string', nullable: true, enumType: GenderTypeEnum::class)]
     #[Groups(['people.pets'])]
     public ?GenderTypeEnum $genderType = GenderTypeEnum::MALE;
 

tests/Fixtures/app/bootstrap.php

@@ -18,6 +18,12 @@
     exit('PHPUnit is not installed. Please run ./vendor/bin/simple-phpunit to install it');
 }
 
+// Increase default max nesting level allowed by XDebug for the Symfony container
+$xdebugMaxNestingLevel = ini_get('xdebug.max_nesting_level');
+if (false !== $xdebugMaxNestingLevel && $xdebugMaxNestingLevel <= 512) {
+    ini_set('xdebug.max_nesting_level', 512);
+}
+
 $phpunitLoader = require $phpUnitAutoloaderPath;
 // Don't register the PHPUnit autoloader before the normal autoloader to prevent weird issues
 $phpunitLoader->unregister();