fix skipped data persisters on persist

Rodrigue Villetard · Rodrigue Villetard · commit 84b9cf55a228 · 2018-07-03T14:33:02.000+02:00
diff --git a/src/DataPersister/ChainDataPersister.php b/src/DataPersister/ChainDataPersister.php
@@ -51,9 +51,11 @@ public function persist($data)
     {
         foreach ($this->persisters as $persister) {
             if ($persister->supports($data)) {
-                return $persister->persist($data) ?? $data;
+                $data = $persister->persist($data) ?? $data;
             }
         }
+
+        return $data;
     }
 
     /**
diff --git a/tests/DataPersister/ChainDataPersisterTest.php b/tests/DataPersister/ChainDataPersisterTest.php
@@ -60,7 +60,15 @@ public function testPersist()
         $barPersisterProphecy->supports($dummy)->willReturn(true)->shouldBeCalled();
         $barPersisterProphecy->persist($dummy)->shouldBeCalled();
 
-        (new ChainDataPersister([$fooPersisterProphecy->reveal(), $barPersisterProphecy->reveal()]))->persist($dummy);
+        $bazPersisterProphecy = $this->prophesize(DataPersisterInterface::class);
+        $bazPersisterProphecy->supports($dummy)->willReturn(true)->shouldBeCalled();
+        $bazPersisterProphecy->persist($dummy)->shouldBeCalled();
+
+        (new ChainDataPersister([
+            $fooPersisterProphecy->reveal(),
+            $barPersisterProphecy->reveal(),
+            $bazPersisterProphecy->reveal(),
+        ]))->persist($dummy);
     }
 
     public function testRemove()

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,11 @@ public function persist($data)`
`51`	`51`	`{`
`52`	`52`	`foreach ($this->persisters as $persister) {`
`53`	`53`	`if ($persister->supports($data)) {`
`54`		`- return $persister->persist($data) ?? $data;`
	`54`	`+ $data = $persister->persist($data) ?? $data;`
`55`	`55`	`}`
`56`	`56`	`}`
	`57`	`+`
	`58`	`+ return $data;`
`57`	`59`	`}`
`58`	`60`
`59`	`61`	`/**`