fix(doctrine): read parent class properties on PUT (#6176)

* fix(doctrine): PersistProcessor on PUT operation

Recursively get reflectionProperties to allow modifications on parent properties

* added tests

---------

Co-authored-by: Aurélien ADAM <[email protected]>

Author: aurac

features/doctrine/issue6175/standard_put_entity_inheritence.feature

@@ -0,0 +1,25 @@
+Feature: Update properties of a resource that are inherited with standard PUT operation
+
+  @!mongodb
+  @createSchema
+  Scenario: Update properties of a resource that are inherited with standard PUT operation
+    Given there is a dummy entity with a mapped superclass
+    When I add "Content-Type" header equal to "application/ld+json"
+    And I send a "PUT" request to "/dummy_mapped_subclasses/1" with body:
+    """
+    {
+      "foo": "updated value"
+    }
+    """
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the JSON should be equal to:
+    """
+    {
+      "@context": "/contexts/DummyMappedSubclass",
+      "@id": "/dummy_mapped_subclasses/1",
+      "@type": "DummyMappedSubclass",
+      "id": 1,
+      "foo": "updated value"
+    }
+    """

src/Doctrine/Common/State/PersistProcessor.php

@@ -128,11 +128,15 @@ private function isDeferredExplicit(DoctrineObjectManager $manager, $data): bool
     private function getReflectionProperties(mixed $data): array
     {
         $ret = [];
-        $props = (new \ReflectionObject($data))->getProperties(~\ReflectionProperty::IS_STATIC);
+        $r = new \ReflectionObject($data);
 
-        foreach ($props as $prop) {
-            $ret[$prop->getName()] = $prop;
-        }
+        do {
+            $props = $r->getProperties(~\ReflectionProperty::IS_STATIC);
+
+            foreach ($props as $prop) {
+                $ret[$prop->getName()] = $prop;
+            }
+        } while ($r = $r->getParentClass());
 
         return $ret;
     }

tests/Behat/DoctrineContext.php

@@ -129,6 +129,7 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyFriend;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyGroup;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyImmutableDate;
+use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyMappedSubclass;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyMercure;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyOffer;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\DummyPassenger;
@@ -2259,6 +2260,16 @@ public function thereAreAFewLinkHandledDummies(): void
         $this->manager->flush();
     }
 
+    /**
+     * @Given there is a dummy entity with a mapped superclass
+     */
+    public function thereIsADummyEntityWithAMappedSuperclass(): void
+    {
+        $entity = new DummyMappedSubclass();
+        $this->manager->persist($entity);
+        $this->manager->flush();
+    }
+
     private function isOrm(): bool
     {
         return null !== $this->schemaTool;

tests/Fixtures/TestBundle/Entity/DummyMappedSubclass.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity;
+
+use ApiPlatform\Metadata\Put;
+use Doctrine\ORM\Mapping as ORM;
+
+#[ORM\Entity]
+#[Put(
+    extraProperties: [
+        'standard_put' => true,
+    ],
+    allowCreate: true
+)]
+class DummyMappedSubclass extends DummyMappedSuperclass
+{
+    #[ORM\Id]
+    #[ORM\GeneratedValue]
+    #[ORM\Column]
+    private ?int $id = null;
+
+    public function getId(): ?int
+    {
+        return $this->id;
+    }
+}

tests/Fixtures/TestBundle/Entity/DummyMappedSuperclass.php

@@ -0,0 +1,35 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity;
+
+use Doctrine\ORM\Mapping as ORM;
+
+#[ORM\MappedSuperclass]
+class DummyMappedSuperclass
+{
+    #[ORM\Column(length: 255, nullable: true)]
+    private ?string $foo = null;
+
+    public function getFoo(): ?string
+    {
+        return $this->foo;
+    }
+
+    public function setFoo(?string $foo): static
+    {
+        $this->foo = $foo;
+
+        return $this;
+    }
+}