chore(serializer): todo duplicated code

soyuka · soyuka · commit 868583b58ab2 · 2022-09-05T15:23:44.000+02:00
diff --git a/src/JsonApi/Serializer/ItemNormalizer.php b/src/JsonApi/Serializer/ItemNormalizer.php
@@ -445,6 +445,7 @@ private function getIncludedNestedResources(string $relationshipName, array $con
         return array_map(static fn (string $nested): string => substr($nested, strpos($nested, '.') + 1), $filtered);
     }
 
+    // TODO: this code is similar to the one used in JsonLd
     private function getResourceShortName(string $resourceClass): string
     {
         if ($this->resourceClassResolver->isResourceClass($resourceClass)) {

Original file line number	Diff line number	Diff line change
`@@ -445,6 +445,7 @@ private function getIncludedNestedResources(string $relationshipName, array $con`
`445`	`445`	`return array_map(static fn (string $nested): string => substr($nested, strpos($nested, '.') + 1), $filtered);`
`446`	`446`	`}`
`447`	`447`
	`448`	`+ // TODO: this code is similar to the one used in JsonLd`
`448`	`449`	`private function getResourceShortName(string $resourceClass): string`
`449`	`450`	`{`
`450`	`451`	`if ($this->resourceClassResolver->isResourceClass($resourceClass)) {`