Skip to content

Commit 889b9f6

Browse files
committed
Merge pull request #295 from theofidry/1-0/bugfix/preprend-config
Fix prepend condition
2 parents 31263c3 + f9a1007 commit 889b9f6

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

DependencyInjection/DunglasApiExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class DunglasApiExtension extends Extension implements PrependExtensionInterface
3030
*/
3131
public function prepend(ContainerBuilder $container)
3232
{
33-
if (null !== ($frameworkConfiguration = $container->getExtensionConfig('framework'))) {
33+
if (!empty($frameworkConfiguration = $container->getExtensionConfig('framework'))) {
3434
if (!isset($frameworkConfiguration['serializer']) || !isset($frameworkConfiguration['serializer']['enabled'])) {
3535
$container->prependExtensionConfig('framework', [
3636
'serializer' => [

Tests/DependencyInjection/DunglasApiExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function testPrependWhenNotConfigured()
7070
{
7171
$containerBuilderProphecy = $this->prophesize('Symfony\Component\DependencyInjection\ContainerBuilder');
7272
$containerBuilderProphecy->getExtensionConfig('framework')->willReturn([])->shouldBeCalled();
73-
$containerBuilderProphecy->prependExtensionConfig('framework', Argument::type('array'))->shouldBeCalled();
73+
$containerBuilderProphecy->prependExtensionConfig('framework', Argument::type('array'))->shouldNotBeCalled();
7474
$containerBuilder = $containerBuilderProphecy->reveal();
7575

7676
$this->extension->prepend($containerBuilder);

0 commit comments

Comments
 (0)