Merge pull request #4843 from vincentchalamon/chore/remove-metadata_backward_compatibility_layer-option

Remove metadata_backward_compatibility_layer option

Author: vincentchalamon

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -191,7 +191,7 @@ private function registerCommonConfiguration(ContainerBuilder $container, array
             $container->setAlias('api_platform.name_converter', $config['name_converter']);
         }
         $container->setParameter('api_platform.asset_package', $config['asset_package']);
-        $container->setParameter('api_platform.defaults', $this->normalizeDefaults($config['defaults'] ?? [], $config['metadata_backward_compatibility_layer'] ?? false));
+        $container->setParameter('api_platform.defaults', $this->normalizeDefaults($config['defaults'] ?? []));
     }
 
     /**
@@ -212,7 +212,7 @@ private function getPaginationDefaults(array $defaults, array $collectionPaginat
         return array_merge($collectionPaginationConfiguration, $paginationOptions);
     }
 
-    private function normalizeDefaults(array $defaults, bool $compatibility = false): array
+    private function normalizeDefaults(array $defaults): array
     {
         $normalizedDefaults = ['extra_properties' => $defaults['extra_properties'] ?? []];
         unset($defaults['extra_properties']);

src/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -87,7 +87,6 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->defaultValue('0.0.0')
                 ->end()
                 ->booleanNode('show_webby')->defaultTrue()->info('If true, show Webby on the documentation page')->end()
-                ->booleanNode('metadata_backward_compatibility_layer')->defaultTrue()->info('If true, declared services are using legacy interfaces for the following services: "api_platform.iri_converter", "api_platform.openapi.factory", "api_platform.identifiers_extractor".')->end()
                 ->scalarNode('name_converter')->defaultNull()->info('Specify a name converter to use.')->end()
                 ->scalarNode('asset_package')->defaultNull()->info('Specify an asset package name to use.')->end()
                 ->scalarNode('path_segment_name_generator')->defaultValue('api_platform.path_segment_name_generator.underscore')->info('Specify a path name generator to use.')->end()

tests/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -62,7 +62,6 @@ class ApiPlatformExtensionTest extends TestCase
 
     public const DEFAULT_CONFIG = ['api_platform' => [
         'title' => 'title',
-        'metadata_backward_compatibility_layer' => false,
         'description' => 'description',
         'version' => 'version',
         'formats' => [
@@ -698,7 +697,6 @@ public function testGraphQlConfigurationMetadataBackwardCompatibilityLayer(): vo
     {
         $config = self::DEFAULT_CONFIG;
         $config['api_platform']['graphql']['enabled'] = true;
-        $config['api_platform']['metadata_backward_compatibility_layer'] = true;
         (new ApiPlatformExtension())->load($config, $this->container);
 
         $services = [

tests/Symfony/Bundle/DependencyInjection/ConfigurationTest.php

@@ -83,7 +83,6 @@ private function runDefaultConfigTests(array $doctrineIntegrationsToLoad = ['orm
         $this->assertEquals([
             'title' => 'title',
             'description' => 'description',
-            'metadata_backward_compatibility_layer' => true,
             'version' => '1.0.0',
             'show_webby' => true,
             'formats' => [