chore: remove 3.4 deprecation (#7188)

Author: maxhelias

phpstan.neon.dist

@@ -77,9 +77,6 @@ parameters:
 		- '#Method Symfony\\Component\\Serializer\\NameConverter\\NameConverterInterface::normalize\(\) invoked with (2|3|4) parameters, 1 required\.#'
 
 		# Expected, due to backward compatibility
-		-
-			message: "#Call to function method_exists\\(\\) with ApiPlatform\\\\JsonApi\\\\Serializer\\\\ItemNormalizer and 'setCircularReferenc…' will always evaluate to false\\.#"
-			path: src/JsonApi/Tests/Serializer/ItemNormalizerTest.php
 		- '#Method GraphQL\\Type\\Definition\\WrappingType::getWrappedType\(\) invoked with 1 parameter, 0 required\.#'
 		- '#Access to an undefined property GraphQL\\Type\\Definition\\NamedType&GraphQL\\Type\\Definition\\Type::\$name\.#'
 		-

src/Documentation/Action/DocumentationAction.php

@@ -79,13 +79,6 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
 
     public function getSupportedTypes($format): array
     {
-        // @deprecated remove condition when support for symfony versions under 6.3 is dropped
-        if (!method_exists($this->decorated, 'getSupportedTypes')) {
-            return [
-                DocumentNormalizer::FORMAT => null,
-            ];
-        }
-
         return DocumentNormalizer::FORMAT !== $format ? $this->decorated->getSupportedTypes($format) : [];
     }
 

src/Documentation/Action/EntrypointAction.php

@@ -19,10 +19,6 @@ class Options implements OptionsInterface
 {
     public function __construct(
         protected ?string $index = null,
-        /**
-         * @deprecated this parameter is not used anymore
-         */
-        protected ?string $type = null,
     ) {
     }
 
@@ -38,17 +34,4 @@ public function withIndex(?string $index): self
 
         return $self;
     }
-
-    public function getType(): ?string
-    {
-        return $this->type;
-    }
-
-    public function withType(?string $type): self
-    {
-        $self = clone $this;
-        $self->type = $type;
-
-        return $self;
-    }
 }

src/Elasticsearch/Serializer/ItemNormalizer.php

@@ -14,11 +14,7 @@
 namespace ApiPlatform\Elasticsearch\Tests\Metadata\Resource\Factory;
 
 use ApiPlatform\Elasticsearch\Metadata\Resource\Factory\ElasticsearchProviderResourceMetadataCollectionFactory;
-use ApiPlatform\Elasticsearch\Tests\Fixtures\Foo;
-use ApiPlatform\Elasticsearch\Tests\Fixtures\Metadata\Get;
-use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
-use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
 use PHPUnit\Framework\TestCase;
 use Prophecy\PhpUnit\ProphecyTrait;
 
@@ -35,28 +31,4 @@ public function testConstruct(): void
             )
         );
     }
-
-    #[\PHPUnit\Framework\Attributes\DataProvider('elasticsearchProvider')]
-    public function testCreate(?bool $elasticsearchFlag, ?bool $expectedResult): void
-    {
-        $get = (new Get(elasticsearch: $elasticsearchFlag, shortName: 'Foo'));
-        $resource = (new ApiResource(operations: ['foo_get' => $get]));
-        $metadata = new ResourceMetadataCollection(Foo::class, [$resource]);
-
-        $decorated = $this->prophesize(ResourceMetadataCollectionFactoryInterface::class);
-        $decorated->create(Foo::class)->willReturn($metadata)->shouldBeCalled();
-
-        $resourceMetadataFactory = new ElasticsearchProviderResourceMetadataCollectionFactory($decorated->reveal());
-        $elasticsearchResult = $resourceMetadataFactory->create(Foo::class)->getOperation('foo_get')->getElasticsearch();
-        self::assertEquals($expectedResult, $elasticsearchResult);
-    }
-
-    public static function elasticsearchProvider(): array
-    {
-        return [
-            'elasticsearch: false' => [false, false],
-            'elasticsearch: null' => [null, false],
-            'elasticsearch: true' => [true, true],
-        ];
-    }
 }

src/Elasticsearch/State/Options.php

@@ -33,12 +33,12 @@
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
+use Symfony\Component\HttpFoundation\EventStreamResponse;
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
 use Symfony\Component\PropertyInfo\Type;
 use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
 use Symfony\Component\Serializer\Exception\UnexpectedValueException;
-use Symfony\Component\Serializer\NameConverter\AdvancedNameConverterInterface;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\Serializer;
 use Symfony\Component\Serializer\SerializerInterface;
@@ -153,21 +153,13 @@ public function testNormalizeCircularReference(): void
 
         $normalizer->setSerializer($this->prophesize(SerializerInterface::class)->reveal());
 
-        $circularReferenceLimit = 2;
-        if (!interface_exists(AdvancedNameConverterInterface::class) && method_exists($normalizer, 'setCircularReferenceLimit')) {
-            $normalizer->setCircularReferenceLimit($circularReferenceLimit);
-
-            $context = [
-                'circular_reference_limit' => [spl_object_hash($circularReferenceEntity) => 2],
-                'cache_error' => function (): void {},
-            ];
-        } else {
-            $context = [
-                'circular_reference_limit' => $circularReferenceLimit,
-                'circular_reference_limit_counters' => [spl_object_hash($circularReferenceEntity) => 2],
-                'cache_error' => function (): void {},
-            ];
-        }
+        // Symfony >= 7.3
+        $splObject = class_exists(EventStreamResponse::class) ? spl_object_id($circularReferenceEntity) : spl_object_hash($circularReferenceEntity);
+        $context = [
+            'circular_reference_limit' => 2,
+            'circular_reference_limit_counters' => [$splObject => 2],
+            'cache_error' => function (): void {},
+        ];
 
         $this->assertSame('/circular_references/1', $normalizer->normalize($circularReferenceEntity, ItemNormalizer::FORMAT, $context));
     }