fix(symfony): catch identifiers exceptions in iri converter

Author: soyuka

src/Symfony/Routing/IriConverter.php

@@ -157,7 +157,7 @@ public function getIriFromResource($item, int $referenceType = UrlGeneratorInter
         if (\is_object($item)) {
             try {
                 $identifiers = $this->identifiersExtractor->getIdentifiersFromItem($item, $operation);
-            } catch (RuntimeException $e) {
+            } catch (InvalidArgumentException|RuntimeException $e) {
                 // We can try using context uri variables if any
                 if (!$identifiers) {
                     throw new InvalidArgumentException(sprintf('Unable to generate an IRI for the item of type "%s"', $resourceClass), $e->getCode(), $e);

tests/Symfony/Routing/IriConverterTest.php

@@ -18,6 +18,7 @@
 use ApiPlatform\Api\UrlGeneratorInterface;
 use ApiPlatform\Core\Api\IriConverterInterface;
 use ApiPlatform\Core\Tests\ProphecyTrait;
+use ApiPlatform\Exception\InvalidArgumentException;
 use ApiPlatform\Exception\RuntimeException;
 use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Get;
@@ -124,6 +125,25 @@ public function testGetIriFromItemWithNoOperations()
         $iriConverter->getIriFromResource($item);
     }
 
+    public function testGetIriFromItemWithBadIdentifiers()
+    {
+        $this->expectExceptionMessage(sprintf('Unable to generate an IRI for the item of type "%s"', Dummy::class));
+
+        $item = new Dummy();
+        $item->setId(1);
+
+        $resourceMetadataCollectionFactoryProphecy = $this->prophesize(ResourceMetadataCollectionFactoryInterface::class);
+        $resourceMetadataCollectionFactoryProphecy->create(Dummy::class)->shouldBeCalled()->willReturn(new ResourceMetadataCollection(Dummy::class, [
+            (new ApiResource())->withOperations(new Operations()),
+        ]));
+
+        $identifiersExtractorProphecy = $this->prophesize(IdentifiersExtractorInterface::class);
+        $identifiersExtractorProphecy->getIdentifiersFromItem($item, Argument::type(HttpOperation::class))->willThrow(InvalidArgumentException::class);
+
+        $iriConverter = $this->getIriConverter(null, null, $identifiersExtractorProphecy, $resourceMetadataCollectionFactoryProphecy);
+        $iriConverter->getIriFromResource($item);
+    }
+
     public function testGetCollectionIri()
     {
         $operationName = 'operation_name';