fix: XML/YAML cast values (#4800)

* fix: XML/YAML cast values

* fix: review

Author: vincentchalamon

src/Metadata/Extractor/ResourceExtractorTrait.php

@@ -97,19 +97,16 @@ private function buildArgs(SimpleXMLElement $resource): ?array
         return $data;
     }
 
-    /**
-     * @return string[]
-     */
     private function buildValues(SimpleXMLElement $resource): array
     {
         $data = [];
         foreach ($resource->value as $value) {
             if (null !== $value->attributes()->name) {
-                $data[(string) $value->attributes()->name] = isset($value->values) ? $this->buildValues($value->values) : (string) $value;
+                $data[(string) $value->attributes()->name] = isset($value->values) ? $this->buildValues($value->values) : XmlUtils::phpize($value->__toString());
                 continue;
             }
 
-            $data[] = isset($value->values) ? $this->buildValues($value->values) : (string) $value;
+            $data[] = isset($value->values) ? $this->buildValues($value->values) : XmlUtils::phpize($value->__toString());
         }
 
         return $data;

tests/Metadata/Extractor/XmlExtractorTest.php

@@ -152,6 +152,7 @@ public function testValidXML(): void
                     ],
                     'normalizationContext' => [
                         'groups' => ['comment:read', 'comment:custom-read'],
+                        'enabled' => true,
                     ],
                     'denormalizationContext' => [
                         'groups' => 'comment:write',
@@ -229,6 +230,7 @@ public function testValidXML(): void
                             ],
                             'normalizationContext' => [
                                 'groups' => ['comment:read', 'comment:custom-read'],
+                                'enabled' => true,
                             ],
                             'denormalizationContext' => [
                                 'groups' => 'comment:write',
@@ -321,6 +323,7 @@ public function testValidXML(): void
                             ],
                             'normalizationContext' => [
                                 'groups' => ['comment:read', 'comment:custom-read'],
+                                'enabled' => true,
                             ],
                             'denormalizationContext' => [
                                 'groups' => 'comment:write',

tests/Metadata/Extractor/YamlExtractorTest.php

@@ -211,7 +211,10 @@ public function testValidYaml(): void
                     'status' => null,
                     'schemes' => null,
                     'cacheHeaders' => null,
-                    'normalizationContext' => null,
+                    'normalizationContext' => [
+                        'groups' => ['foo', 'bar'],
+                        'enabled' => false,
+                    ],
                     'denormalizationContext' => null,
                     'hydraContext' => null,
                     'openapiContext' => null,
@@ -272,7 +275,10 @@ public function testValidYaml(): void
                             'status' => null,
                             'schemes' => null,
                             'cacheHeaders' => null,
-                            'normalizationContext' => null,
+                            'normalizationContext' => [
+                                'groups' => ['foo', 'bar'],
+                                'enabled' => false,
+                            ],
                             'denormalizationContext' => null,
                             'hydraContext' => null,
                             'openapiContext' => null,
@@ -345,7 +351,10 @@ public function testValidYaml(): void
                             'status' => null,
                             'schemes' => null,
                             'cacheHeaders' => null,
-                            'normalizationContext' => null,
+                            'normalizationContext' => [
+                                'groups' => ['foo', 'bar'],
+                                'enabled' => false,
+                            ],
                             'denormalizationContext' => null,
                             'hydraContext' => null,
                             'openapiContext' => null,

tests/Metadata/Extractor/xml/valid.xml

@@ -53,6 +53,7 @@
                         <value>comment:custom-read</value>
                     </values>
                 </value>
+                <value name="enabled">true</value>
             </values>
         </normalizationContext>
 

tests/Metadata/Extractor/yaml/valid.yaml

@@ -7,6 +7,9 @@ resources:
             uriVariables: ['author']
             types: ['someirischema']
             description: User programs
+            normalizationContext:
+                groups: ['foo', 'bar']
+                enabled: false
             operations:
                 ApiPlatform\Metadata\GetCollection: ~
                 ApiPlatform\Metadata\Get: