fix: remove null parameter check

Author: vincentchalamon

src/Validator/Metadata/Resource/Factory/ParameterValidationResourceMetadataCollectionFactory.php

@@ -194,12 +194,6 @@ private function addSchemaValidation(Parameter $parameter, ?array $schema = null
             $assertions[] = new Type(type: $schema['type']);
         }
 
-        // Allow null in case of optional parameter
-        if (isset($schema['type']) && 'null' === $schema['type']) {
-            // Header null values may be sent as array through Symfony
-            $assertions[] = new Expression(expression: 'value in [null, "null", [null], ["null"]]');
-        }
-
         // Allow null in case of optional parameter
         if (isset($schema['type']) && 'boolean' === $schema['type']) {
             $assertions[] = new Expression(expression: 'value in [null, 0, 1, "0", "1", false, true, "false", "true"]');

tests/Fixtures/TestBundle/ApiResource/WithParameter.php

@@ -195,17 +195,6 @@
     ],
     provider: [self::class, 'noopProvider']
 )]
-#[GetCollection(
-    uriTemplate: 'header_null',
-    parameters: [
-        'Ipsum' => new HeaderParameter(
-            schema: [
-                'type' => 'null',
-            ],
-        ),
-    ],
-    provider: [self::class, 'noopProvider']
-)]
 #[GetCollection(
     uriTemplate: 'query_integer',
     parameters: [
@@ -246,17 +235,6 @@
     ],
     provider: [self::class, 'noopProvider']
 )]
-#[GetCollection(
-    uriTemplate: 'query_null',
-    parameters: [
-        'Ipsum' => new QueryParameter(
-            schema: [
-                'type' => 'null',
-            ],
-        ),
-    ],
-    provider: [self::class, 'noopProvider']
-)]
 #[Get(
     uriTemplate: 'with_parameters_iris',
     parameters: [

tests/Functional/Parameters/ParameterTest.php

@@ -153,12 +153,6 @@ public static function provideHeaderValues(): iterable
         yield 'valid boolean 1 header_boolean' => ['header_boolean', ['Lorem' => 1], 200];
         yield 'valid boolean 1 string header_boolean' => ['header_boolean', ['Lorem' => '1'], 200];
         yield 'invalid boolean header_boolean' => ['header_boolean', ['Lorem' => 'string'], 422];
-
-        // header_null
-        yield 'missing header header_null' => ['header_null', [], 200];
-        yield 'valid null header_null' => ['header_null', ['Ipsum' => null], 200];
-        yield 'valid null string header_null' => ['header_null', ['Ipsum' => 'null'], 200];
-        yield 'invalid null header_null' => ['header_null', ['Ipsum' => 'string'], 422];
     }
 
     #[DataProvider('provideQueryValues')]
@@ -193,11 +187,6 @@ public static function provideQueryValues(): iterable
         yield 'valid boolean 1 query_boolean' => ['query_boolean', ['Lorem' => 1], 200];
         yield 'valid boolean 1 string query_boolean' => ['query_boolean', ['Lorem' => '1'], 200];
         yield 'invalid boolean query_boolean' => ['query_boolean', ['Lorem' => 'string'], 422];
-
-        // query_null
-        yield 'valid null query_null' => ['query_null', ['Ipsum' => null], 200];
-        yield 'valid null string query_null' => ['query_null', ['Ipsum' => 'null'], 200];
-        yield 'invalid null query_null' => ['query_null', ['Ipsum' => 'string'], 422];
     }
 
     #[DataProvider('provideCountryValues')]