Fix PHPUnit tests

Author: meyerbaptiste

phpstan.neon

@@ -12,5 +12,4 @@ parameters:
         # False positives
         - '#Parameter \#2 \$dqlPart of method Doctrine\\ORM\\QueryBuilder::add\(\) expects Doctrine\\ORM\\Query\\Expr\\Base, Doctrine\\ORM\\Query\\Expr\\Join\[\] given#' # Fixed in Doctrine's master
         - '#Call to an undefined method Doctrine\\Common\\Persistence\\ObjectManager::getConnection\(\)#'
-        - '#Parameter \#1 \$callable of static method Doctrine\\Common\\Annotations\\AnnotationRegistry::registerLoader\(\) expects callable, mixed\[\] given#'
         - '#Class Symfony\\Component\\ExpressionLanguage\\ExpressionLanguage not found and could not be autoloaded#'

tests/Bridge/Doctrine/Orm/Extension/EagerLoadingExtensionTest.php

@@ -542,8 +542,6 @@ public function testApplyToCollectionNoPartial()
 
         $propertyNameCollectionFactoryProphecy = $this->prophesize(PropertyNameCollectionFactoryInterface::class);
 
-        $relatedNameCollection = new PropertyNameCollection(['id', 'name', 'notindatabase', 'notreadable']);
-
         $propertyMetadataFactoryProphecy = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $relationPropertyMetadata = new PropertyMetadata();
         $relationPropertyMetadata = $relationPropertyMetadata->withReadableLink(true);

tests/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtensionTest.php

@@ -21,7 +21,6 @@
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\CompositeLabel;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\CompositeRelation;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyCar;
-use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Foo;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Doctrine\ORM\Query\Expr;

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -24,7 +24,6 @@
 use Symfony\Component\Config\Resource\ResourceInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\DefinitionDecorator;
 use Symfony\Component\DependencyInjection\Extension\ConfigurationExtensionInterface;
 use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
 use Symfony\Component\DependencyInjection\Extension\PrependExtensionInterface;
@@ -201,10 +200,6 @@ public function testDisableEagerLoadingExtension()
 
     private function getContainerBuilderProphecy()
     {
-        $definitionArgument = Argument::that(function ($argument) {
-            return $argument instanceof Definition || $argument instanceof DefinitionDecorator;
-        });
-
         $containerBuilderProphecy = $this->prophesize(ContainerBuilder::class);
         $containerBuilderProphecy->getParameter('kernel.bundles')->willReturn([
             'DoctrineBundle' => DoctrineBundle::class,
@@ -368,7 +363,7 @@ private function getContainerBuilderProphecy()
         ];
 
         foreach ($definitions as $definition) {
-            $containerBuilderProphecy->setDefinition($definition, $definitionArgument)->shouldBeCalled();
+            $containerBuilderProphecy->setDefinition($definition, Argument::type(Definition::class))->shouldBeCalled();
         }
 
         $aliases = [

tests/Fixtures/TestBundle/Entity/CompositeItem.php

@@ -57,7 +57,7 @@ public function getId()
     /**
      * Gets field1.
      *
-     * @return string
+     * @return string|null
      */
     public function getField1()
     {
@@ -67,9 +67,9 @@ public function getField1()
     /**
      * Sets field1.
      *
-     * @param string the value to set
+     * @param string|null $field1 the value to set
      */
-    public function setField1($field1)
+    public function setField1($field1 = null)
     {
         $this->field1 = $field1;
     }

tests/Fixtures/TestBundle/Entity/CompositeLabel.php

@@ -51,7 +51,7 @@ public function getId()
     /**
      * Gets value.
      *
-     * @return string
+     * @return string|null
      */
     public function getValue()
     {
@@ -61,9 +61,9 @@ public function getValue()
     /**
      * Sets value.
      *
-     * @param string the value to set
+     * @param string|null $value the value to set
      */
-    public function setValue($value)
+    public function setValue($value = null)
     {
         $this->value = $value;
     }

tests/Fixtures/TestBundle/Entity/CompositeRelation.php

@@ -50,7 +50,7 @@ class CompositeRelation
     /**
      * Gets value.
      *
-     * @return string
+     * @return string|null
      */
     public function getValue()
     {
@@ -60,9 +60,9 @@ public function getValue()
     /**
      * Sets value.
      *
-     * @param string the value to set
+     * @param string|null $value the value to set
      */
-    public function setValue($value)
+    public function setValue($value = null)
     {
         $this->value = $value;
     }
@@ -80,9 +80,9 @@ public function getCompositeItem()
     /**
      * Sets compositeItem.
      *
-     * @param CompositeItem the value to set
+     * @param CompositeItem $compositeItem the value to set
      */
-    public function setCompositeItem($compositeItem)
+    public function setCompositeItem(CompositeItem $compositeItem)
     {
         $this->compositeItem = $compositeItem;
     }
@@ -100,9 +100,9 @@ public function getCompositeLabel()
     /**
      * Sets compositeLabel.
      *
-     * @param CompositeLabel the value to set
+     * @param CompositeLabel $compositeLabel the value to set
      */
-    public function setCompositeLabel($compositeLabel)
+    public function setCompositeLabel(CompositeLabel $compositeLabel)
     {
         $this->compositeLabel = $compositeLabel;
     }

tests/Fixtures/TestBundle/Entity/DummyFriend.php

@@ -61,7 +61,7 @@ public function getId()
     /**
      * Set id.
      *
-     * @param id the value to set
+     * @param int $id the value to set
      */
     public function setId($id)
     {
@@ -81,7 +81,7 @@ public function getName()
     /**
      * Set name.
      *
-     * @param string the value to set
+     * @param string $name the value to set
      */
     public function setName($name)
     {

tests/Fixtures/TestBundle/Entity/RelatedDummy.php

@@ -139,7 +139,7 @@ public function setDummyBoolean($dummyBoolean)
     /**
      * Get relatedToDummyFriend.
      *
-     * @return RelatedToDummyFriend
+     * @return RelatedToDummyFriend[]
      */
     public function getRelatedToDummyFriend()
     {
@@ -149,7 +149,7 @@ public function getRelatedToDummyFriend()
     /**
      * Set relatedToDummyFriend.
      *
-     * @param RelatedToDummyFriend the value to set
+     * @param RelatedToDummyFriend $relatedToDummyFriend the value to set
      */
     public function addRelatedToDummyFriend(RelatedToDummyFriend $relatedToDummyFriend)
     {

tests/Fixtures/app/bootstrap.php

@@ -18,6 +18,6 @@
 $loader = require __DIR__.'/../../../vendor/autoload.php';
 require __DIR__.'/AppKernel.php';
 
-AnnotationRegistry::registerLoader([$loader, 'loadClass']);
+AnnotationRegistry::registerLoader('class_exists');
 
 return $loader;