Merge pull request #792 from teohhanhui/iriconverter-relation-as-identifier-better-error-checking

Better error checking for relation used as identifier in IriConverter

Author: dunglas

src/Bridge/Symfony/Routing/IriConverter.php

@@ -134,12 +134,16 @@ private function getIdentifiersFromItem($item) : array
                 $propertyMetadata = $this->propertyMetadataFactory->create($relatedResourceClass, $relatedPropertyName);
 
                 if ($propertyMetadata->isIdentifier()) {
+                    if (isset($identifiers[$propertyName])) {
+                        throw new RuntimeException(sprintf('Composite identifiers not supported in "%s" through relation "%s" of "%s" used as identifier', $relatedResourceClass, $propertyName, $resourceClass));
+                    }
+
                     $identifiers[$propertyName] = $this->propertyAccessor->getValue($relatedItem, $relatedPropertyName);
                 }
             }
 
-            if (empty($identifiers[$propertyName])) {
-                throw new RuntimeException(sprintf('%s identifiers cannot be found', $resourceClass));
+            if (!isset($identifiers[$propertyName])) {
+                throw new RuntimeException(sprintf('No identifier found in "%s" through relation "%s" of "%s" used as identifier', $relatedResourceClass, $propertyName, $resourceClass));
             }
         }