[BUG] Do not rely on api-platform/core attributes classes but on interfaces instead (#4785)

* fix: do not rely on api-platform/core attributes classes but on interfaces instead

* fix: use HttpOperation::METHOD_POST === ->getMethod() instead of PostOperationInterface

Author: vincentchalamon

src/Core/Bridge/Symfony/Bundle/Test/Constraint/ArraySubsetTrait.php

@@ -13,7 +13,6 @@
 
 namespace ApiPlatform\Core\Bridge\Symfony\Bundle\Test\Constraint;
 
-use PHPUnit\Framework\Constraint\Constraint;
 use PHPUnit\SebastianBergmann\Comparator\ComparisonFailure;
 
 /**

src/Hydra/Serializer/DocumentationNormalizer.php

@@ -31,7 +31,6 @@
 use ApiPlatform\Metadata\CollectionOperationInterface;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Operation;
-use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
@@ -353,7 +352,7 @@ private function getHydraOperations(string $resourceClass, $resourceMetadata, st
             $hydraOperations = [];
             foreach ($resourceMetadataCollection as $resourceMetadata) {
                 foreach ($resourceMetadata->getOperations() as $operationName => $operation) {
-                    if (($operation instanceof Post || $operation instanceof CollectionOperationInterface) !== $collection) {
+                    if ((HttpOperation::METHOD_POST === $operation->getMethod() || $operation instanceof CollectionOperationInterface) !== $collection) {
                         continue;
                     }
 

src/Metadata/Resource/Factory/AttributesResourceMetadataCollectionFactory.php

@@ -226,7 +226,7 @@ private function getOperationWithDefaults(ApiResource $resource, Operation $oper
         }
 
         return [
-            sprintf('_api_%s_%s%s', $operation->getUriTemplate() ?: $operation->getShortName(), strtolower($operation->getMethod() ?? HttpOperation::METHOD_GET), $operation instanceof GetCollection ? '_collection' : ''),
+            sprintf('_api_%s_%s%s', $operation->getUriTemplate() ?: $operation->getShortName(), strtolower($operation->getMethod() ?? HttpOperation::METHOD_GET), $operation instanceof CollectionOperationInterface ? '_collection' : ''),
             $operation,
         ];
     }

src/Metadata/Resource/Factory/UriTemplateResourceMetadataCollectionFactory.php

@@ -18,7 +18,6 @@
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Link;
 use ApiPlatform\Metadata\Operations;
-use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
 use ApiPlatform\Operation\PathSegmentNameGeneratorInterface;
 use Symfony\Component\Routing\Route;
@@ -137,7 +136,7 @@ private function configureUriVariables($operation)
         $operation = $this->normalizeUriVariables($operation);
 
         if (!($uriTemplate = $operation->getUriTemplate())) {
-            if ($operation instanceof Post) {
+            if ($operation instanceof HttpOperation && HttpOperation::METHOD_POST === $operation->getMethod()) {
                 return $operation->withUriVariables([]);
             }
 

src/OpenApi/Factory/OpenApiFactory.php

@@ -23,7 +23,6 @@
 use ApiPlatform\Metadata\CollectionOperationInterface;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Operation;
-use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
 use ApiPlatform\Metadata\Property\Factory\PropertyNameCollectionFactoryInterface;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
@@ -239,7 +238,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
                     break;
             }
 
-            if (!$operation instanceof CollectionOperationInterface && !$operation instanceof Post) {
+            if (!$operation instanceof CollectionOperationInterface && HttpOperation::METHOD_POST !== $operation->getMethod()) {
                 $responses['404'] = new Model\Response('Resource not found');
             }
 

src/Symfony/Bundle/DependencyInjection/Configuration.php

@@ -14,11 +14,11 @@
 namespace ApiPlatform\Symfony\Bundle\DependencyInjection;
 
 use ApiPlatform\Core\Annotation\ApiResource as LegacyApiResource;
-use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Doctrine\Common\Filter\OrderFilterInterface;
 use ApiPlatform\Elasticsearch\Metadata\Document\DocumentMetadata;
 use ApiPlatform\Exception\FilterValidationException;
 use ApiPlatform\Exception\InvalidArgumentException;
+use ApiPlatform\Metadata\ApiResource;
 use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
 use Doctrine\Bundle\MongoDBBundle\DoctrineMongoDBBundle;
 use Doctrine\ORM\EntityManagerInterface;

src/Symfony/Routing/IriConverter.php

@@ -28,7 +28,6 @@
 use ApiPlatform\Metadata\GetCollection;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Operation;
-use ApiPlatform\Metadata\Post;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
 use ApiPlatform\State\ProviderInterface;
 use ApiPlatform\State\UriVariablesResolverTrait;
@@ -138,7 +137,7 @@ public function getIriFromResource($item, int $referenceType = UrlGeneratorInter
         // In symfony the operation name is the route name, try to find one if none provided
         if (
             !$operation->getName()
-            || $operation instanceof Post
+            || ($operation instanceof HttpOperation && HttpOperation::METHOD_POST === $operation->getMethod())
             || $isLegacySubresource
             || $isLegacyCustomResource
         ) {