chore: remove 3.4 deprecation

Author: maxhelias

src/Documentation/Action/DocumentationAction.php

@@ -79,13 +79,6 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
 
     public function getSupportedTypes($format): array
     {
-        // @deprecated remove condition when support for symfony versions under 6.3 is dropped
-        if (!method_exists($this->decorated, 'getSupportedTypes')) {
-            return [
-                DocumentNormalizer::FORMAT => null,
-            ];
-        }
-
         return DocumentNormalizer::FORMAT !== $format ? $this->decorated->getSupportedTypes($format) : [];
     }
 

src/Documentation/Action/EntrypointAction.php

@@ -19,10 +19,6 @@ class Options implements OptionsInterface
 {
     public function __construct(
         protected ?string $index = null,
-        /**
-         * @deprecated this parameter is not used anymore
-         */
-        protected ?string $type = null,
     ) {
     }
 
@@ -38,17 +34,4 @@ public function withIndex(?string $index): self
 
         return $self;
     }
-
-    public function getType(): ?string
-    {
-        return $this->type;
-    }
-
-    public function withType(?string $type): self
-    {
-        $self = clone $this;
-        $self->type = $type;
-
-        return $self;
-    }
 }

src/Elasticsearch/Serializer/ItemNormalizer.php

@@ -14,11 +14,7 @@
 namespace ApiPlatform\Elasticsearch\Tests\Metadata\Resource\Factory;
 
 use ApiPlatform\Elasticsearch\Metadata\Resource\Factory\ElasticsearchProviderResourceMetadataCollectionFactory;
-use ApiPlatform\Elasticsearch\Tests\Fixtures\Foo;
-use ApiPlatform\Elasticsearch\Tests\Fixtures\Metadata\Get;
-use ApiPlatform\Metadata\ApiResource;
 use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
-use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
 use PHPUnit\Framework\TestCase;
 use Prophecy\PhpUnit\ProphecyTrait;
 
@@ -35,28 +31,4 @@ public function testConstruct(): void
             )
         );
     }
-
-    #[\PHPUnit\Framework\Attributes\DataProvider('elasticsearchProvider')]
-    public function testCreate(?bool $elasticsearchFlag, ?bool $expectedResult): void
-    {
-        $get = (new Get(elasticsearch: $elasticsearchFlag, shortName: 'Foo'));
-        $resource = (new ApiResource(operations: ['foo_get' => $get]));
-        $metadata = new ResourceMetadataCollection(Foo::class, [$resource]);
-
-        $decorated = $this->prophesize(ResourceMetadataCollectionFactoryInterface::class);
-        $decorated->create(Foo::class)->willReturn($metadata)->shouldBeCalled();
-
-        $resourceMetadataFactory = new ElasticsearchProviderResourceMetadataCollectionFactory($decorated->reveal());
-        $elasticsearchResult = $resourceMetadataFactory->create(Foo::class)->getOperation('foo_get')->getElasticsearch();
-        self::assertEquals($expectedResult, $elasticsearchResult);
-    }
-
-    public static function elasticsearchProvider(): array
-    {
-        return [
-            'elasticsearch: false' => [false, false],
-            'elasticsearch: null' => [null, false],
-            'elasticsearch: true' => [true, true],
-        ];
-    }
 }

src/Elasticsearch/State/Options.php

@@ -21,7 +21,7 @@
 use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 
 /**
- * Allows access based on the ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface.
+ * Allows access based on the ApiPlatform\Metadata\ResourceAccessCheckerInterface.
  * This implementation covers GraphQl and HTTP.
  *
  * @see ResourceAccessCheckerInterface

src/Elasticsearch/Tests/Metadata/Resource/Factory/ElasticsearchProviderResourceMetadataCollectionFactoryTest.php

@@ -110,7 +110,6 @@ private function buildBase(\SimpleXMLElement $resource): array
             'description' => $this->phpize($resource, 'description', 'string'),
             'urlGenerationStrategy' => $this->phpize($resource, 'urlGenerationStrategy', 'integer'),
             'deprecationReason' => $this->phpize($resource, 'deprecationReason', 'string'),
-            'elasticsearch' => $this->phpize($resource, 'elasticsearch', 'bool'),
             'messenger' => $this->phpize($resource, 'messenger', 'bool|string'),
             'mercure' => $this->buildMercure($resource),
             'input' => $this->phpize($resource, 'input', 'bool|string'),
@@ -459,7 +458,6 @@ private function buildStateOptions(\SimpleXMLElement $resource): ?OptionsInterfa
             if (class_exists(Options::class)) {
                 return new Options(
                     isset($elasticsearchOptions['index']) ? (string) $elasticsearchOptions['index'] : null,
-                    isset($elasticsearchOptions['type']) ? (string) $elasticsearchOptions['type'] : null,
                 );
             }
         }

src/JsonApi/Serializer/ErrorNormalizerTrait.php

@@ -136,7 +136,6 @@ private function buildBase(array $resource): array
             'description' => $this->phpize($resource, 'description', 'string'),
             'urlGenerationStrategy' => $this->phpize($resource, 'urlGenerationStrategy', 'integer'),
             'deprecationReason' => $this->phpize($resource, 'deprecationReason', 'string'),
-            'elasticsearch' => $this->phpize($resource, 'elasticsearch', 'bool'),
             'fetchPartial' => $this->phpize($resource, 'fetchPartial', 'bool'),
             'forceEager' => $this->phpize($resource, 'forceEager', 'bool'),
             'paginationClientEnabled' => $this->phpize($resource, 'paginationClientEnabled', 'bool'),
@@ -419,7 +418,7 @@ private function buildStateOptions(array $resource): ?OptionsInterface
         switch (key($stateOptions)) {
             case 'elasticsearchOptions':
                 if (class_exists(Options::class)) {
-                    return new Options($configuration['index'] ?? null, $configuration['type'] ?? null);
+                    return new Options($configuration['index'] ?? null);
                 }
         }