chore: introduce phpstan level 6

Author: VincentLanglet

phpstan.neon.dist

@@ -1,5 +1,5 @@
 parameters:
-	level: 5
+	level: 6
 	paths:
 		- src
 		- tests
@@ -112,3 +112,63 @@ parameters:
 
 		# Allow extra assertions in tests: https://github.com/phpstan/phpstan-strict-rules/issues/130
 		- '#^Call to (static )?method PHPUnit\\Framework\\Assert::.* will always evaluate to true\.$#'
+
+		# Level 6
+		-
+			identifier: missingType.iterableValue
+		-
+			identifier: missingType.generics
+		-
+			identifier: missingType.property
+			paths:
+				- src/Doctrine/Common/Tests
+				- src/Doctrine/Odm/Tests
+				- src/Doctrine/Orm/Tests
+				- src/Elasticsearch/Tests
+				- src/Hydra/Tests
+				- src/JsonApi/Tests
+				- src/JsonSchema/Tests
+				- src/Metadata/Tests
+				- src/Serializer/Tests
+				- src/Symfony/Tests
+				- tests
+		-
+			identifier: missingType.parameter
+			paths:
+				- src/Doctrine/Common/Tests
+				- src/Doctrine/Odm/Tests
+				- src/Doctrine/Orm/Tests
+				- src/Elasticsearch/Tests
+				- src/GraphQl/Tests
+				- src/Hydra/Tests
+				- src/JsonApi/Tests
+				- src/JsonSchema/Tests
+				- src/Metadata/Tests
+				- src/OpenApi/Tests
+				- src/Serializer/Tests
+				- src/Symfony/Bundle/Test
+				- src/Symfony/Tests
+				- tests
+				- src # TODO
+		-
+			identifier: missingType.return
+			paths:
+				- src/Doctrine/Common/Tests
+				- src/Doctrine/Odm/Tests
+				- src/Doctrine/Orm/Tests
+				- src/Elasticsearch/Tests
+				- src/GraphQl/Tests
+				- src/Hydra/Tests
+				- src/JsonApi/Tests
+				- src/JsonSchema/Tests
+				- src/Metadata/Tests
+				- src/OpenApi/Tests
+				- src/Serializer/Tests
+				- src/Symfony/Tests
+				- tests
+		-
+			identifier: argument.templateType
+			paths:
+				- src/Symfony/Bundle/Test
+				- tests
+				- src # TODO

src/GraphQl/Resolver/Factory/ResolverFactory.php

@@ -87,7 +87,7 @@ public function __invoke(?string $resourceClass = null, ?string $rootClass = nul
         };
     }
 
-    private function resolve(?array $source, array $args, ResolveInfo $info, ?string $rootClass = null, ?Operation $operation = null, mixed $body = null)
+    private function resolve(?array $source, array $args, ResolveInfo $info, ?string $rootClass = null, ?Operation $operation = null, mixed $body = null): mixed
     {
         // Handles relay nodes
         if (!$operation) {

src/Metadata/ApiProperty.php

@@ -345,12 +345,12 @@ public function withIdentifier(bool $identifier): static
         return $self;
     }
 
-    public function getDefault()
+    public function getDefault(): mixed
     {
         return $this->default;
     }
 
-    public function withDefault($default): static
+    public function withDefault(mixed $default): static
     {
         $self = clone $this;
         $self->default = $default;
@@ -587,6 +587,8 @@ public function withExtraProperties(array $extraProperties = []): static
 
     /**
      * Gets IRI of this property.
+     *
+     * @return string[]
      */
     public function getIris()
     {
@@ -608,6 +610,8 @@ public function withIris(string|array $iris): static
 
     /**
      * Whether to generate a skolem iri on anonymous resources.
+     *
+     * @return bool
      */
     public function getGenId()
     {

src/Metadata/Extractor/XmlPropertyExtractor.php

@@ -110,10 +110,10 @@ private function buildValues(\SimpleXMLElement $resource): array
         return $data;
     }
 
-    private function buildArrayValue(?\SimpleXMLElement $resource, string $key, mixed $default = null)
+    private function buildArrayValue(?\SimpleXMLElement $resource, string $key): ?array
     {
         if (!isset($resource->{$key.'s'}->{$key})) {
-            return $default;
+            return null;
         }
 
         return (array) $resource->{$key.'s'}->{$key};

src/Metadata/Extractor/YamlPropertyExtractor.php

@@ -101,10 +101,10 @@ private function buildProperties(array $resourcesYaml): void
         }
     }
 
-    private function buildAttribute(array $resource, string $key, mixed $default = null)
+    private function buildAttribute(array $resource, string $key): ?array
     {
         if (empty($resource[$key])) {
-            return $default;
+            return null;
         }
 
         if (!\is_array($resource[$key])) {

src/Metadata/HttpOperation.php

@@ -287,7 +287,7 @@ public function getUriTemplate(): ?string
         return $this->uriTemplate;
     }
 
-    public function withUriTemplate(?string $uriTemplate = null)
+    public function withUriTemplate(?string $uriTemplate = null): static
     {
         $self = clone $this;
         $self->uriTemplate = $uriTemplate;
@@ -311,11 +311,17 @@ public function withTypes($types): static
         return $self;
     }
 
+    /**
+     * @return array<int|string, string|string[]>|string|null
+     */
     public function getFormats()
     {
         return $this->formats;
     }
 
+    /**
+     * @param array<int|string, string|string[]>|string|null $formats
+     */
     public function withFormats($formats = null): static
     {
         $self = clone $this;
@@ -324,11 +330,17 @@ public function withFormats($formats = null): static
         return $self;
     }
 
+    /**
+     * @return array<int|string, string|string[]>|string|null
+     */
     public function getInputFormats()
     {
         return $this->inputFormats;
     }
 
+    /**
+     * @param array<int|string, string|string[]>|string|null $inputFormats
+     */
     public function withInputFormats($inputFormats = null): static
     {
         $self = clone $this;
@@ -337,11 +349,17 @@ public function withInputFormats($inputFormats = null): static
         return $self;
     }
 
+    /**
+     * @return array<int|string, string|string[]>|string|null
+     */
     public function getOutputFormats()
     {
         return $this->outputFormats;
     }
 
+    /**
+     * @param array<int|string, string|string[]>|string|null $outputFormats
+     */
     public function withOutputFormats($outputFormats = null): static
     {
         $self = clone $this;
@@ -350,6 +368,9 @@ public function withOutputFormats($outputFormats = null): static
         return $self;
     }
 
+    /**
+     * @return array<string, mixed>|array<int, Link>|list<string>|null
+     */
     public function getUriVariables()
     {
         return $this->uriVariables;

src/Metadata/Metadata.php

@@ -224,54 +224,51 @@ public function withFilters(array $filters): static
         return $self;
     }
 
-    /**
-     * @return array|bool|mixed|null
-     */
-    public function getMercure()
+    public function getMercure(): mixed
     {
         return $this->mercure;
     }
 
-    public function withMercure($mercure): static
+    public function withMercure(mixed $mercure): static
     {
         $self = clone $this;
         $self->mercure = $mercure;
 
         return $self;
     }
 
-    public function getMessenger()
+    public function getMessenger(): mixed
     {
         return $this->messenger;
     }
 
-    public function withMessenger($messenger): static
+    public function withMessenger(mixed $messenger): static
     {
         $self = clone $this;
         $self->messenger = $messenger;
 
         return $self;
     }
 
-    public function getInput()
+    public function getInput(): mixed
     {
         return $this->input;
     }
 
-    public function withInput($input): static
+    public function withInput(mixed $input): static
     {
         $self = clone $this;
         $self->input = $input;
 
         return $self;
     }
 
-    public function getOutput()
+    public function getOutput(): mixed
     {
         return $this->output;
     }
 
-    public function withOutput($output): static
+    public function withOutput(mixed $output): static
     {
         $self = clone $this;
         $self->output = $output;

src/Metadata/Resource/Factory/NotExposedOperationResourceMetadataCollectionFactory.php

@@ -29,10 +29,10 @@ final class NotExposedOperationResourceMetadataCollectionFactory implements Reso
 {
     use OperationDefaultsTrait;
 
-    public static $skolemUriTemplate = '/.well-known/genid/{id}';
+    public static string $skolemUriTemplate = '/.well-known/genid/{id}';
 
-    private $linkFactory;
-    private $decorated;
+    private LinkFactoryInterface $linkFactory;
+    private ResourceMetadataCollectionFactoryInterface|null $decorated;
 
     public function __construct(LinkFactoryInterface $linkFactory, ?ResourceMetadataCollectionFactoryInterface $decorated = null)
     {

src/Metadata/UriVariableTransformerInterface.php

@@ -25,6 +25,8 @@ interface UriVariableTransformerInterface
      * @param array $context Options available to the transformer
      *
      * @throws InvalidUriVariableException Occurs when the URI variable could not be transformed
+     *
+     * @return mixed
      */
     public function transform(mixed $value, array $types, array $context = []);
 

src/OpenApi/Model/Header.php

@@ -17,7 +17,7 @@ final class Header
 {
     use ExtensionTrait;
 
-    public function __construct(private readonly string $in = 'header', private string $description = '', private bool $required = false, private bool $deprecated = false, private bool $allowEmptyValue = false, private array $schema = [], private ?string $style = null, private bool $explode = false, private bool $allowReserved = false, private $example = null, private ?\ArrayObject $examples = null, private ?\ArrayObject $content = null)
+    public function __construct(private readonly string $in = 'header', private string $description = '', private bool $required = false, private bool $deprecated = false, private bool $allowEmptyValue = false, private array $schema = [], private ?string $style = null, private bool $explode = false, private bool $allowReserved = false, private mixed $example = null, private ?\ArrayObject $examples = null, private ?\ArrayObject $content = null)
     {
         if (null === $style) {
             $this->style = 'simple';
@@ -84,7 +84,7 @@ public function getAllowReserved(): bool
         return $this->allowReserved;
     }
 
-    public function getExample()
+    public function getExample(): mixed
     {
         return $this->example;
     }