chore: more phpstan fixes

Author: VincentLanglet

phpstan.neon.dist

@@ -54,6 +54,18 @@ parameters:
 				- tests/Fixtures/TestBundle/Document/
 				- tests/Fixtures/TestBundle/Entity/
 				- src/OpenApi/Factory/OpenApiFactory.php
+		-
+			message: '#is never assigned .* so it can be removed from the property type.#'
+			paths:
+				- src/Doctrine/Common/Tests/Fixtures/
+				- src/Doctrine/Orm/Tests/Fixtures/
+				- src/Doctrine/Odm/Tests/Fixtures/
+				- src/Elasticsearch/Tests/Fixtures/
+				- src/GraphQl/Tests/Fixtures/
+				- src/JsonSchema/Tests/Fixtures/
+				- src/Metadata/Tests/Fixtures/
+				- src/Serializer/Tests/Fixtures/
+				- tests/Fixtures/
 		-
 			message: '#is never written, only read.#'
 			paths:
@@ -101,14 +113,5 @@ parameters:
 		- '#^Call to (static )?method PHPUnit\\Framework\\Assert::.* will always evaluate to true\.$#'
 
 		# TODO For PHPStan 2.0
-		-
-		    path: tests/
-		    identifier: function.alreadyNarrowedType
-		-
-		    identifier: property.unusedType
 		-
 		    identifier: varTag.nativeType
-		-
-		    identifier: trait.unused
-		-
-		    identifier: catch.neverThrown

src/Metadata/ApiProperty.php

@@ -230,7 +230,7 @@ public function __construct(
         private array $extraProperties = [],
     ) {
         $this->types = \is_string($types) ? (array) $types : $types;
-        $this->serialize = \is_array($serialize) ? $serialize : [$serialize];
+        $this->serialize = (null === $serialize || \is_array($serialize)) ? $serialize : [$serialize];
         $this->nativeType = $nativeType;
 
         if ($this->builtinTypes) {

src/Metadata/IdentifiersExtractorInterface.php

@@ -13,6 +13,7 @@
 
 namespace ApiPlatform\Metadata;
 
+use ApiPlatform\Metadata\Exception\InvalidArgumentException;
 use ApiPlatform\Metadata\Exception\RuntimeException;
 
 /**
@@ -28,6 +29,7 @@ interface IdentifiersExtractorInterface
      * @param array<string, mixed> $context
      *
      * @throws RuntimeException
+     * @throws InvalidArgumentException
      *
      * @return array<string, mixed>
      */

src/Metadata/IriConverterInterface.php

@@ -15,6 +15,7 @@
 
 use ApiPlatform\Metadata\Exception\InvalidArgumentException;
 use ApiPlatform\Metadata\Exception\ItemNotFoundException;
+use ApiPlatform\Metadata\Exception\OperationNotFoundException;
 use ApiPlatform\Metadata\Exception\RuntimeException;
 
 /**
@@ -40,6 +41,7 @@ public function getResourceFromIri(string $iri, array $context = [], ?Operation
      * @param object|class-string                                                                                                                       $resource
      * @param array<string, mixed>|array{force_resource_class?: string|class-string, item_uri_template?: string, uri_variables?: array<string, string>} $context
      *
+     * @throws OperationNotFoundException
      * @throws InvalidArgumentException
      * @throws RuntimeException
      */

src/Metadata/IsApiResource.php

@@ -15,6 +15,8 @@
 
 /**
  * @author Kévin Dunglas <[email protected]>
+ *
+ * @phpstan-ignore trait.unused
  */
 trait IsApiResource
 {

tests/Behat/JsonApiContext.php

@@ -121,10 +121,6 @@ public function theJsonNodeShouldBeSorted(string $node = ''): void
     {
         $actual = (array) $this->getValueOfNode($node);
 
-        if (!\is_array($actual)) {
-            throw new \Exception(\sprintf('The "%s" node value is not an array', $node));
-        }
-
         $expected = $actual;
         ksort($expected);
 

tests/Fixtures/TestBundle/Security/SecuredDummyAttributeBasedVoter.php

@@ -45,7 +45,7 @@ protected function voteOnAttribute(string $attribute, mixed $subject, TokenInter
             return false;
         }
 
-        if (!\in_array($subject, array_keys(self::RBAC), true) || !\is_array(self::RBAC[$subject])) {
+        if (!array_key_exists($subject, self::RBAC)) {
             return false;
         }