better maxDepth in extractor

Author: Nightbr

src/Metadata/Property/Factory/ExtractorPropertyMetadataFactory.php

@@ -142,15 +142,14 @@ private function createSubresourceMetadata($subresource, PropertyMetadata $prope
         }
 
         $type = $propertyMetadata->getType();
+        $maxDepth = $subresource['maxDepth'] ?? null;
 
         if (null !== $type) {
             $isCollection = $type->isCollection();
             $resourceClass = $isCollection ? $type->getCollectionValueType()->getClassName() : $type->getClassName();
-            $maxDepth = null; // for Type we can't configure maxDepth, maxDepth is always null
         } elseif (isset($subresource['resourceClass'])) {
             $resourceClass = $subresource['resourceClass'];
             $isCollection = $subresource['collection'] ?? true;
-            $maxDepth = $subresource['maxDepth'] ?? null;
         } else {
             return null;
         }

tests/Metadata/Property/Factory/ExtractorPropertyMetadataFactoryTest.php

@@ -130,7 +130,7 @@ public function testCreateWithParentPropertyMetadataFactoryYaml(PropertyMetadata
     }
 
     /**
-     * @dataProvider typedPropertyMetadataProvider
+     * @dataProvider decoratedPropertyMetadataProvider
      */
     public function testCreateWithCollectionTypedParentPropertyMetadataFactoryYaml(PropertyMetadata $expectedPropertyMetadata)
     {
@@ -145,7 +145,7 @@ public function testCreateWithCollectionTypedParentPropertyMetadataFactoryYaml(P
                 );
 
         $expectedPropertyMetadata = $expectedPropertyMetadata->withType($collectionType);
-        $expectedPropertyMetadata = $expectedPropertyMetadata->withSubresource(new SubresourceMetadata(RelatedDummy::class, true));
+        $expectedPropertyMetadata = $expectedPropertyMetadata->withSubresource(new SubresourceMetadata(RelatedDummy::class, true, 1));
 
         $decorated = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $decorated
@@ -161,7 +161,7 @@ public function testCreateWithCollectionTypedParentPropertyMetadataFactoryYaml(P
     }
 
     /**
-     * @dataProvider typedPropertyMetadataProvider
+     * @dataProvider decoratedPropertyMetadataProvider
      */
     public function testCreateWithTypedParentPropertyMetadataFactoryYaml(PropertyMetadata $expectedPropertyMetadata)
     {
@@ -170,7 +170,7 @@ public function testCreateWithTypedParentPropertyMetadataFactoryYaml(PropertyMet
         $type = new Type(Type::BUILTIN_TYPE_OBJECT, false, RelatedDummy::class);
 
         $expectedPropertyMetadata = $expectedPropertyMetadata->withType($type);
-        $expectedPropertyMetadata = $expectedPropertyMetadata->withSubresource(new SubresourceMetadata(RelatedDummy::class, false));
+        $expectedPropertyMetadata = $expectedPropertyMetadata->withSubresource(new SubresourceMetadata(RelatedDummy::class, false, 1));
 
         $decorated = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $decorated

tests/Metadata/Property/Factory/FileConfigurationMetadataFactoryProvider.php

@@ -61,24 +61,6 @@ public function decoratedPropertyMetadataProvider()
         return [[$this->getPropertyMetadata($metadata)]];
     }
 
-    public function typedPropertyMetadataProvider()
-    {
-        // for Type we can't configure maxDepth, maxDepth is always null
-        $metadata = [
-            'description' => 'The dummy foo',
-            'readable' => true,
-            'writable' => true,
-            'readableLink' => true,
-            'writableLink' => false,
-            'required' => true,
-            'identifier' => false,
-            'attributes' => ['Foo'],
-            'subresource' => new SubresourceMetadata('Foo', true),
-        ];
-
-        return [[$this->getPropertyMetadata($metadata)]];
-    }
-
     private function getPropertyMetadata(array $metadata): PropertyMetadata
     {
         $propertyMetadata = new PropertyMetadata();