Skip to content

Commit cde69f8

Browse files
committed
Merge pull request #569 from api-platform/prophecy
Unskip tests using Prophecy
2 parents 263bbd6 + 789f664 commit cde69f8

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,5 @@ install:
2727
- composer update --no-interaction --prefer-dist
2828

2929
script:
30-
- phpunit
30+
- vendor/bin/phpunit
3131
- vendor/bin/behat

appveyor.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ install:
2222
- cd %APPVEYOR_BUILD_FOLDER%
2323
- php -r "readfile('http://getcomposer.org/installer');" | php
2424
- php composer.phar install --no-interaction --no-progress
25-
- appveyor DownloadFile https://phar.phpunit.de/phpunit.phar
2625

2726
test_script:
2827
- cd %APPVEYOR_BUILD_FOLDER%
29-
- php phpunit.phar
3028
- php vendor\behat\behat\bin\behat
29+
- php vendor\phpunit\phpunit\phpunit

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"willdurand/negotiation": "^2.0"
2525
},
2626
"require-dev": {
27+
"phpunit/phpunit": "^5.0",
2728
"behat/behat": "^3.1",
2829
"behat/mink": "^1.7",
2930
"behat/mink-browserkit-driver": "^1.3.1",
@@ -36,7 +37,7 @@
3637
"nelmio/api-doc-bundle": "^2.11.2",
3738
"php-mock/php-mock-phpunit": "^1.1",
3839
"phpdocumentor/reflection-docblock": "^3.0",
39-
"symfony/cache": "^3.1@dev",
40+
"symfony/cache": "^3.1",
4041
"symfony/dependency-injection": "^2.8 || ^3.0",
4142
"symfony/framework-bundle": "^3.1",
4243
"symfony/phpunit-bridge": "^3.1",

tests/Bridge/Doctrine/Orm/Filter/SearchFilterTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ protected function setUp()
7575
*/
7676
public function testApply(array $filterParameters, array $query, $expected)
7777
{
78-
$this->markTestSkipped('Require Prophecy to update to phpDocumentor/reflection-docblock 3.');
79-
8078
$request = Request::create('/api/dummies', 'GET', $query);
8179
$requestStack = new RequestStack();
8280
$requestStack->push($request);
@@ -441,7 +439,7 @@ public function filterProvider()
441439
'relatedDummies' => [['foo']],
442440
],
443441
[
444-
'dql' => sprintf('SELECT o FROM %s o inner join o.relatedDummy relatedDummy_123456abcdefg WHERE relatedDummy_123456abcdefg.id = :relatedDummy_123456abcdefg', Dummy::class),
442+
'dql' => sprintf('SELECT o FROM %s o INNER JOIN o.relateddummy relateddummy_123456abcdefg WHERE o.name = :name_123456abcdefg AND relateddummy_123456abcdefg.id = :relateddummy_123456abcdefg', Dummy::class),
445443
'parameters' => [
446444
'relatedDummy_123456abcdefg' => 'foo',
447445
],

tests/Metadata/Resource/Factory/PhpDocResourceMetadataFactoryTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ public function testNoDocBlock()
4343

4444
public function testExtractDescription()
4545
{
46-
$this->markTestSkipped('Require Prophecy to update to phpDocumentor/reflection-docblock 3.');
47-
4846
$decoratedProphecy = $this->prophesize(ResourceMetadataFactoryInterface::class);
4947
$decoratedProphecy->create(DummyEntity::class)->willReturn(new ResourceMetadata())->shouldBeCalled();
5048
$decorated = $decoratedProphecy->reveal();

0 commit comments

Comments
 (0)