attempt

Author: soyuka

phpstan.neon.dist

@@ -82,10 +82,6 @@ parameters:
 			message: '#Service "test" is not registered in the container\.#'
 			path: src/GraphQl/Tests/Type/TypesContainerTest.php
 
-		# Expected, due to optional interfaces
-		- '#Method Symfony\\Component\\Serializer\\NameConverter\\NameConverterInterface::denormalize\(\) invoked with (2|3|4) parameters, 1 required\.#'
-		- '#Method Symfony\\Component\\Serializer\\NameConverter\\NameConverterInterface::normalize\(\) invoked with (2|3|4) parameters, 1 required\.#'
-
 		# Expected, due to backward compatibility
 		- '#Method GraphQL\\Type\\Definition\\WrappingType::getWrappedType\(\) invoked with 1 parameter, 0 required\.#'
 		- '#Access to an undefined property GraphQL\\Type\\Definition\\NamedType&GraphQL\\Type\\Definition\\Type::\$name\.#'
@@ -97,16 +93,6 @@ parameters:
 		- "#Call to function method_exists\\(\\) with Symfony\\\\Component\\\\Serializer\\\\Normalizer\\\\NormalizerInterface and 'getSupportedTypes' will always evaluate to true\\.#"
 		- "#Call to function method_exists\\(\\) with Doctrine\\\\ODM\\\\MongoDB\\\\Configuration and 'setMetadataCache' will always evaluate to true\\.#"
 		- "#Call to function method_exists\\(\\) with Doctrine\\\\ODM\\\\MongoDB\\\\Mapping\\\\ClassMetadata\\|Doctrine\\\\ORM\\\\Mapping\\\\ClassMetadata and 'isChangeTrackingDef…' will always evaluate to true\\.#"
-		-
-			message: '#Instanceof between Symfony\\Component\\Serializer\\NameConverter\\NameConverterInterface and Symfony\\Component\\Serializer\\NameConverter\\MetadataAwareNameConverter will always evaluate to false\.#'
-			paths:
-				- src/GraphQl/Serializer/SerializerContextBuilder.php
-				- src/GraphQl/Type/FieldsBuilder.php
-		-
-			message: '#Instanceof between Symfony\\Component\\Serializer\\NameConverter\\NameConverterInterface\|null and Symfony\\Component\\Serializer\\NameConverter\\MetadataAwareNameConverter will always evaluate to false\.#'
-			paths:
-				- src/Serializer/AbstractConstraintViolationListNormalizer.php
-				- src/Symfony/Validator/Serializer/ValidationExceptionNormalizer.php
 
 		# See https://github.com/phpstan/phpstan-symfony/issues/27
 		-

src/Metadata/Property/Factory/PropertyInfoPropertyMetadataFactory.php

@@ -49,7 +49,7 @@ public function create(string $resourceClass, string $property, array $options =
         // TODO: remove in 5.x
         if (!method_exists(PropertyInfoExtractor::class, 'getType')) {
             if (!$propertyMetadata->getBuiltinTypes()) {
-                $types = $this->propertyInfo->getTypes($resourceClass, $property, $options) ?? [];
+                $types = $this->propertyInfo->getTypes($resourceClass, $property, $options) ?? []; // @phpstan-ignore-line
 
                 foreach ($types as $i => $type) {
                     // Temp fix for https://github.com/symfony/symfony/pull/52699

src/Serializer/Mapping/Loader/PropertyMetadataLoader.php

@@ -64,14 +64,14 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool
             $attribute = $a->newInstance();
             if ($attribute instanceof DiscriminatorMap) {
                 $classMetadata->setClassDiscriminatorMapping(new ClassDiscriminatorMapping(
-                    $attribute->getTypeProperty(),
-                    $attribute->getMapping()
+                    $attribute->typeProperty,
+                    $attribute->mapping
                 ));
                 continue;
             }
 
             if ($attribute instanceof Groups) {
-                $classGroups = $attribute->getGroups();
+                $classGroups = $attribute->groups;
 
                 continue;
             }
@@ -116,16 +116,16 @@ public function loadClassMetadata(ClassMetadataInterface $classMetadata): bool
             // This code is adapted from Symfony\Component\Serializer\Mapping\Loader\AttributeLoader
             foreach ($attributes[$propertyName] as $attr) {
                 if ($attr instanceof Groups) {
-                    foreach ($attr->getGroups() as $group) {
+                    foreach ($attr->groups as $group) {
                         $attributeMetadata->addGroup($group);
                     }
                     continue;
                 }
 
                 match (true) {
-                    $attr instanceof MaxDepth => $attributeMetadata->setMaxDepth($attr->getMaxDepth()),
-                    $attr instanceof SerializedName => $attributeMetadata->setSerializedName($attr->getSerializedName()),
-                    $attr instanceof SerializedPath => $attributeMetadata->setSerializedPath($attr->getSerializedPath()),
+                    $attr instanceof MaxDepth => $attributeMetadata->setMaxDepth($attr->maxDepth),
+                    $attr instanceof SerializedName => $attributeMetadata->setSerializedName($attr->serializedName),
+                    $attr instanceof SerializedPath => $attributeMetadata->setSerializedPath($attr->serializedPath),
                     $attr instanceof Ignore => $attributeMetadata->setIgnore(true),
                     $attr instanceof Context => $this->setAttributeContextsForGroups($attr, $attributeMetadata),
                     default => null,
@@ -148,10 +148,10 @@ private function addAttributeMetadata(ApiProperty $attribute, array &$attributes
 
     private function setAttributeContextsForGroups(Context $annotation, AttributeMetadataInterface $attributeMetadata): void
     {
-        $context = $annotation->getContext();
-        $groups = $annotation->getGroups();
-        $normalizationContext = $annotation->getNormalizationContext();
-        $denormalizationContext = $annotation->getDenormalizationContext();
+        $context = $annotation->context;
+        $groups = $annotation->groups;
+        $normalizationContext = $annotation->normalizationContext;
+        $denormalizationContext = $annotation->denormalizationContext;
         if ($normalizationContext || $context) {
             $attributeMetadata->setNormalizationContextForGroups($normalizationContext ?: $context, $groups);
         }

tests/Fixtures/TestBundle/Entity/DummyCarColor.php

@@ -17,7 +17,7 @@
 use ApiPlatform\Metadata\ApiFilter;
 use ApiPlatform\Metadata\ApiResource;
 use Doctrine\ORM\Mapping as ORM;
-use Symfony\Component\Serializer\Attributes as Serializer;
+use Symfony\Component\Serializer\Attribute\Groups;
 use Symfony\Component\Validator\Constraints as Assert;
 
 #[ApiResource]
@@ -38,7 +38,7 @@ class DummyCarColor
     #[ApiFilter(SearchFilter::class)]
     #[ORM\Column(nullable: false)]
     #[Assert\NotBlank]
-    #[Serializer\Groups(['colors'])]
+    #[Groups(['colors'])]
     private string $prop = '';
 
     public function getId(): ?int

tests/Fixtures/TestBundle/Entity/UidIdentified.php

@@ -16,8 +16,6 @@
 use ApiPlatform\Metadata\ApiProperty;
 use ApiPlatform\Metadata\Put;
 use Doctrine\ORM\Mapping as ORM;
-use Symfony\Component\Serializer\Attribute\Ignore as LegacyIgnore;
-use Symfony\Component\Serializer\Attribute\SerializedName as LegacySerializedName;
 use Symfony\Component\Serializer\Attribute\Ignore;
 use Symfony\Component\Serializer\Attribute\SerializedName;
 use Symfony\Component\Uid\Uuid;
@@ -40,13 +38,11 @@ class UidIdentified
     #[ORM\GeneratedValue]
     #[ApiProperty(identifier: false)]
     #[Ignore]
-    #[LegacyIgnore]
     private ?int $id = null;
 
     #[ORM\Column(type: 'symfony_uuid', unique: true, nullable: false)]
     #[ApiProperty(identifier: true)]
     #[SerializedName('id')]
-    #[LegacySerializedName('id')]
     private ?Uuid $uuid = null;
 
     /**