test: test parameters type detection

Author: vincentchalamon

src/Metadata/Resource/Factory/ParameterResourceMetadataCollectionFactory.php

@@ -158,6 +158,10 @@ private function getDefaultParameters(Operation $operation, string $resourceClas
                     $parameter = $parameter->withNativeType(Type::string());
                 } elseif ('boolean' === ($parameter->getSchema()['type'] ?? null)) {
                     $parameter = $parameter->withNativeType(Type::bool());
+                } elseif ('integer' === ($parameter->getSchema()['type'] ?? null)) {
+                    $parameter = $parameter->withNativeType(Type::int());
+                } elseif ('number' === ($parameter->getSchema()['type'] ?? null)) {
+                    $parameter = $parameter->withNativeType(Type::float());
                 } else {
                     $parameter = $parameter->withNativeType(Type::union(Type::string(), Type::list(Type::string())));
                 }

src/Validator/Metadata/Resource/Factory/ParameterValidationResourceMetadataCollectionFactory.php

@@ -189,8 +189,9 @@ private function addSchemaValidation(Parameter $parameter, ?array $schema = null
             $assertions[] = new Unique();
         }
 
-        if (isset($schema['type']) && 'array' === $schema['type']) {
-            $assertions[] = new Type(type: 'array');
+        // Can't test "boolean"/"integer"/"number" because value is sent as a string
+        if (isset($schema['type']) && \in_array($schema['type'], ['array', 'null'], true)) {
+            $assertions[] = new Type(type: $schema['type']);
         }
 
         if (!$assertions) {

tests/Fixtures/TestBundle/ApiResource/WithParameter.php

@@ -165,7 +165,43 @@
                 'minimum' => 1,
                 'maximum' => 5,
             ],
-            required: true,
+        ),
+    ],
+    provider: [self::class, 'noopProvider']
+)]
+#[GetCollection(
+    uriTemplate: 'header_float',
+    parameters: [
+        'Bar' => new HeaderParameter(
+            schema: [
+                'type' => 'number',
+                'example' => 42.0,
+                'minimum' => 1.0,
+                'maximum' => 100.0,
+                'multipleOf' => 0.01,
+            ],
+        ),
+    ],
+    provider: [self::class, 'noopProvider']
+)]
+#[GetCollection(
+    uriTemplate: 'header_boolean',
+    parameters: [
+        'Lorem' => new HeaderParameter(
+            schema: [
+                'type' => 'boolean',
+            ],
+        ),
+    ],
+    provider: [self::class, 'noopProvider']
+)]
+#[GetCollection(
+    uriTemplate: 'query_array',
+    parameters: [
+        'Baz' => new QueryParameter(
+            schema: [
+                'type' => 'array',
+            ],
         ),
     ],
     provider: [self::class, 'noopProvider']

tests/Functional/Parameters/ParameterTest.php

@@ -121,18 +121,33 @@ public function testHeaderParameterRequired(): void
     }
 
     #[DataProvider('provideHeaderValues')]
-    public function testHeaderParameterInteger(string $value, int $expectedStatusCode): void
+    public function testHeaderParameter(string $url, array $headers, int $expectedStatusCode): void
     {
-        self::createClient()->request('GET', 'header_integer', ['headers' => ['Foo' => $value]]);
+        self::createClient()->request('GET', $url, ['headers' => $headers]);
         $this->assertResponseStatusCodeSame($expectedStatusCode);
     }
 
     public static function provideHeaderValues(): iterable
     {
-        yield 'valid integer' => ['3', 200];
-        yield 'too high' => ['6', 422];
-        yield 'too low' => ['0', 422];
-        yield 'invalid integer' => ['string', 422];
+        // header_integer
+        yield 'valid integer header_integer' => ['header_integer', ['Foo' => '3'], 200];
+        yield 'too high header_integer' => ['header_integer', ['Foo' => '6'], 422];
+        yield 'too low header_integer' => ['header_integer', ['Foo' => '0'], 422];
+        yield 'invalid integer header_integer' => ['header_integer', ['Foo' => 'string'], 422];
+
+        // header_float
+        yield 'valid float header_float' => ['header_float', ['Bar' => '3.5'], 200];
+        yield 'valid integer header_float' => ['header_float', ['Bar' => '3'], 200];
+        yield 'too high header_float' => ['header_float', ['Bar' => '600'], 422];
+        yield 'too low header_float' => ['header_float', ['Bar' => '0'], 422];
+        yield 'invalid number header_float' => ['header_float', ['Bar' => 'string'], 422];
+
+        // header_boolean
+        yield 'valid boolean false header_boolean' => ['header_boolean', ['Lorem' => 'false'], 200];
+        yield 'valid boolean true header_boolean' => ['header_boolean', ['Lorem' => 'false'], 200];
+        yield 'valid boolean 0 header_boolean' => ['header_boolean', ['Lorem' => '0'], 200];
+        yield 'valid boolean 1 header_boolean' => ['header_boolean', ['Lorem' => '1'], 200];
+        yield 'invalid boolean header_boolean' => ['header_boolean', ['Lorem' => 'string'], 422];
     }
 
     #[DataProvider('provideCountryValues')]