If docs are disabled, do not try to add a link header to the docs (#1731)

* Remove add_link_header service if docs are disabled

* Add tests on disabling docs

Author: Taluu

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -129,7 +129,7 @@ public function load(array $configs, ContainerBuilder $container)
         $this->registerApiKeysConfiguration($container, $config, $loader);
         $this->registerSwaggerConfiguration($container, $config, $loader);
         $this->registerJsonApiConfiguration($formats, $loader);
-        $this->registerJsonLdConfiguration($formats, $loader);
+        $this->registerJsonLdConfiguration($container, $formats, $loader, $config['enable_docs']);
         $this->registerJsonHalConfiguration($formats, $loader);
         $this->registerJsonProblemConfiguration($errorFormats, $loader);
         $this->registerGraphqlConfiguration($container, $config, $loader);
@@ -366,17 +366,23 @@ private function registerJsonApiConfiguration(array $formats, XmlFileLoader $loa
     /**
      * Registers the JSON-LD and Hydra configuration.
      *
-     * @param array         $formats
-     * @param XmlFileLoader $loader
+     * @param ContainerBuilder $container
+     * @param array            $formats
+     * @param XmlFileLoader    $loader
+     * @param bool             $docEnabled
      */
-    private function registerJsonLdConfiguration(array $formats, XmlFileLoader $loader)
+    private function registerJsonLdConfiguration(ContainerBuilder $container, array $formats, XmlFileLoader $loader, bool $docEnabled)
     {
         if (!isset($formats['jsonld'])) {
             return;
         }
 
         $loader->load('jsonld.xml');
         $loader->load('hydra.xml');
+
+        if (!$docEnabled) {
+            $container->removeDefinition('api_platform.hydra.listener.response.add_link_header');
+        }
     }
 
     /**

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -344,6 +344,20 @@ public function testNotRegisterHttpCacheWhenEnabledWithNoVarnishServer()
         $this->extension->load($config, $containerBuilder);
     }
 
+    public function testDisabledDocsRemovesAddLinkHeaderService()
+    {
+        $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
+        $containerBuilderProphecy->removeDefinition('api_platform.hydra.listener.response.add_link_header')->shouldBeCalled();
+        $containerBuilderProphecy->setParameter('api_platform.enable_docs', false)->shouldBeCalled();
+        $containerBuilderProphecy->setParameter('api_platform.enable_docs', true)->shouldNotBeCalled();
+        $containerBuilder = $containerBuilderProphecy->reveal();
+
+        $config = self::DEFAULT_CONFIG;
+        $config['api_platform']['enable_docs'] = false;
+
+        $this->extension->load($config, $containerBuilder);
+    }
+
     private function getPartialContainerBuilderProphecy($test = false)
     {
         $containerBuilderProphecy = $this->prophesize(ContainerBuilder::class);