feat(openapi): make open_api_override_responses act on default 404 response generation (#6551)

monitaurus · web-flow · commit db1241c66a08 · 2024-08-30T10:06:28.000+02:00
diff --git a/src/OpenApi/Factory/OpenApiFactory.php b/src/OpenApi/Factory/OpenApiFactory.php
@@ -374,7 +374,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection
                 }
             }
 
-            if (!$operation instanceof CollectionOperationInterface && 'POST' !== $operation->getMethod()) {
+            if (true === $overrideResponses && !$operation instanceof CollectionOperationInterface && 'POST' !== $operation->getMethod()) {
                 if (!isset($existingResponses[404])) {
                     $openapiOperation = $openapiOperation->withResponse(404, new Response('Resource not found'));
                 }

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ private function collectPaths(ApiResource $resource, ResourceMetadataCollection`
`374`	`374`	`}`
`375`	`375`	`}`
`376`	`376`
`377`		`- if (!$operation instanceof CollectionOperationInterface && 'POST' !== $operation->getMethod()) {`
	`377`	`+ if (true === $overrideResponses && !$operation instanceof CollectionOperationInterface && 'POST' !== $operation->getMethod()) {`
`378`	`378`	`if (!isset($existingResponses[404])) {`
`379`	`379`	`$openapiOperation = $openapiOperation->withResponse(404, new Response('Resource not found'));`
`380`	`380`	`}`