fix(state): parameter default value overrides falsy value

fixes #7354

Author: soyuka

src/State/Provider/ParameterProvider.php

@@ -77,7 +77,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
                 unset($parameter->getExtraProperties()['_api_values']);
             }
 
-            if (($default = $parameter->getSchema()['default'] ?? false) && ($value instanceof ParameterNotFound || !$value)) {
+            if (($default = $parameter->getSchema()['default'] ?? false) && $value instanceof ParameterNotFound) {
                 $value = $default;
             }
 

tests/Fixtures/TestBundle/ApiResource/Issue7354/BooleanQueryParameter.php

@@ -0,0 +1,49 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue7354;
+
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use ApiPlatform\Metadata\Operation;
+use ApiPlatform\Metadata\QueryParameter;
+
+#[ApiResource(
+    operations: [
+        new Get(
+            normalizationContext: ['hydra_prefix' => false],
+            uriTemplate: '/issue7354_boolean_query_parameters',
+            parameters: [
+                'booleanParameter' => new QueryParameter(
+                    schema: [
+                        'type' => 'boolean',
+                        'default' => true,
+                    ],
+                    castToNativeType: true,
+                ),
+            ],
+            provider: [self::class, 'provide'],
+        ),
+    ]
+)]
+class BooleanQueryParameter
+{
+    public function __construct(public bool $booleanParameter)
+    {
+    }
+
+    public static function provide(Operation $operation): self
+    {
+        return new self($operation->getParameters()->get('booleanParameter')->getValue());
+    }
+}

tests/Functional/Issue7354Test.php

@@ -0,0 +1,54 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Functional;
+
+use ApiPlatform\Symfony\Bundle\Test\ApiTestCase;
+use ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\Issue7354\BooleanQueryParameter;
+use ApiPlatform\Tests\SetupClassResourcesTrait;
+
+final class Issue7354Test extends ApiTestCase
+{
+    use SetupClassResourcesTrait;
+
+    protected static ?bool $alwaysBootKernel = false;
+
+    /**
+     * @return class-string[]
+     */
+    public static function getResources(): array
+    {
+        return [BooleanQueryParameter::class];
+    }
+
+    public function testBooleanQueryParameterDefaultOverride(): void
+    {
+        self::createClient()->request('GET', '/issue7354_boolean_query_parameters?booleanParameter=false');
+        $this->assertResponseIsSuccessful();
+        $this->assertJsonContains(['booleanParameter' => false]);
+    }
+
+    public function testBooleanQueryParameterDefaultNotOverride(): void
+    {
+        self::createClient()->request('GET', '/issue7354_boolean_query_parameters?booleanParameter=true');
+        $this->assertResponseIsSuccessful();
+        $this->assertJsonContains(['booleanParameter' => true]);
+    }
+
+    public function testBooleanQueryParameterDefaultValue(): void
+    {
+        self::createClient()->request('GET', '/issue7354_boolean_query_parameters');
+        $this->assertResponseIsSuccessful();
+        $this->assertJsonContains(['booleanParameter' => true]);
+    }
+}