Merge pull request #778 from meyerbaptiste/fix_cs

dunglas · web-flow · commit f1a6537f9912 · 2016-09-30T12:02:55.000+02:00
Fix CS &amp; PHPDoc
diff --git a/src/Api/IriConverterInterface.php b/src/Api/IriConverterInterface.php
@@ -50,7 +50,7 @@ public function getIriFromItem($item, int $referenceType = UrlGeneratorInterface
      * Gets the IRI associated with the given resource collection.
      *
      * @param string $resourceClass
-     * @param string $referenceType
+     * @param int    $referenceType
      *
      * @throws InvalidArgumentException
      *
diff --git a/src/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php b/src/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php
@@ -66,6 +66,8 @@ public function getMetadataProperties(string $resourceClass) : array
      *
      * @param QueryBuilder $queryBuilder
      * @param string       $resourceClass
+     * @param string       $originAlias
+     * @param string       $relationAlias
      */
     private function joinRelations(QueryBuilder $queryBuilder, string $resourceClass, string $originAlias = 'o', string &$relationAlias = 'a')
     {
diff --git a/src/Bridge/Doctrine/Orm/Extension/QueryCollectionExtensionInterface.php b/src/Bridge/Doctrine/Orm/Extension/QueryCollectionExtensionInterface.php
@@ -23,9 +23,10 @@
 interface QueryCollectionExtensionInterface
 {
     /**
-     * @param QueryBuilder $queryBuilder
-     * @param string       $resourceClass
-     * @param string       $operationName
+     * @param QueryBuilder                $queryBuilder
+     * @param QueryNameGeneratorInterface $queryNameGenerator
+     * @param string                      $resourceClass
+     * @param string|null                 $operationName
      */
     public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null);
 }
diff --git a/src/Bridge/Doctrine/Orm/Extension/QueryItemExtensionInterface.php b/src/Bridge/Doctrine/Orm/Extension/QueryItemExtensionInterface.php
@@ -23,10 +23,11 @@
 interface QueryItemExtensionInterface
 {
     /**
-     * @param QueryBuilder $queryBuilder
-     * @param string       $resourceClass
-     * @param array        $identifiers
-     * @param string|null  $operationName
+     * @param QueryBuilder                $queryBuilder
+     * @param QueryNameGeneratorInterface $queryNameGenerator
+     * @param string                      $resourceClass
+     * @param array                       $identifiers
+     * @param string|null                 $operationName
      */
     public function applyToItem(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, array $identifiers, string $operationName = null);
 }
diff --git a/src/Bridge/Doctrine/Orm/Filter/AbstractFilter.php b/src/Bridge/Doctrine/Orm/Filter/AbstractFilter.php
@@ -270,10 +270,10 @@ private function getExistingJoin(QueryBuilder $queryBuilder, string $alias, stri
     /**
      * Adds a join to the queryBuilder if none exists.
      *
-     * @param QueryBuilder       $queryBuilder
-     * @param QueryNameGenerator $queryNameGenerator
-     * @param string             $alias
-     * @param string             $association        the association field
+     * @param QueryBuilder                $queryBuilder
+     * @param QueryNameGeneratorInterface $queryNameGenerator
+     * @param string                      $alias
+     * @param string                      $association        the association field
      *
      * @return string the new association alias
      */
diff --git a/src/Bridge/Doctrine/Orm/Filter/SearchFilter.php b/src/Bridge/Doctrine/Orm/Filter/SearchFilter.php
@@ -258,12 +258,13 @@ protected function filterProperty(string $property, $value, QueryBuilder $queryB
     /**
      * Adds where clause according to the strategy.
      *
-     * @param string       $strategy
-     * @param QueryBuilder $queryBuilder
-     * @param string       $alias
-     * @param string       $field
-     * @param string       $value
-     * @param bool         $caseSensitive
+     * @param string                      $strategy
+     * @param QueryBuilder                $queryBuilder
+     * @param QueryNameGeneratorInterface $queryNameGenerator
+     * @param string                      $alias
+     * @param string                      $field
+     * @param string                      $value
+     * @param bool                        $caseSensitive
      *
      * @throws InvalidArgumentException If strategy does not exist
      */
diff --git a/src/Bridge/Doctrine/Orm/ItemDataProvider.php b/src/Bridge/Doctrine/Orm/ItemDataProvider.php
@@ -112,6 +112,8 @@ private function addWhereForIdentifiers(array $identifiers, QueryBuilder $queryB
      * @param ObjectManager $manager
      * @param string        $resourceClass
      *
+     * @throws PropertyNotFoundException
+     *
      * @return array
      */
     private function normalizeIdentifiers($id, ObjectManager $manager, string $resourceClass) : array
diff --git a/src/Bridge/Doctrine/Orm/Util/QueryNameGenerator.php b/src/Bridge/Doctrine/Orm/Util/QueryNameGenerator.php
@@ -17,7 +17,6 @@
  * @author Teoh Han Hui <teohhanhui@gmail.com>
  * @author Vincent Chalamon <vincentchalamon@gmail.com>
  * @author Amrouche Hamza <hamza.simperfit@gmail.com>
-
  */
 final class QueryNameGenerator implements QueryNameGeneratorInterface
 {
diff --git a/src/Serializer/AbstractItemNormalizer.php b/src/Serializer/AbstractItemNormalizer.php
@@ -192,6 +192,7 @@ protected function setAttributeValue($object, $attribute, $value, $format = null
      *
      * @param string      $attribute
      * @param Type        $type
+     * @param mixed       $value
      * @param string|null $format
      *
      * @throws InvalidArgumentException
diff --git a/tests/Bridge/Doctrine/Orm/Extension/EagerLoadingExtensionTest.php b/tests/Bridge/Doctrine/Orm/Extension/EagerLoadingExtensionTest.php
@@ -18,7 +18,7 @@
 use ApiPlatform\Core\Metadata\Property\PropertyMetadata;
 use ApiPlatform\Core\Metadata\Property\PropertyNameCollection;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
-use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\DummyRelated;
+use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\RelatedDummy;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\QueryBuilder;
@@ -34,7 +34,7 @@ public function testApplyToCollection()
 
         $relatedNameCollection = new PropertyNameCollection(['id', 'name', 'notindatabase', 'notreadable']);
 
-        $propertyNameCollectionFactoryProphecy->create(DummyRelated::class)->willReturn($relatedNameCollection)->shouldBeCalled();
+        $propertyNameCollectionFactoryProphecy->create(RelatedDummy::class)->willReturn($relatedNameCollection)->shouldBeCalled();
 
         $propertyMetadataFactoryProphecy = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $relationPropertyMetadata = new PropertyMetadata();
@@ -52,18 +52,18 @@ public function testApplyToCollection()
         $notReadablePropertyMetadata = new PropertyMetadata();
         $notReadablePropertyMetadata = $notReadablePropertyMetadata->withReadable(false);
 
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'id')->willReturn($idPropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'name')->willReturn($namePropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'notindatabase')->willReturn($notInDatabasePropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'notreadable')->willReturn($notReadablePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'id')->willReturn($idPropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'name')->willReturn($namePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'notindatabase')->willReturn($notInDatabasePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'notreadable')->willReturn($notReadablePropertyMetadata)->shouldBeCalled();
 
         $queryBuilderProphecy = $this->prophesize(QueryBuilder::class);
 
         $classMetadataProphecy = $this->prophesize(ClassMetadata::class);
         $classMetadataProphecy->getAssociationNames()->shouldBeCalled()->willReturn([0 => 'relatedDummy', 'relatedDummy2']);
         $classMetadataProphecy->associationMappings = [
-            'relatedDummy' => ['fetch' => 3, 'joinColumns' => [['nullable' => true]], 'targetEntity' => DummyRelated::class],
-            'relatedDummy2' => ['fetch' => 3, 'joinColumns' => [['nullable' => false]], 'targetEntity' => DummyRelated::class],
+            'relatedDummy' => ['fetch' => 3, 'joinColumns' => [['nullable' => true]], 'targetEntity' => RelatedDummy::class],
+            'relatedDummy2' => ['fetch' => 3, 'joinColumns' => [['nullable' => false]], 'targetEntity' => RelatedDummy::class],
         ];
 
         $relatedClassMetadataProphecy = $this->prophesize(ClassMetadata::class);
@@ -78,14 +78,14 @@ public function testApplyToCollection()
 
         $emProphecy = $this->prophesize(EntityManager::class);
         $emProphecy->getClassMetadata(Dummy::class)->shouldBeCalled()->willReturn($classMetadataProphecy->reveal());
-        $emProphecy->getClassMetadata(DummyRelated::class)->shouldBeCalled()->willReturn($relatedClassMetadataProphecy->reveal());
+        $emProphecy->getClassMetadata(RelatedDummy::class)->shouldBeCalled()->willReturn($relatedClassMetadataProphecy->reveal());
 
         $queryBuilderProphecy->leftJoin('o.relatedDummy', 'a0')->shouldBeCalled(1);
         $queryBuilderProphecy->innerJoin('o.relatedDummy2', 'a11')->shouldBeCalled(1);
         $queryBuilderProphecy->addSelect('partial a0.{id,name}')->shouldBeCalled(1);
         $queryBuilderProphecy->addSelect('partial a11.{id,name}')->shouldBeCalled(1);
 
-        $em = $queryBuilderProphecy->getEntityManager()->shouldBeCalled(2)->willReturn($emProphecy->reveal());
+        $queryBuilderProphecy->getEntityManager()->shouldBeCalled(2)->willReturn($emProphecy->reveal());
 
         $queryBuilder = $queryBuilderProphecy->reveal();
         $orderExtensionTest = new EagerLoadingExtension($propertyNameCollectionFactoryProphecy->reveal(), $propertyMetadataFactoryProphecy->reveal());
@@ -98,7 +98,7 @@ public function testApplyToItem()
 
         $relatedNameCollection = new PropertyNameCollection(['id', 'name', 'notindatabase', 'notreadable']);
 
-        $propertyNameCollectionFactoryProphecy->create(DummyRelated::class)->willReturn($relatedNameCollection)->shouldBeCalled();
+        $propertyNameCollectionFactoryProphecy->create(RelatedDummy::class)->willReturn($relatedNameCollection)->shouldBeCalled();
 
         $propertyMetadataFactoryProphecy = $this->prophesize(PropertyMetadataFactoryInterface::class);
         $relationPropertyMetadata = new PropertyMetadata();
@@ -118,20 +118,20 @@ public function testApplyToItem()
         $notReadablePropertyMetadata = new PropertyMetadata();
         $notReadablePropertyMetadata = $notReadablePropertyMetadata->withReadable(false);
 
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'id')->willReturn($idPropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'name')->willReturn($namePropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'notindatabase')->willReturn($notInDatabasePropertyMetadata)->shouldBeCalled();
-        $propertyMetadataFactoryProphecy->create(DummyRelated::class, 'notreadable')->willReturn($notReadablePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'id')->willReturn($idPropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'name')->willReturn($namePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'notindatabase')->willReturn($notInDatabasePropertyMetadata)->shouldBeCalled();
+        $propertyMetadataFactoryProphecy->create(RelatedDummy::class, 'notreadable')->willReturn($notReadablePropertyMetadata)->shouldBeCalled();
 
         $queryBuilderProphecy = $this->prophesize(QueryBuilder::class);
 
         $classMetadataProphecy = $this->prophesize(ClassMetadata::class);
         $classMetadataProphecy->getAssociationNames()->shouldBeCalled()->willReturn([0 => 'relatedDummy', 'relatedDummy2', 'relatedDummy3', 'relatedDummy4']);
         $classMetadataProphecy->associationMappings = [
-            'relatedDummy' => ['fetch' => 3, 'joinColumns' => [['nullable' => true]], 'targetEntity' => DummyRelated::class],
-            'relatedDummy2' => ['fetch' => 3, 'joinColumns' => [['nullable' => false]], 'targetEntity' => DummyRelated::class],
-            'relatedDummy3' => ['fetch' => 3, 'joinTable' => ['joinColumns' => [['nullable' => false]]], 'targetEntity' => DummyRelated::class],
-            'relatedDummy4' => ['fetch' => 3, 'targetEntity' => DummyRelated::class],
+            'relatedDummy' => ['fetch' => 3, 'joinColumns' => [['nullable' => true]], 'targetEntity' => RelatedDummy::class],
+            'relatedDummy2' => ['fetch' => 3, 'joinColumns' => [['nullable' => false]], 'targetEntity' => RelatedDummy::class],
+            'relatedDummy3' => ['fetch' => 3, 'joinTable' => ['joinColumns' => [['nullable' => false]]], 'targetEntity' => RelatedDummy::class],
+            'relatedDummy4' => ['fetch' => 3, 'targetEntity' => RelatedDummy::class],
         ];
 
         $relatedClassMetadataProphecy = $this->prophesize(ClassMetadata::class);
@@ -146,7 +146,7 @@ public function testApplyToItem()
 
         $emProphecy = $this->prophesize(EntityManager::class);
         $emProphecy->getClassMetadata(Dummy::class)->shouldBeCalled()->willReturn($classMetadataProphecy->reveal());
-        $emProphecy->getClassMetadata(DummyRelated::class)->shouldBeCalled()->willReturn($relatedClassMetadataProphecy->reveal());
+        $emProphecy->getClassMetadata(RelatedDummy::class)->shouldBeCalled()->willReturn($relatedClassMetadataProphecy->reveal());
 
         $queryBuilderProphecy->leftJoin('o.relatedDummy', 'a0')->shouldBeCalled(1);
         $queryBuilderProphecy->innerJoin('o.relatedDummy2', 'a11')->shouldBeCalled(1);
@@ -157,7 +157,7 @@ public function testApplyToItem()
         $queryBuilderProphecy->addSelect('partial a122.{id,name}')->shouldBeCalled(1);
         $queryBuilderProphecy->addSelect('partial a1233.{id,name}')->shouldBeCalled(1);
 
-        $em = $queryBuilderProphecy->getEntityManager()->shouldBeCalled(2)->willReturn($emProphecy->reveal());
+        $queryBuilderProphecy->getEntityManager()->shouldBeCalled(2)->willReturn($emProphecy->reveal());
 
         $queryBuilder = $queryBuilderProphecy->reveal();
         $orderExtensionTest = new EagerLoadingExtension($propertyNameCollectionFactoryProphecy->reveal(), $propertyMetadataFactoryProphecy->reveal());
diff --git a/tests/Bridge/Doctrine/Orm/Extension/OrderExtensionTest.php b/tests/Bridge/Doctrine/Orm/Extension/OrderExtensionTest.php
@@ -35,7 +35,7 @@ public function testApplyToCollectionWithValidOrder()
         $emProphecy = $this->prophesize(EntityManager::class);
         $emProphecy->getClassMetadata(Dummy::class)->shouldBeCalled()->willReturn($classMetadataProphecy->reveal());
 
-        $em = $queryBuilderProphecy->getEntityManager()->shouldBeCalled()->willReturn($emProphecy->reveal());
+        $queryBuilderProphecy->getEntityManager()->shouldBeCalled()->willReturn($emProphecy->reveal());
 
         $queryBuilder = $queryBuilderProphecy->reveal();
         $orderExtensionTest = new OrderExtension('asc');
@@ -54,7 +54,7 @@ public function testApplyToCollectionWithWrongOrder()
         $emProphecy = $this->prophesize(EntityManager::class);
         $emProphecy->getClassMetadata(Dummy::class)->shouldBeCalled()->willReturn($classMetadataProphecy->reveal());
 
-        $em = $queryBuilderProphecy->getEntityManager()->shouldBeCalled()->willReturn($emProphecy->reveal());
+        $queryBuilderProphecy->getEntityManager()->shouldBeCalled()->willReturn($emProphecy->reveal());
 
         $queryBuilder = $queryBuilderProphecy->reveal();
         $orderExtensionTest = new OrderExtension();
diff --git a/tests/Bridge/Doctrine/Orm/ItemDataProviderTest.php b/tests/Bridge/Doctrine/Orm/ItemDataProviderTest.php
@@ -160,8 +160,6 @@ public function testInvalidIdentifier()
 
     public function testQueryResultExtension()
     {
-        $queryProphecy = $this->prophesize(AbstractQuery::class);
-
         $comparisonProphecy = $this->prophesize(Comparison::class);
         $comparison = $comparisonProphecy->reveal();
 
diff --git a/tests/Bridge/Doctrine/Util/QueryJoinParserTest.php b/tests/Bridge/Doctrine/Util/QueryJoinParserTest.php
@@ -48,7 +48,7 @@ public function testGetJoinRelationshipWithJoin()
     public function testGetJoinRelationshipWithReflection()
     {
         $methodExist = $this->getFunctionMock('ApiPlatform\Core\Bridge\Doctrine\Orm\Util', 'method_exists');
-        $methodExist->expects($this->any(Join::class, 'getJoin'))->willReturn('false');
+        $methodExist->expects($this->any())->with(Join::class, 'getJoin')->willReturn('false');
         $join = new Join('INNER_JOIN', 'relatedDummy', 'a_1', null, 'a_1.name = r.name');
         $this->assertEquals('relatedDummy', QueryJoinParser::getJoinRelationship($join));
     }
@@ -62,7 +62,7 @@ public function testGetJoinAliasWithJoin()
     public function testGetJoinAliasWithReflection()
     {
         $methodExist = $this->getFunctionMock('ApiPlatform\Core\Bridge\Doctrine\Orm\Util', 'method_exists');
-        $methodExist->expects($this->any(Join::class, 'getAlias'))->willReturn('false');
+        $methodExist->expects($this->any())->with(Join::class, 'getAlias')->willReturn('false');
         $join = new Join('INNER_JOIN', 'relatedDummy', 'a_1', null, 'a_1.name = r.name');
         $this->assertEquals('a_1', QueryJoinParser::getJoinAlias($join));
     }
@@ -76,7 +76,7 @@ public function testGetOrderByPartsWithOrderBy()
     public function testGetOrderByPartsWithReflection()
     {
         $methodExist = $this->getFunctionMock('ApiPlatform\Core\Bridge\Doctrine\Orm\Util', 'method_exists');
-        $methodExist->expects($this->any(Join::class, 'getParts'))->willReturn('false');
+        $methodExist->expects($this->any())->with(OrderBy::class, 'getParts')->willReturn('false');
         $orderBy = new OrderBy('name', 'desc');
         $this->assertEquals(['name desc'], QueryJoinParser::getOrderByParts($orderBy));
     }
diff --git a/tests/Bridge/Symfony/Bundle/Action/SwaggerUiActionTest.php b/tests/Bridge/Symfony/Bundle/Action/SwaggerUiActionTest.php
@@ -103,7 +103,6 @@ public function testDoNotRunCurrentRequest(Request $request)
             'formats' => [],
         ])->shouldBeCalled();
 
-
         $action = new SwaggerUiAction(
             $resourceNameCollectionFactoryProphecy->reveal(),
             $resourceMetadataFactoryProphecy->reveal(),
diff --git a/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php b/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
@@ -343,12 +343,10 @@ private function getContainerBuilderProphecy()
             'api_platform.action.get_item' => 'api_platform.action.placeholder',
             'api_platform.action.post_collection' => 'api_platform.action.placeholder',
             'api_platform.action.put_item' => 'api_platform.action.placeholder',
-            'api_platform.action.put_item' => 'api_platform.action.placeholder',
             'api_platform.metadata.property.metadata_factory' => 'api_platform.metadata.property.metadata_factory.annotation',
             'api_platform.metadata.property.name_collection_factory' => 'api_platform.metadata.property.name_collection_factory.property_info',
             'api_platform.metadata.resource.metadata_factory' => 'api_platform.metadata.resource.metadata_factory.annotation',
             'api_platform.metadata.resource.name_collection_factory' => 'api_platform.metadata.resource.name_collection_factory.annotation',
-            'api_platform.metadata.resource.name_collection_factory' => 'api_platform.metadata.resource.name_collection_factory.annotation',
             'api_platform.operation_path_resolver' => 'api_platform.operation_path_resolver.router',
             'api_platform.operation_path_resolver.default' => 'api_platform.operation_path_resolver.underscore',
             'api_platform.property_accessor' => 'property_accessor',
diff --git a/tests/Bridge/Symfony/Routing/RouterTest.php b/tests/Bridge/Symfony/Routing/RouterTest.php
@@ -51,7 +51,7 @@ public function testGenerate()
         $mockedRouter = $this->prophesize('Symfony\Component\Routing\RouterInterface');
         $mockedRouter->generate('foo', [], RouterInterface::ABSOLUTE_PATH)->willReturn('/bar')->shouldBeCalled();
 
-        $router = new \ApiPlatform\Core\Bridge\Symfony\Routing\Router($mockedRouter->reveal());
+        $router = new Router($mockedRouter->reveal());
         $this->assertSame('/bar', $router->generate('foo'));
     }
 
diff --git a/tests/Fixtures/TestBundle/Entity/AbstractDummy.php b/tests/Fixtures/TestBundle/Entity/AbstractDummy.php
@@ -13,7 +13,6 @@
 
 use ApiPlatform\Core\Annotation\ApiProperty;
 use ApiPlatform\Core\Annotation\ApiResource;
-use ApiPlatform\Core\Annotation\Iri;
 use Doctrine\ORM\Mapping as ORM;
 use Symfony\Component\Validator\Constraints as Assert;
 
diff --git a/tests/Hydra/Serializer/ItemNormalizerTest.php b/tests/Hydra/Serializer/ItemNormalizerTest.php
@@ -24,7 +24,6 @@
 use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
 use ApiPlatform\Core\Tests\Fixtures\TestBundle\Entity\Dummy;
 use Prophecy\Argument;
-use Symfony\Component\PropertyInfo\Type;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\SerializerInterface;
 
diff --git a/tests/Metadata/Property/Factory/SerializerPropertyMetadataFactoryTest.php b/tests/Metadata/Property/Factory/SerializerPropertyMetadataFactoryTest.php
diff --git a/tests/Metadata/Resource/Factory/YamlResourceNameCollectionFactoryTest.php b/tests/Metadata/Resource/Factory/YamlResourceNameCollectionFactoryTest.php

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function getIriFromItem($item, int $referenceType = UrlGeneratorInterface`
`50`	`50`	`* Gets the IRI associated with the given resource collection.`
`51`	`51`	`*`
`52`	`52`	`* @param string $resourceClass`
`53`		`- * @param string $referenceType`
	`53`	`+ * @param int $referenceType`
`54`	`54`	`*`
`55`	`55`	`* @throws InvalidArgumentException`
`56`	`56`	`*`
Original file line number	Diff line number	Diff line change
`@@ -66,6 +66,8 @@ public function getMetadataProperties(string $resourceClass) : array`
`66`	`66`	`*`
`67`	`67`	`* @param QueryBuilder $queryBuilder`
`68`	`68`	`* @param string $resourceClass`
	`69`	`+ * @param string $originAlias`
	`70`	`+ * @param string $relationAlias`
`69`	`71`	`*/`
`70`	`72`	`private function joinRelations(QueryBuilder $queryBuilder, string $resourceClass, string $originAlias = 'o', string &$relationAlias = 'a')`
`71`	`73`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,10 @@`
`23`	`23`	`interface QueryCollectionExtensionInterface`
`24`	`24`	`{`
`25`	`25`	`/**`
`26`		`- * @param QueryBuilder $queryBuilder`
`27`		`- * @param string $resourceClass`
`28`		`- * @param string $operationName`
	`26`	`+ * @param QueryBuilder $queryBuilder`
	`27`	`+ * @param QueryNameGeneratorInterface $queryNameGenerator`
	`28`	`+ * @param string $resourceClass`
	`29`	`+ * @param string\|null $operationName`
`29`	`30`	`*/`
`30`	`31`	`public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null);`
`31`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,8 @@ private function addWhereForIdentifiers(array $identifiers, QueryBuilder $queryB`
`112`	`112`	`* @param ObjectManager $manager`
`113`	`113`	`* @param string $resourceClass`
`114`	`114`	`*`
	`115`	`+ * @throws PropertyNotFoundException`
	`116`	`+ *`
`115`	`117`	`* @return array`
`116`	`118`	`*/`
`117`	`119`	`private function normalizeIdentifiers($id, ObjectManager $manager, string $resourceClass) : array`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`* @author Teoh Han Hui <[email protected]>`
`18`	`18`	`* @author Vincent Chalamon <[email protected]>`
`19`	`19`	`* @author Amrouche Hamza <[email protected]>`
`20`		`-`
`21`	`20`	`*/`
`22`	`21`	`final class QueryNameGenerator implements QueryNameGeneratorInterface`
`23`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,7 @@ protected function setAttributeValue($object, $attribute, $value, $format = null`
`192`	`192`	`*`
`193`	`193`	`* @param string $attribute`
`194`	`194`	`* @param Type $type`
	`195`	`+ * @param mixed $value`
`195`	`196`	`* @param string\|null $format`
`196`	`197`	`*`
`197`	`198`	`* @throws InvalidArgumentException`