chore: remove setPublic for ValidationGroupsGeneratorInterface (#4864)

Author: dannyvw

src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -577,8 +577,7 @@ private function registerValidatorConfiguration(ContainerBuilder $container, arr
             $loader->load('symfony/validator.xml');
 
             $container->registerForAutoconfiguration(ValidationGroupsGeneratorInterface::class)
-                ->addTag('api_platform.validation_groups_generator')
-                ->setPublic(true); // this line should be removed in 3.0
+                ->addTag('api_platform.validation_groups_generator');
             $container->registerForAutoconfiguration(PropertySchemaRestrictionMetadataInterface::class)
                 ->addTag('api_platform.metadata.property_schema_restriction');
         }

src/Symfony/Bundle/Resources/config/symfony/validator.xml

@@ -7,7 +7,7 @@
     <services>
         <service id="api_platform.validator" class="ApiPlatform\Symfony\Validator\Validator">
             <argument type="service" id="validator" />
-            <argument type="service" id="service_container" />
+            <argument type="tagged_locator" tag="api_platform.validation_groups_generator" />
         </service>
         <service id="ApiPlatform\Validator\ValidatorInterface" alias="api_platform.validator" />
 

tests/Fixtures/app/config/config_common.yml

@@ -240,7 +240,8 @@ services:
 
     app.dummy_validation.group_generator:
         class: ApiPlatform\Tests\Fixtures\TestBundle\Validator\DummyValidationGroupsGenerator
-        public: true
+        tags:
+            - name: 'api_platform.validation_groups_generator'
 
     mercure.hub.default.message_handler:
         class: ApiPlatform\Tests\Fixtures\DummyMercureUpdateHandler