chore: use treat phpdoc type as certain

Author: VincentLanglet

phpstan.neon.dist

@@ -5,6 +5,7 @@ parameters:
 		- tests
 		- tests/Fixtures/app/console
 	inferPrivatePropertyTypeFromConstructor: true
+	treatPhpDocTypesAsCertain: false
 	symfony:
 		containerXmlPath: tests/Fixtures/app/var/cache/test/AppKernelTestDebugContainer.xml
 		constantHassers: false
@@ -112,11 +113,7 @@ parameters:
 		    identifier: void.pure
 		-
 		    identifier: varTag.nativeType
-		-
-		    identifier: isset.offset
 		-
 		    identifier: trait.unused
-		-
-		    identifier: instanceof.alwaysTrue
 		-
 		    identifier: catch.neverThrown

src/Doctrine/Odm/State/LinksHandlerTrait.php

@@ -100,10 +100,6 @@ private function buildAggregation(string $toClass, array $links, array $identifi
 
         $classMetadata = $manager->getClassMetadata($aggregationClass);
 
-        if (!$classMetadata instanceof ClassMetadata) {
-            throw new RuntimeException(\sprintf('The class metadata for "%s" must be an instance of "%s".', $aggregationClass, ClassMetadata::class));
-        }
-
         $aggregation = $previousAggregationBuilder;
         if ($aggregationClass !== $previousAggregationClass) {
             $aggregation = $manager->createAggregationBuilder($aggregationClass);

src/Doctrine/Orm/Metadata/Property/DoctrineOrmPropertyMetadataFactory.php

@@ -70,7 +70,7 @@ public function create(string $resourceClass, string $property, array $options =
 
         if ($doctrineClassMetadata instanceof ClassMetadata && \in_array($property, $doctrineClassMetadata->getFieldNames(), true)) {
             $fieldMapping = $doctrineClassMetadata->getFieldMapping($property);
-            if (class_exists(FieldMapping::class) && $fieldMapping instanceof FieldMapping) {
+            if (class_exists(FieldMapping::class)) {
                 $propertyMetadata = $propertyMetadata->withDefault($fieldMapping->default ?? $propertyMetadata->getDefault());
             } else {
                 $propertyMetadata = $propertyMetadata->withDefault($fieldMapping['options']['default'] ?? $propertyMetadata->getDefault());

src/Doctrine/Orm/State/CollectionProvider.php

@@ -56,7 +56,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
         $manager = $this->managerRegistry->getManagerForClass($entityClass);
 
         $repository = $manager->getRepository($entityClass);
-        if (!method_exists($repository, 'createQueryBuilder')) { // @phpstan-ignore-line function.alreadyNarrowedType
+        if (!method_exists($repository, 'createQueryBuilder')) {
             throw new RuntimeException('The repository class must have a "createQueryBuilder" method.');
         }
 

src/Doctrine/Orm/State/ItemProvider.php

@@ -65,7 +65,7 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
         }
 
         $repository = $manager->getRepository($entityClass);
-        if (!method_exists($repository, 'createQueryBuilder')) { // @phpstan-ignore-line function.alreadyNarrowedType
+        if (!method_exists($repository, 'createQueryBuilder')) {
             throw new RuntimeException('The repository class must have a "createQueryBuilder" method.');
         }
 

src/Elasticsearch/State/ItemProvider.php

@@ -49,9 +49,9 @@ public function __construct(
     public function provide(Operation $operation, array $uriVariables = [], array $context = []): ?object
     {
         $resourceClass = $operation->getClass();
-        $options = $operation->getStateOptions() instanceof Options ? $operation->getStateOptions() : new Options(index: $this->getIndex($operation));
+        $options = $operation->getStateOptions();
         if (!$options instanceof Options) {
-            throw new RuntimeException(\sprintf('The "%s" provider was called without "%s".', self::class, Options::class));
+            $options = new Options(index: $this->getIndex($operation));
         }
 
         $params = [

src/Metadata/ApiResource.php

@@ -1026,7 +1026,7 @@ class: $class,
     }
 
     /**
-     * @return Operations<HttpOperation>
+     * @return Operations<HttpOperation>|null
      */
     public function getOperations(): ?Operations
     {

src/Metadata/Tests/Resource/OperationTest.php

@@ -36,7 +36,7 @@ public function testWithResourceTrait(): void
 
         $this->assertSame($operation->getShortName(), 'test');
         $this->assertSame($operation->canRead(), false);
-        $this->assertSame($operation instanceof CollectionOperationInterface, true);
+        $this->assertInstanceOf(CollectionOperationInterface::class, $operation);
     }
 
     #[\PHPUnit\Framework\Attributes\DataProvider('operationProvider')]

src/Serializer/AbstractItemNormalizer.php

@@ -909,7 +909,7 @@ protected function getAttributeValue(object $object, string $attribute, ?string
 
                 $data = $this->normalizeCollectionOfRelations($propertyMetadata, $attributeValue, $resourceClass, $format, $childContext);
                 $context['data'] = $data;
-                $context['type'] = ($nullable && $type instanceof Type) ? Type::nullable($type) : $type;
+                $context['type'] = $nullable ? Type::nullable($type) : $type;
 
                 if ($this->tagCollector) {
                     $this->tagCollector->collect($context);

src/Serializer/Tests/AbstractItemNormalizerTest.php

@@ -1204,7 +1204,7 @@ public function testDeserializationPathForNotDenormalizableRelations(): void
         $errors = [];
         $actual = $normalizer->denormalize($data, Dummy::class, null, ['not_normalizable_value_exceptions' => &$errors]);
         $this->assertEmpty($actual->relatedDummies);
-        $this->assertCount(1, $errors); // @phpstan-ignore-line method.impossibleType (false positive)
+        $this->assertCount(1, $errors);
         $this->assertInstanceOf(NotNormalizableValueException::class, $errors[0]);
         $this->assertSame('relatedDummies[0]', $errors[0]->getPath());
         $this->assertSame('Invalid IRI "wrong".', $errors[0]->getMessage());