Merge pull request #4611 from soyuka/chore/move-last-bits

Move last bits of non-legacy code to the new namespace

Author: soyuka

.github/workflows/ci.yml

@@ -139,11 +139,6 @@ jobs:
           composer remove --dev --no-interaction --no-progress --no-update --ansi \
             doctrine/mongodb-odm \
             doctrine/mongodb-odm-bundle
-      - name: Remove ElasticSearch
-        if: startsWith(matrix.php, '7.1') || startsWith(matrix.php, '7.2')
-        run: |
-          composer remove --dev --no-interaction --no-progress --no-update --ansi \
-            elasticsearch/elasticsearch
       - name: Update project dependencies
         run: composer update --no-interaction --no-progress --ansi
       - name: Require Symfony components
@@ -232,11 +227,6 @@ jobs:
           composer remove --dev --no-interaction --no-progress --no-update --ansi \
             doctrine/mongodb-odm \
             doctrine/mongodb-odm-bundle
-      - name: Remove ElasticSearch
-        if: startsWith(matrix.php, '7.1') || startsWith(matrix.php, '7.2')
-        run: |
-          composer remove --dev --no-interaction --no-progress --no-update --ansi \
-            elasticsearch/elasticsearch
       - name: Update project dependencies
         run: composer update --no-interaction --no-progress --ansi
       - name: Require Symfony components
@@ -645,8 +635,6 @@ jobs:
         run: composer update --no-interaction --no-progress --ansi
       - name: Require Symfony components
         run: composer require symfony/uid --dev --no-interaction --no-progress --ansi
-      - name: Install Elasticsearch-php # there is a version matrix for this package: https://packagist.org/packages/elasticsearch/elasticsearch
-        run: composer require "elasticsearch/elasticsearch:v7.14.0" --no-interaction --no-progress --ansi
       - name: Install PHPUnit
         run: vendor/bin/simple-phpunit --version
       - name: Clear test app cache

composer.json

@@ -38,8 +38,8 @@
         "doctrine/mongodb-odm": "^2.2",
         "doctrine/mongodb-odm-bundle": "^4.0",
         "doctrine/orm": "^2.6.4",
-        "elasticsearch/elasticsearch": "^7.14",
         "friends-of-behat/mink-browserkit-driver": "^1.3.1",
+        "elasticsearch/elasticsearch": "^7.11.0",
         "friends-of-behat/mink-extension": "^2.2",
         "friends-of-behat/symfony-extension": "^2.1",
         "guzzlehttp/guzzle": "^6.0 || ^7.0",
@@ -73,8 +73,8 @@
         "symfony/form": "^3.4 || ^4.4 || ^5.1 || ^6.0",
         "symfony/framework-bundle": "^4.4 || ^5.1 || ^6.0",
         "symfony/http-client": "^4.4 || ^5.1 || ^6.0",
-        "symfony/maker-bundle": "^1.24",
         "symfony/intl": "^4.4 || ^5.3 || ^6.0",
+        "symfony/maker-bundle": "^1.24",
         "symfony/mercure-bundle": "*",
         "symfony/messenger": "^4.4 || ^5.1 || ^6.0",
         "symfony/phpunit-bridge": "^5.4 || ^6.0",

features/graphql/authorization.feature

@@ -152,6 +152,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.relatedDummy" should exist
     And the JSON node "data.securedDummy.relatedDummy" should not be null
 
+  @v3
   @createSchema
   Scenario: A user can't access a secured collection relation
     Given there are 1 SecuredDummy objects owned by dunglas with related dummies
@@ -175,6 +176,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.relatedDummies" should be null
 
+  @v3
   Scenario: A user can't access a secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -232,6 +234,7 @@ Feature: Authorization checking
     And the JSON node "errors[0].message" should be equal to "Access Denied."
     And the JSON node "data.relatedSecuredDummies" should be null
 
+  @v3
   Scenario: A user can access a secured collection relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -253,6 +256,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.relatedSecuredDummies" should have 1 element
 
+  @v3
   Scenario: A user can access a secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -271,6 +275,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.relatedSecuredDummy" should exist
     And the JSON node "data.securedDummy.relatedSecuredDummy" should not be null
 
+  @v3
   Scenario: A user can access a non-secured collection relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -292,6 +297,7 @@ Feature: Authorization checking
     And the header "Content-Type" should be equal to "application/json"
     And the JSON node "data.securedDummy.publicRelatedSecuredDummies" should have 1 element
 
+  @v3
   Scenario: A user can access a non-secured relation
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     When I send the following GraphQL request:
@@ -382,6 +388,7 @@ Feature: Authorization checking
     And the response should be in JSON
     And the JSON node "data.securedDummies.edges[2].node.ownerOnlyProperty" should be equal to "it works"
 
+  @v3
   Scenario: An admin can't create a secured resource with an owner-only property if they won't be the owner
     When I add "Authorization" header equal to "Basic YWRtaW46a2l0dGVu"
     And I send the following GraphQL request:
@@ -465,6 +472,7 @@ Feature: Authorization checking
     And the JSON node "data.securedDummy.adminOnlyProperty" should exist
     And the JSON node "data.securedDummy.adminOnlyProperty" should not be null
 
+  @v3
   Scenario: A user can't see a secured admin-only property on an object they own
     When I add "Authorization" header equal to "Basic ZHVuZ2xhczprZXZpbg=="
     And I send the following GraphQL request:
@@ -527,6 +535,7 @@ Feature: Authorization checking
     And the response should be in JSON
     And the JSON node "data.securedDummy.ownerOnlyProperty" should be equal to the string "updated"
 
+  @v3
   Scenario: An admin can't see a secured owner-only property on an object they don't own
     When I add "Authorization" header equal to "Basic YWRtaW46a2l0dGVu"
     And I send the following GraphQL request:

features/graphql/mutation.feature

@@ -663,6 +663,7 @@ Feature: GraphQL mutation support
     And the JSON node "data.createDummyGroup.clientMutationId" should be equal to "myId"
 
   @createSchema
+  @v3
   Scenario: Use serialization groups with relations
     Given there is 1 dummy object with relatedDummy and its thirdLevel
     And there is a RelatedDummy with 2 friends

features/json/input_output.feature

@@ -7,6 +7,7 @@ Feature: JSON DTO input and output
     Given I add "Accept" header equal to "application/json"
     And I add "Content-Type" header equal to "application/json"
 
+  @createSchema
   Scenario: Request a password reset
     And I send a "POST" request to "/users/password_reset_request" with body:
     """
@@ -24,6 +25,7 @@ Feature: JSON DTO input and output
     }
     """
 
+  @createSchema
   Scenario: Request a password reset for a non-existent user
     And I send a "POST" request to "/users/password_reset_request" with body:
     """
@@ -35,3 +37,4 @@ Feature: JSON DTO input and output
     And the response should be in JSON
     And the header "Content-Type" should be equal to "application/problem+json; charset=utf-8"
     And the JSON node "detail" should be equal to "User does not exist."
+

features/jsonld/input_output.feature

@@ -354,3 +354,27 @@ Feature: JSON-LD DTO input and output
     Then the response status code should be 400
     And the response should be in JSON
     And the JSON node "hydra:description" should be equal to "The input data is misformatted."
+
+  @!mongodb
+  Scenario: Reset password through an input DTO without DataTransformer 
+    When I send a "POST" request to "/user-reset-password" with body:
+    """
+    {
+      "email": "[email protected]"
+    }
+    """
+    Then the response status code should be 201
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/ld+json; charset=utf-8"
+    And the JSON node "email" should be equal to "[email protected]"
+
+  @!mongodb
+  Scenario: Reset password with an invalid payload through an input DTO without DataTransformer 
+    And I send a "POST" request to "/user-reset-password" with body:
+    """
+    {
+      "email": "this is not an email"
+    }
+    """
+    Then the response status code should be 422
+    And the response should be in JSON

features/main/attribute_resource.feature

@@ -4,6 +4,7 @@ Feature: Resource attributes
   I should be able to fetch data from a state provider
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve a Resource collection
@@ -36,6 +37,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve the first resource 
@@ -56,6 +58,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Retrieve the aliased resource
@@ -78,6 +81,7 @@ Feature: Resource attributes
     """
 
   @php8
+  @v3
   @!mysql
   @!mongodb
   Scenario: Patch the aliased resource

features/main/crud.feature

@@ -560,6 +560,7 @@ Feature: Create-Retrieve-Update-Delete
     And the response should be empty
 
   @php8
+  @v3
   @createSchema
   Scenario: Create a resource ProcessorEntity
     When I add "Content-Type" header equal to "application/ld+json"
@@ -586,6 +587,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Create a resource ProviderEntity
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/provider_entities" with body:
@@ -611,6 +613,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Get a collection of Provider Entities
     When I send a "GET" request to "/provider_entities"
     Then the response status code should be 200
@@ -635,6 +638,7 @@ Feature: Create-Retrieve-Update-Delete
     """
 
   @php8
+  @v3
   Scenario: Get a resource ProviderEntity
     When I send a "GET" request to "/provider_entities/1"
     Then the response status code should be 200

features/main/crud_uri_variables.feature

@@ -2,6 +2,7 @@ Feature: Uri Variables
 
   @createSchema
   @php8
+  @v3
   Scenario: Create a resource Company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/companies" with body:
@@ -28,6 +29,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Create a second resource Company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/companies" with body:
@@ -39,6 +41,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Create first Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -66,6 +69,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Create second Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -78,6 +82,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Create third Employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "POST" request to "/employees" with body:
@@ -90,6 +95,7 @@ Feature: Uri Variables
     Then the response status code should be 201
 
   @php8
+  @v3
   Scenario: Retrieve the collection of employees
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/2/employees"
@@ -152,6 +158,7 @@ Feature: Uri Variables
     And the JSON node "data.companies.edges[1].node.employees.edges[1].node.name" should be equal to "foo3"
 
   @php8
+  @v3
   Scenario: Retrieve the company of an employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/employees/1/company"
@@ -171,6 +178,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Retrieve an employee
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/1/employees/1"
@@ -190,6 +198,7 @@ Feature: Uri Variables
     """
 
   @php8
+  @v3
   Scenario: Trying to get an employee of wrong company
     When I add "Content-Type" header equal to "application/ld+json"
     And I send a "GET" request to "/companies/1/employees/2"

features/main/operation_resource.feature

@@ -4,6 +4,7 @@ Feature: Resource operations
   I should be able to persist data from a processor
 
   @php8
+  @v3
   @createSchema
   @!mongodb
   Scenario: Create an operation resource
@@ -19,6 +20,7 @@ Feature: Resource operations
     Then the response status code should be 201
 
   @php8
+  @v3
   @!mongodb
   Scenario: Patch an operation resource
     When I add "Content-Type" header equal to "application/merge-patch+json"
@@ -41,6 +43,7 @@ Feature: Resource operations
     """
 
   @php8
+  @v3
   @!mongodb
   Scenario: Update an operation resource
     When I add "Content-Type" header equal to "application/ld+json"