Remove unnecessary not null check

norkunas · norkunas · commit f91ff6294ac9 · 2019-06-10T07:13:09.000+03:00
diff --git a/src/Bridge/Doctrine/Common/Filter/SearchFilterTrait.php b/src/Bridge/Doctrine/Common/Filter/SearchFilterTrait.php
@@ -116,9 +116,9 @@ abstract protected function getPropertyAccessor(): PropertyAccessorInterface;
     protected function getIdFromValue(string $value)
     {
         try {
-            if (null !== $item = $this->getIriConverter()->getItemFromIri($value, ['fetch_data' => false])) {
-                return $this->getPropertyAccessor()->getValue($item, 'id');
-            }
+            $item = $this->getIriConverter()->getItemFromIri($value, ['fetch_data' => false]);
+
+            return $this->getPropertyAccessor()->getValue($item, 'id');
         } catch (InvalidArgumentException $e) {
             // Do nothing, return the raw value
         }

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,9 @@ abstract protected function getPropertyAccessor(): PropertyAccessorInterface;`
`116`	`116`	`protected function getIdFromValue(string $value)`
`117`	`117`	`{`
`118`	`118`	`try {`
`119`		`- if (null !== $item = $this->getIriConverter()->getItemFromIri($value, ['fetch_data' => false])) {`
`120`		`- return $this->getPropertyAccessor()->getValue($item, 'id');`
`121`		`- }`
	`119`	`+ $item = $this->getIriConverter()->getItemFromIri($value, ['fetch_data' => false]);`
	`120`	`+`
	`121`	`+ return $this->getPropertyAccessor()->getValue($item, 'id');`
`122`	`122`	`} catch (InvalidArgumentException $e) {`
`123`	`123`	`// Do nothing, return the raw value`
`124`	`124`	`}`