fix(metadata): delete operation bad constructor (#4721)

* fix(metadata): delete operation bad constructor

* temp

Author: soyuka

src/Metadata/Delete.php

@@ -21,13 +21,11 @@ final class Delete extends HttpOperation implements DeleteOperationInterface
      */
     public function __construct(
         ?string $uriTemplate = null,
-        ?string $shortName = null,
-        ?string $description = null,
         ?array $types = null,
-                $formats = null,
-                $inputFormats = null,
-                $outputFormats = null,
-                $uriVariables = null,
+        $formats = null,
+        $inputFormats = null,
+        $outputFormats = null,
+        $uriVariables = null,
         ?string $routePrefix = null,
         ?string $routeName = null,
         ?array $defaults = null,
@@ -36,58 +34,58 @@ public function __construct(
         ?bool $stateless = null,
         ?string $sunset = null,
         ?string $acceptPatch = null,
-                $status = null,
+        $status = null,
         ?string $host = null,
         ?array $schemes = null,
         ?string $condition = null,
         ?string $controller = null,
-        ?string $class = null,
-        ?int $urlGenerationStrategy = null,
-        ?bool $collection = null,
-        ?string $deprecationReason = null,
         ?array $cacheHeaders = null,
-        ?array $normalizationContext = null,
-        ?array $denormalizationContext = null,
+
         ?array $hydraContext = null,
         ?array $openapiContext = null,
-        ?array $swaggerContext = null,
-        ?array $validationContext = null,
-        ?array $filters = null,
-        ?bool $elasticsearch = null,
-                $mercure = null,
-                $messenger = null,
-                $input = null,
-                $output = null,
-        ?array $order = null,
-        ?bool $fetchPartial = null,
-        ?bool $forceEager = null,
+        ?array $exceptionToStatus = null,
+
+        ?bool $queryParameterValidationEnabled = null,
+
+        ?string $shortName = null,
+        ?string $class = null,
+        ?bool $paginationEnabled = null,
+        ?string $paginationType = null,
+        ?int $paginationItemsPerPage = null,
+        ?int $paginationMaximumItemsPerPage = null,
+        ?bool $paginationPartial = null,
         ?bool $paginationClientEnabled = null,
         ?bool $paginationClientItemsPerPage = null,
         ?bool $paginationClientPartial = null,
-        ?array $paginationViaCursor = null,
-        ?bool $paginationEnabled = null,
         ?bool $paginationFetchJoinCollection = null,
         ?bool $paginationUseOutputWalkers = null,
-        ?int $paginationItemsPerPage = null,
-        ?int $paginationMaximumItemsPerPage = null,
-        ?bool $paginationPartial = null,
-        ?string $paginationType = null,
+        ?array $paginationViaCursor = null,
+        ?array $order = null,
+        ?string $description = null,
+        ?array $normalizationContext = null,
+        ?array $denormalizationContext = null,
         ?string $security = null,
         ?string $securityMessage = null,
         ?string $securityPostDenormalize = null,
         ?string $securityPostDenormalizeMessage = null,
         ?string $securityPostValidation = null,
         ?string $securityPostValidationMessage = null,
-        ?bool $compositeIdentifier = null,
-        ?array $exceptionToStatus = null,
-        ?bool $queryParameterValidationEnabled = null,
+        ?string $deprecationReason = null,
+        ?array $filters = null,
+        ?array $validationContext = null,
+        $input = null,
+        $output = null,
+        $mercure = null,
+        $messenger = null,
+        ?bool $elasticsearch = null,
+        ?int $urlGenerationStrategy = null,
         ?bool $read = null,
         ?bool $deserialize = null,
         ?bool $validate = null,
         ?bool $write = null,
         ?bool $serialize = null,
-        // TODO: replace by queryParameterValidationEnabled?
-        ?bool $queryParameterValidate = null,
+        ?bool $fetchPartial = null,
+        ?bool $forceEager = null,
         ?int $priority = null,
         ?string $name = null,
         ?string $provider = null,

tests/Metadata/Resource/OperationTest.php

@@ -14,8 +14,18 @@
 namespace ApiPlatform\Tests\Metadata\Resource;
 
 use ApiPlatform\Metadata\CollectionOperationInterface;
+use ApiPlatform\Metadata\Delete;
+use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\GetCollection;
+use ApiPlatform\Metadata\GraphQl\Mutation;
+use ApiPlatform\Metadata\GraphQl\Query;
+use ApiPlatform\Metadata\GraphQl\QueryCollection;
+use ApiPlatform\Metadata\GraphQl\Subscription;
 use ApiPlatform\Metadata\HttpOperation;
+use ApiPlatform\Metadata\Operation;
+use ApiPlatform\Metadata\Patch;
+use ApiPlatform\Metadata\Post;
+use ApiPlatform\Metadata\Put;
 use PHPUnit\Framework\TestCase;
 
 final class OperationTest extends TestCase
@@ -28,4 +38,28 @@ public function testWithResourceTrait()
         $this->assertEquals($operation->canRead(), false);
         $this->assertEquals($operation instanceof CollectionOperationInterface, true);
     }
+
+    /**
+     * @dataProvider operationProvider
+     */
+    public function testOperationConstructor(Operation $operation)
+    {
+        $this->assertInstanceOf(Operation::class, $operation);
+    }
+
+    public function operationProvider()
+    {
+        $args = [];
+
+        yield [new Get(...$args)];
+        yield [new GetCollection(...$args)];
+        yield [new Post(...$args)];
+        yield [new Put(...$args)];
+        yield [new Patch(...$args)];
+        yield [new Delete(...$args)];
+        yield [new Query(...$args)];
+        yield [new QueryCollection(...$args)];
+        yield [new Mutation(...$args)];
+        yield [new Subscription(...$args)];
+    }
 }