Add the DoctrineAnnotation rule to the PHP-CS-Fixer config

meyerbaptiste · meyerbaptiste · commit fcd8af493a78 · 2018-03-08T17:11:32.000+01:00
diff --git a/.php_cs.dist b/.php_cs.dist
@@ -17,6 +17,14 @@ $finder = PhpCsFixer\Finder::create()
 return PhpCsFixer\Config::create()
     ->setRiskyAllowed(true)
     ->setRules([
+        '@DoctrineAnnotation' => true,
+        'doctrine_annotation_array_assignment' => [
+            'operator' => '=',
+        ],
+        'doctrine_annotation_spaces' => [
+            'after_array_assignments_equals' => false,
+            'before_array_assignments_equals' => false,
+        ],
         '@Symfony' => true,
         '@Symfony:risky' => true,
         'array_syntax' => [
diff --git a/tests/Annotation/AnnotatedClass.php b/tests/Annotation/AnnotatedClass.php
@@ -20,9 +20,9 @@
  *     shortName="shortName",
  *     description="description",
  *     iri="http://example.com/res",
- *     itemOperations={"foo":{"bar"}},
- *     collectionOperations={"bar":{"foo"}},
- *     attributes={"foo":"bar"}
+ *     itemOperations={"foo"={"bar"}},
+ *     collectionOperations={"bar"={"foo"}},
+ *     attributes={"foo"="bar"}
  * )
  *
  * @author Marcus Speight <marcus@pmconnect.co.uk>
diff --git a/tests/Fixtures/TestBundle/Entity/AbstractDummy.php b/tests/Fixtures/TestBundle/Entity/AbstractDummy.php
@@ -23,11 +23,11 @@
  *
  * @author Jérémy Derussé <jeremy@derusse.com>
  *
- * @ApiResource(attributes={"filters": {"my_dummy.search", "my_dummy.order", "my_dummy.date"}})
+ * @ApiResource(attributes={"filters"={"my_dummy.search", "my_dummy.order", "my_dummy.date"}})
  * @ORM\Entity
  * @ORM\InheritanceType("SINGLE_TABLE")
  * @ORM\DiscriminatorColumn(name="discr", type="string", length=16)
- * @ORM\DiscriminatorMap({"concrete" = "ConcreteDummy"})
+ * @ORM\DiscriminatorMap({"concrete"="ConcreteDummy"})
  */
 abstract class AbstractDummy
 {
diff --git a/tests/Fixtures/TestBundle/Entity/CircularReference.php b/tests/Fixtures/TestBundle/Entity/CircularReference.php
@@ -23,7 +23,7 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  *
- * @ApiResource(attributes={"normalization_context"={"groups": {"circular"}}})
+ * @ApiResource(attributes={"normalization_context"={"groups"={"circular"}}})
  * @ORM\Entity
  */
 class CircularReference
diff --git a/tests/Fixtures/TestBundle/Entity/Container.php b/tests/Fixtures/TestBundle/Entity/Container.php
@@ -35,12 +35,12 @@ class Container
     /**
      * @ApiSubresource
      * @ORM\OneToMany(
-     *      targetEntity="Node",
-     *      mappedBy="container",
-     *      indexBy="serial",
-     *      fetch="LAZY",
-     *      cascade={},
-     *      orphanRemoval=false
+     *     targetEntity="Node",
+     *     mappedBy="container",
+     *     indexBy="serial",
+     *     fetch="LAZY",
+     *     cascade={},
+     *     orphanRemoval=false
      * )
      * @ORM\OrderBy({"serial"="ASC"})
      *
diff --git a/tests/Fixtures/TestBundle/Entity/CustomActionDummy.php b/tests/Fixtures/TestBundle/Entity/CustomActionDummy.php
@@ -18,13 +18,16 @@
 
 /**
  * @ORM\Entity
- * @ApiResource(itemOperations={
- *     "get"={"method"="GET"},
- *     "custom_normalization"={"route_name"="custom_normalization"}
- * }, collectionOperations={
- *     "get"={"method"="GET"},
- *     "custom_denormalization"={"route_name"="custom_denormalization"}
- * })
+ * @ApiResource(
+ *     itemOperations={
+ *         "get"={"method"="GET"},
+ *         "custom_normalization"={"route_name"="custom_normalization"}
+ *     },
+ *     collectionOperations={
+ *         "get"={"method"="GET"},
+ *         "custom_denormalization"={"route_name"="custom_denormalization"}
+ *     }
+ * )
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  */
diff --git a/tests/Fixtures/TestBundle/Entity/DummyCar.php b/tests/Fixtures/TestBundle/Entity/DummyCar.php
@@ -21,8 +21,8 @@
 /**
  * @ApiResource(
  *     attributes={
- *          "normalization_context"={"groups"={"colors"}},
- *          "filters"={"dummy_car_colors.search_filter"}
+ *         "normalization_context"={"groups"={"colors"}},
+ *         "filters"={"dummy_car_colors.search_filter"}
  *     }
  * )
  * @ORM\Entity
diff --git a/tests/Fixtures/TestBundle/Entity/DummyTableInheritance.php b/tests/Fixtures/TestBundle/Entity/DummyTableInheritance.php
@@ -21,7 +21,7 @@
  * @ORM\Entity
  * @ORM\InheritanceType("JOINED")
  * @ORM\DiscriminatorColumn(name="discr", type="string")
- * @ORM\DiscriminatorMap({"dummyTableInheritance" = "DummyTableInheritance", "dummyTableInheritanceChild" = "DummyTableInheritanceChild", "dummyTableInheritanceDifferentChild" = "DummyTableInheritanceDifferentChild"})
+ * @ORM\DiscriminatorMap({"dummyTableInheritance"="DummyTableInheritance", "dummyTableInheritanceChild"="DummyTableInheritanceChild", "dummyTableInheritanceDifferentChild"="DummyTableInheritanceDifferentChild"})
  * @ApiResource
  */
 class DummyTableInheritance
diff --git a/tests/Fixtures/TestBundle/Entity/DummyTableInheritanceRelated.php b/tests/Fixtures/TestBundle/Entity/DummyTableInheritanceRelated.php
@@ -22,8 +22,8 @@
  * @ORM\Entity
  * @ApiResource(
  *     attributes={
- *          "normalization_context"={"groups"={"default"}},
- *          "denormalization_context"={"groups"={"default"}}
+ *         "normalization_context"={"groups"={"default"}},
+ *         "denormalization_context"={"groups"={"default"}}
  *     }
  * )
  */
diff --git a/tests/Fixtures/TestBundle/Entity/Foo.php b/tests/Fixtures/TestBundle/Entity/Foo.php
@@ -22,7 +22,7 @@
  * @author Vincent Chalamon <vincentchalamon@gmail.com>
  *
  * @ApiResource(attributes={
- *     "order"={"bar", "name": "DESC"}
+ *     "order"={"bar", "name"="DESC"}
  * })
  * @ORM\Entity
  */
diff --git a/tests/Fixtures/TestBundle/Entity/FourthLevel.php b/tests/Fixtures/TestBundle/Entity/FourthLevel.php
@@ -39,7 +39,7 @@ class FourthLevel
     /**
      * @var int
      *
-     * @ORM\Column(type = "integer")
+     * @ORM\Column(type="integer")
      * @Groups({"barcelona", "chicago"})
      */
     private $level = 4;
diff --git a/tests/Fixtures/TestBundle/Entity/JsonldContextDummy.php b/tests/Fixtures/TestBundle/Entity/JsonldContextDummy.php
@@ -41,7 +41,7 @@ class JsonldContextDummy
      *
      * @ApiProperty(
      *     attributes={
-     *         "jsonld_context"= {
+     *         "jsonld_context"={
      *             "@id"="http://example.com/id",
      *             "@type"="@id",
      *             "foo"="bar"
diff --git a/tests/Fixtures/TestBundle/Entity/OverriddenOperationDummy.php b/tests/Fixtures/TestBundle/Entity/OverriddenOperationDummy.php
@@ -31,17 +31,17 @@
  *     },
  *     collectionOperations={
  *
- *       "get"={"method"="GET"},
- *       "post"={"method"="POST"},
- *       "swagger"= {
- *          "path"="/override/swagger",
- *          "method"="GET",
- *          }
+ *         "get"={"method"="GET"},
+ *         "post"={"method"="POST"},
+ *         "swagger"={
+ *             "path"="/override/swagger",
+ *             "method"="GET",
+ *         }
  *     },
  *     itemOperations={
- *         "swagger"= {
- *          "method"="GET",
- *          },
+ *         "swagger"={
+ *             "method"="GET",
+ *         },
  *         "get"={
  *             "method"="GET",
  *             "normalization_context"={"groups"={"overridden_operation_dummy_get"}},
@@ -51,8 +51,8 @@
  *             "method"="PUT",
  *             "normalization_context"={"groups"={"overridden_operation_dummy_put"}},
  *             "denormalization_context"={"groups"={"overridden_operation_dummy_put"}}
- *          },
- *          "delete"={"method"="DELETE"}
+ *         },
+ *         "delete"={"method"="DELETE"}
  *     }
  * )
  * @ORM\Entity
@@ -91,7 +91,7 @@ class OverriddenOperationDummy
      * @var string A short description of the item
      *
      * @ORM\Column(nullable=true)
-     * @Groups({"overridden_operation_dummy_read" ,"overridden_operation_dummy_write", "overridden_operation_dummy_get", "overridden_operation_dummy_put"})
+     * @Groups({"overridden_operation_dummy_read", "overridden_operation_dummy_write", "overridden_operation_dummy_get", "overridden_operation_dummy_put"})
      * @ApiProperty(iri="https://schema.org/description")
      */
     public $description;
diff --git a/tests/Fixtures/TestBundle/Entity/RelatedToDummyFriend.php b/tests/Fixtures/TestBundle/Entity/RelatedToDummyFriend.php
@@ -22,7 +22,7 @@
 /**
  * Related To Dummy Friend represent an association table for a manytomany relation.
  *
- * @ApiResource(attributes={"normalization_context"={"groups": {"fakemanytomany"}}, "filters"={"related_to_dummy_friend.name"}})
+ * @ApiResource(attributes={"normalization_context"={"groups"={"fakemanytomany"}}, "filters"={"related_to_dummy_friend.name"}})
  * @ORM\Entity
  */
 class RelatedToDummyFriend
diff --git a/tests/Fixtures/TestBundle/Entity/RelationEmbedder.php b/tests/Fixtures/TestBundle/Entity/RelationEmbedder.php
@@ -22,18 +22,21 @@
  *
  * @author Kévin Dunglas <dunglas@gmail.com>
  *
- * @ApiResource(attributes={
- *     "normalization_context"={"groups"={"barcelona"}},
- *     "denormalization_context"={"groups"={"chicago"}},
- *     "hydra_context"={"@type"="hydra:Operation", "hydra:title"="A custom operation", "returns"="xmls:string"}
- * }, itemOperations={
- *     "get"={"method"="GET"},
- *     "put"={"method"="PUT"},
- *     "delete"={"method"="DELETE"},
- *     "custom_get"={"route_name"="relation_embedded.custom_get"},
- *     "custom1"={"path"="/api/custom-call/{id}", "method"="GET"},
- *     "custom2"={"path"="/api/custom-call/{id}", "method"="PUT"},
- * })
+ * @ApiResource(
+ *     attributes={
+ *         "normalization_context"={"groups"={"barcelona"}},
+ *         "denormalization_context"={"groups"={"chicago"}},
+ *         "hydra_context"={"@type"="hydra:Operation", "hydra:title"="A custom operation", "returns"="xmls:string"}
+ *     },
+ *     itemOperations={
+ *         "get"={"method"="GET"},
+ *         "put"={"method"="PUT"},
+ *         "delete"={"method"="DELETE"},
+ *         "custom_get"={"route_name"="relation_embedded.custom_get"},
+ *         "custom1"={"path"="/api/custom-call/{id}", "method"="GET"},
+ *         "custom2"={"path"="/api/custom-call/{id}", "method"="PUT"},
+ *     }
+ * )
  * @ORM\Entity
  */
 class RelationEmbedder
diff --git a/tests/Fixtures/TestBundle/Entity/ThirdLevel.php b/tests/Fixtures/TestBundle/Entity/ThirdLevel.php
@@ -40,15 +40,15 @@ class ThirdLevel
     /**
      * @var int
      *
-     * @ORM\Column(type = "integer")
+     * @ORM\Column(type="integer")
      * @Groups({"barcelona", "chicago"})
      */
     private $level = 3;
 
     /**
      * @var bool
      *
-     * @ORM\Column(type = "boolean")
+     * @ORM\Column(type="boolean")
      */
     private $test = true;
 

Original file line number	Diff line number	Diff line change
`@@ -23,11 +23,11 @@`
`23`	`23`	`*`
`24`	`24`	`* @author Jérémy Derussé <[email protected]>`
`25`	`25`	`*`
`26`		`- * @ApiResource(attributes={"filters": {"my_dummy.search", "my_dummy.order", "my_dummy.date"}})`
	`26`	`+ * @ApiResource(attributes={"filters"={"my_dummy.search", "my_dummy.order", "my_dummy.date"}})`
`27`	`27`	`* @ORM\Entity`
`28`	`28`	`* @ORM\InheritanceType("SINGLE_TABLE")`
`29`	`29`	`* @ORM\DiscriminatorColumn(name="discr", type="string", length=16)`
`30`		`- * @ORM\DiscriminatorMap({"concrete" = "ConcreteDummy"})`
	`30`	`+ * @ORM\DiscriminatorMap({"concrete"="ConcreteDummy"})`
`31`	`31`	`*/`
`32`	`32`	`abstract class AbstractDummy`
`33`	`33`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`*`
`24`	`24`	`* @author Kévin Dunglas <[email protected]>`
`25`	`25`	`*`
`26`		`- * @ApiResource(attributes={"normalization_context"={"groups": {"circular"}}})`
	`26`	`+ * @ApiResource(attributes={"normalization_context"={"groups"={"circular"}}})`
`27`	`27`	`* @ORM\Entity`
`28`	`28`	`*/`
`29`	`29`	`class CircularReference`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`* @author Vincent Chalamon <[email protected]>`
`23`	`23`	`*`
`24`	`24`	`* @ApiResource(attributes={`
`25`		`- * "order"={"bar", "name": "DESC"}`
	`25`	`+ * "order"={"bar", "name"="DESC"}`
`26`	`26`	`* })`
`27`	`27`	`* @ORM\Entity`
`28`	`28`	`*/`