tests(v3.0): apply breaking changes to HttpCache #4749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Deuchnord
commented
May 13, 2022
Deuchnord
commented
| Q | A |
|---|---|
| Branch? | 3.0 |
| Tickets | |
| License | MIT |
| Doc PR |
soyuka
reviewed
May 13, 2022
| namespace ApiPlatform\HttpCache\EventListener; | ||
|
|
||
| use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface; | ||
| //use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface; |
There was a problem hiding this comment.
Suggested change
| //use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface; |
soyuka
reviewed
May 13, 2022
| if (isset($attributes['_api_item_operation_name'])) { | ||
| $hasRequestAttributeKey = true; | ||
| $result['operation_name'] = $attributes['_api_operation_name']; | ||
| $result['operation_name'] = $attributes['_api_item_operation_name']; |
There was a problem hiding this comment.
In 3.0 it's _api_operation_name there is no more collection/item
|
Closing in favor of soyuka#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.