fix(hydra): iri template when using query parameter #6742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Oct 23, 2024
soyuka
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Tickets | #6728 #6682 |
| License | MIT |
bendavies
reviewed
Oct 23, 2024
| #[ORM\GeneratedValue(strategy: 'AUTO')] | ||
| public ?int $id = null, | ||
| #[ORM\Column(type: 'date_immutable', nullable: true)] | ||
| public ?\DateTimeImmutable $dummyDate = null, |
Contributor
There was a problem hiding this comment.
i would make dummyDate on the FilterWithStateOptionsEntity and FilterWithStateOptions named differently, and still make sure filtering, hydra:template, swagger, and the QueryParameter works
Member
Author
There was a problem hiding this comment.
This will work only once we've access to symfony/symfony#51741. For now unless you do the mapping yourself, the Resource should have the same properties as the Entity.
soyuka
force-pushed
the
fix/filter-descr-openapi
branch
3 times, most recently
from
b288316 to
82e430f
Compare
soyuka
force-pushed
the
fix/filter-descr-openapi
branch
from
82e430f to
50ac9eb
Compare
soyuka
added a commit
that referenced
this pull request
Oct 28, 2024
Co-authored-by: Simon <[email protected]> fix(hydra): iri template when using query parameter (#6742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.