fix(laravel) graphQl Relationship loading #6792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@soyuka Drafting this for now since there probably is some cleanup to do. Also not sure yet if this is the way this should be implemented (see my comments in api-platform/api-platform#2795). |
soyuka
reviewed
Nov 14, 2024
Member
|
Thanks so much for this, I should've pointed you to |
toitzi
force-pushed
the
toitzi/relationships
branch
3 times, most recently
from
2cd2323 to
be467c9
Compare
Contributor
Author
|
@soyuka I think it is fine now. PR is done, switched to dependency injection and made a funtion for duplicated code Should be ready to merge now! Edit: And no worries about the |
toitzi
force-pushed
the
toitzi/relationships
branch
2 times, most recently
from
0bf48af to
2a12e7b
Compare
fix loading relationships by only loading those related to the model Closes: api-platform#6791 Signed-off-by: Tobias Oitzinger <[email protected]>
toitzi
force-pushed
the
toitzi/relationships
branch
from
2a12e7b to
9304b68
Compare
soyuka
reviewed
Nov 15, 2024
soyuka
reviewed
Nov 15, 2024
soyuka
changed the title
Member
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress and needs feedback