fix(laravel): allow boolean cast #6808
Conversation
amermchaudhary
commented
Nov 18, 2024
amermchaudhary
commented
| Q | A |
|---|---|
| Branch? | 4.0 |
| Tickets | Closes #6807 |
| License | MIT |
|
Thanks! Would you mind adding a test? |
|
@dunglas I created a test for this but the test is failing because of another bug. I will add that bug and try to fix it as well. Basically I tried to add a create mutation for the book but the mutation is not working because its expecting an author of type string. |
|
@dunglas Nevermind, that was my mistake. Tests have been added. Additionally I also see a problem with array casting. Should I fix it in the same PR or do you want me to create a separate bug and corresponding PR? It's a one liner fix and perhaps if you want a test added then some test work |
|
Adding the fix and the test in this PR, or creating a new one are both OK. Don't bother opening a new issue, the describing the fix in the PR description is enough. Thank you for these fixes! |
| $author = AuthorFactory::new()->create(); | ||
| $response = $this->postJson('/api/graphql', [ | ||
| 'query' => ' | ||
| mutation createBook($book: createBookInput!){ |
There was a problem hiding this comment.
Nit: you could use nowdoc strings for readability.
|
Thanks! |
3 participants
