fix(openapi): document error outputs using json-schemas #6923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/6918
branch
2 times, most recently
from
7f5dc5b to
e3e2040
Compare
dunglas
approved these changes
Jan 21, 2025
soyuka
force-pushed
the
fix/6918
branch
4 times, most recently
from
cef72ca to
0d1473f
Compare
jonerickson
pushed a commit
to jonerickson/core
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes many issues related to how errors and constraint violations are documented, it was reported in #6918 and is a follow up of #6748 (therefore I'd be up to add this on 4.1 instead of 4.0 as without the patch there are still inconsistencies).
A few screenshots:
I still need to add a few tests as this was hard to implement we need to cover regressions...