feat(openapi): manage error resources in global #7082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytilotti
force-pushed
the
ytilotti-patch-2
branch
2 times, most recently
from
2a45752 to
fee97bc
Compare
soyuka
reviewed
May 6, 2025
| $defaultError->withStatus(400)->withDescription('Invalid input'), | ||
| $defaultValidationError, | ||
| ], $resourceMetadataCollection, $schema, $schemas, $operation); | ||
| } |
There was a problem hiding this comment.
The idea behind this is that if an error is defined by the user we do not add our custom errors.
There was a problem hiding this comment.
could you revert the changes here? operations already inherit from resources and we shouldn't add any errors if the user has configured some or else its not possible to override defaults
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete the PR #6332 and add error management to the overall package (Config, Resource and/or Operation).
Now can configurable with:
Manageable with overrideResponses of #6221