Skip to content

Conversation

@pspanja
Copy link
Contributor

@pspanja pspanja commented May 12, 2025

Q A
Branch? main
Tickets -
License MIT
Doc PR -

Building HTTP cache headers in XmlResourceExtractor does not cast read values, which means all values will be strings. In case of eg. s-maxage header, that will result in error since Symfony's Response::setSharedMaxAge(int $value): object expects it to be an integer.

<cacheHeaders>
    <cacheHeader name="shared_max_age">7200</cacheHeader>
</cacheHeaders>

@soyuka
Copy link
Member

soyuka commented May 12, 2025

this should target 4.1

@pspanja pspanja force-pushed the xml_extractor_cache_headers_phpize branch from bef28d7 to 1e6b141 Compare May 12, 2025 18:41
@pspanja pspanja changed the base branch from main to 4.1 May 12, 2025 18:41
@pspanja
Copy link
Contributor Author

pspanja commented May 12, 2025

@soyuka done

@soyuka soyuka merged commit 723d041 into api-platform:4.1 May 13, 2025
95 of 97 checks passed
@soyuka
Copy link
Member

soyuka commented May 13, 2025

thanks!

@pspanja pspanja deleted the xml_extractor_cache_headers_phpize branch May 13, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants