feat(symfony): Add error classes options to OpenAPI config #7143
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
May 13, 2025
alexndlm
commented
| Q | A |
|---|---|
| Branch? | main |
| Tickets | |
| License | MIT |
| Doc PR |
alexndlm
force-pushed
the
feature/add-error-classes-options-to-openapi-config
branch
from
7bb1c0e to
f48feb3
Compare
alexndlm
force-pushed
the
feature/add-error-classes-options-to-openapi-config
branch
from
4730096 to
2793631
Compare
soyuka
reviewed
May 14, 2025
| ->end() | ||
| ->booleanNode('overrideResponses')->defaultTrue()->info('Whether API Platform adds automatic responses to the OpenAPI documentation.') | ||
| ->booleanNode('overrideResponses')->defaultTrue()->info('Whether API Platform adds automatic responses to the OpenAPI documentation.')->end() | ||
| ->scalarNode('error_resource_class')->defaultNull()->info('The class used to represent errors in the OpenAPI documentation.')->end() |
Member
There was a problem hiding this comment.
shouldn't it be camel cased to match other configuration names?
Contributor
Author
There was a problem hiding this comment.
Symfony use snake case for configs. In the current section, we have both swagger_ui_extra_configuration and overrideResponses.
It will be nice to use snake case for new options and rename options with camel case in 5.0.
Member
There was a problem hiding this comment.
actually its overrideResponses that's wrong :D
Member
|
thanks! Also note that there's the |
alexndlm
added a commit
to alexndlm/core
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.