fix(symfony): fix resolving groups in ValidationGroupsExtractorTrait when GroupSequence #7272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
reviewed
Jul 3, 2025
| } | ||
|
|
||
| if (!$validationGroups instanceof GroupSequence) { | ||
| $validationGroups = (array) $validationGroups; |
Contributor
There was a problem hiding this comment.
But passing array of groups is not the same as passing GroupSequence 🤔
Contributor
Author
There was a problem hiding this comment.
This is just a revert of changes made in #7184
This condition says - if $validationGroups is not an instance of GroupSequence, make it an array.
Contributor
There was a problem hiding this comment.
Oh right,read it wrong 🤦♂️
Contributor
Author
There was a problem hiding this comment.
Yes, yes ) Yesterday I did the same ))
Member
|
Thanks @alexndlm ! |
soyuka
reviewed
Jul 3, 2025
| private readonly ValidatorMetadataFactoryInterface $validatorMetadataFactory, | ||
| private readonly PropertyMetadataFactoryInterface $decorated, | ||
| private readonly iterable $restrictionsMetadata = [], | ||
| ?ContainerInterface $container = null, |
Member
There was a problem hiding this comment.
this is a bc but as it was tagged like a week ago and we revert it impacts should be negligible.
|
Thank you @alexndlm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7184