fix(metadata): compute isWritable during updates #7383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctrine should not assume an `id` is not writable during updates. PropertyInfo should not assume a property is not writable (for now only during updates) but as this has a direct impact on serialization groups maybe we should just skip readable/writable in the PropertyInfoPropertyMetadataFactory. SerializerPropertyMetadataFactory should run after AttributePropertyMetadataFactory or we can not override this behavior. Mayabe that we could just simplify these and never set `writable` (or `readable`) from Doctrine or PropertyInfo actually (and we won't need to add the api_allow_update to the getFactoryOptions...). fixes api-platform#7382
soyuka
force-pushed
the
fix/7382
branch
3 times, most recently
from
174919a to
916d9d5
Compare
soyuka
added a commit
that referenced
this pull request
Sep 15, 2025
Co-authored-by: soyuka <[email protected]> Co-authored-by: Matteo Beccati <[email protected]> Co-authored-by: valentindrdt <[email protected]> Co-authored-by: Emmanuel Averty <[email protected]> Co-authored-by: Flug <[email protected]> fix(symfony): only set name_converter for the default serializer (#6101) (#7365) fix: pagination via cursor on ApiResource operations (#7368) fix: phpdoc for HttpOperation paginationViaCursor parameter (#7379) fix(metadata): compute isWritable during updates (#7383) fixes #7382
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Nov 9, 2025
This update fails because of this change: api-platform/symfony@v4.1.23...v4.1.24 Of this PR: - api-platform/core#7383
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Nov 9, 2025
This update failed because of this change: api-platform/symfony@v4.1.23...v4.1.24 Of this PR: - api-platform/core#7383 So this is reverted with the change in services.yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine should not assume an
idis not writable during updates. PropertyInfo should not assume a property is not writable (for now only during updates) but as this has a direct impact on serialization groups maybe we should just skip readable/writable in the PropertyInfoPropertyMetadataFactory.SerializerPropertyMetadataFactory should run after AttributePropertyMetadataFactory or we can not override this behavior.
Mayabe that we could just simplify these and never set
writable(orreadable) from Doctrine or PropertyInfo actually (and we won't need to add the api_allow_update to the getFactoryOptions...).fixes #7382