-
-
Notifications
You must be signed in to change notification settings - Fork 958
feat: mcp bundle tool integration #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d136520 to
b904a0d
Compare
rvanlaak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting that the mcp repo's schema PR is merged now, and you're able to spend time on API Platform integration.
Tried reviewing this PR without checking it out and testing it, so please feel free to ignore all my comments / suggestions / nitpicks 🙌 Just trying to provide you with another pov at some classes.
src/Mcp/Metadata/Operation/Factory/OperationMetadataFactory.php
Outdated
Show resolved
Hide resolved
Yeah it was the missing part + now I can also test out to use only the json-schema component's of API Platform to produce MCP SDK's schemas! |
This PR was merged into the main branch. Discussion ---------- [MCP Bundle] bump php-sdk to 0.3 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | api-platform/core#7595 | License | MIT Commits ------- ce5758f bump php-sdk to 0.3
This PR was merged into the main branch. Discussion ---------- [MCP Bundle] bump php-sdk to 0.3 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | no | Issues | api-platform/core#7595 | License | MIT Commits ------- ce5758fc bump php-sdk to 0.3
192498f to
7ff8ba8
Compare
7ff8ba8 to
f4151f8
Compare
620cc60 to
13f91e9
Compare
Rework of #7458
Now with a simpler approach, this gives the ability to add McpTool (upcoming McpResource) to any API Platform environment giving access to:
item_uri_template)CallToolResult(from the php-sdk itself for images, sound etc.)TODO:
#[McpTool]attribute#[McpResource]Because MCP uses JSON-RPC under the hood with some particular response objects (from php-sdk) we can not change returned headers yet (we'll work on an extension point).