fix: do not generate property when range is missing (#369)

Author: alanpoulain

src/ClassMutator/ClassPropertiesAppender.php

@@ -129,7 +129,9 @@ private function generateField(array $config, SchemaClass $class, RdfResource $t
     {
         $property = ($this->propertyGenerator)($typeProperty->localName(), $config, $class, ['type' => $type, 'typeConfig' => $typeConfig, 'property' => $typeProperty], $isCustom);
 
-        $class->addProperty($property);
+        if ($property) {
+            $class->addProperty($property);
+        }
     }
 
     /**

src/OpenApi/ClassGenerator.php

@@ -227,7 +227,9 @@ private function buildClassFromSchema(Schema $schema, string $name, array $confi
         foreach ($schema->properties as $propertyName => $schemaProperty) {
             \assert($schemaProperty instanceof Schema);
             $property = ($this->propertyGenerator)($propertyName, $config, $class, ['schema' => $schema, 'property' => $schemaProperty]);
-            $class->addProperty($property);
+            if ($property) {
+                $class->addProperty($property);
+            }
         }
 
         if ($config['doctrine']['useCollection']) {

src/OpenApi/PropertyGenerator/PropertyGenerator.php

@@ -34,7 +34,7 @@ public function __construct(?PropertyGeneratorInterface $propertyGenerator = nul
      * @param Configuration                           $config
      * @param array{schema: Schema, property: Schema} $context
      */
-    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): Property
+    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): ?Property
     {
         $schema = $context['schema'];
         $schemaProperty = $context['property'];

src/PropertyGenerator/PropertyGenerator.php

@@ -22,7 +22,7 @@ final class PropertyGenerator implements PropertyGeneratorInterface
      * @param Configuration $config
      * @param array{}       $context
      */
-    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): Property
+    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): ?Property
     {
         if (!$property) {
             throw new \LogicException('A property must be given.');

src/PropertyGenerator/PropertyGeneratorInterface.php

@@ -29,5 +29,5 @@ public function __invoke(
         array $context,
         bool $isCustom = false,
         ?Property $property = null
-    ): Property;
+    ): ?Property;
 }

src/Schema/PropertyGenerator/PropertyGenerator.php

@@ -62,7 +62,7 @@ public function __construct(GoodRelationsBridge $goodRelationsBridge, TypeConver
      *     property: RdfResource
      * } $context
      */
-    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): Property
+    public function __invoke(string $name, array $config, Class_ $class, array $context, bool $isCustom = false, ?Property $property = null): ?Property
     {
         $type = $context['type'];
         $typeConfig = $context['typeConfig'];
@@ -136,7 +136,7 @@ public function __invoke(string $name, array $config, Class_ $class, array $cont
         }
 
         if (!$ranges) {
-            return $schemaProperty;
+            return null;
         }
 
         $isNullable = (bool) ($propertyConfig['nullable'] ?? !\in_array($cardinality, [