Skip to content

Commit 4671d77

Browse files
authored
Feat: Dunglas' review (#414)
* feat: add missing prefetch false * fix: links and add screencasts and social icons in header * internal links * feat: add call to action to les-tilleuls.coop * feat: increase header size * feat: add references
1 parent cb6faf4 commit 4671d77

File tree

38 files changed

+560
-221
lines changed

38 files changed

+560
-221
lines changed

pwa/app/(common)/community/contributors/[slug]/page.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ export default async function Page({
145145
<Link
146146
className="uppercase font-semibold text-sm mb-2 opacity-80"
147147
href="/community/contributors"
148+
prefetch={false}
148149
>
149150
Our contributors
150151
</Link>

pwa/app/(common)/components/Admin.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import Button from "components/common/Button";
22
import Heading from "components/common/typography/Heading";
33
import Image from "next/image";
44
import ListPoint from "./AdminListPoint";
5+
import Link from "components/common/Link";
56

67
export default function Admin() {
78
return (
@@ -19,7 +20,7 @@ export default function Admin() {
1920
Entirely <strong>customizable</strong>
2021
</ListPoint>
2122
<ListPoint direction="left">
22-
<strong>Hydra</strong> and <strong>OpenAPI</strong> compatible
23+
<strong>Hydra</strong> and <Link href="/docs/admin/openapi/" prefetch={false} className="link"><strong>OpenAPI</strong></Link> compatible
2324
</ListPoint>
2425
<ListPoint direction="left">
2526
Built on top of <strong>Material UI</strong> and{" "}
@@ -50,7 +51,7 @@ export default function Admin() {
5051
empty
5152
className="relative dark:border-blue-extralight dark:text-blue-extralight"
5253
color="white"
53-
href="/docs"
54+
href="/docs/admin/"
5455
ariaLabel="See admin interface"
5556
>
5657
Learn more

pwa/app/(common)/components/ClientGenerator.tsx

Lines changed: 58 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import Button from "components/common/Button";
22
import Heading from "components/common/typography/Heading";
33
import Image from "next/image";
4+
import Link from "components/common/Link";
5+
46
import {
57
VueIcon,
68
NextIcon,
@@ -12,6 +14,38 @@ import {
1214
import ShapeSection from "components/common/ShapeSection";
1315

1416
export default function ClientGenerator() {
17+
const logos = [
18+
{
19+
Icon: NextIcon,
20+
title: "Next.js",
21+
link: "https://nextjs.org/",
22+
},
23+
{
24+
Icon: NuxtIcon,
25+
title: "Nuxt",
26+
link: "https://nuxt.com/",
27+
},
28+
{
29+
Icon: ReactIcon,
30+
title: "React",
31+
link: "https://react.dev/",
32+
},
33+
{
34+
Icon: VueIcon,
35+
title: "Vue.js",
36+
link: "https://vuejs.org/",
37+
},
38+
{
39+
Icon: QuasarIcon,
40+
title: "Quasar",
41+
link: "https://quasar.dev/",
42+
},
43+
{
44+
Icon: VuetifyIcon,
45+
title: "Vuetify",
46+
link: "https://vuetifyjs.com/en/",
47+
},
48+
];
1549
return (
1650
<ShapeSection
1751
maskColor="white"
@@ -30,20 +64,33 @@ export default function ClientGenerator() {
3064
Scaffold <strong>client apps</strong>
3165
</Heading>
3266
<p className="text-white/60 text-xl font-light mt-8">
33-
We don&apos;t want to decide for you which front-end framework you
34-
want to work with. That&apos;s why we allow you to generate a web or
35-
mobile application for most popular front-end frameworks, like Vue,
36-
React, or Quasar.
67+
We provide a scaffolding with first-class support for <a
68+
className="link"
69+
href="https://nextjs.org/"
70+
target="_blank"
71+
rel="noreferer noopener"
72+
>Next.js</a>, but don't want to decide for you which front-end framework
73+
you want to work with so skeletons for many other frontend frameworks are supported such as: <Link href="/docs/create-client/nuxt/" prefetch={false} className="link">Nuxt (Vue)</Link>, <Link href="/docs/create-client/react-native/" prefetch={false} className="link">Expo (React Native)</Link>, <Link href="/docs/create-client/Quasar/" prefetch={false} className="link">Quasar</Link>, and <Link href="/docs/create-client/#generated-react-and-react-native-apps-updated-in-real-time" prefetch={false} className="link">many more...</Link>
3774
</p>
3875
<div className="flex flex-row py-8 text-blue | sm:w-1/2 | md:w-full">
39-
<NextIcon className="m-2 h-10 w-auto" />
40-
<NuxtIcon className="m-2 h-10 w-auto" />
41-
<ReactIcon className="m-2 h-10 w-auto" />
42-
<VueIcon className="m-2 h-10 w-auto" />
43-
<QuasarIcon className="m-2 h-10 w-auto" />
44-
<VuetifyIcon className="m-2 h-10 w-auto" />
76+
{logos.map((logo) => (
77+
<a
78+
key={logo.title}
79+
href={logo.link}
80+
title={logo.title}
81+
target="_blank"
82+
rel="noopener noreferrer"
83+
className="hover:brightness-125 transition-all"
84+
>
85+
<logo.Icon className="m-2 h-10 w-auto" />
86+
</a>
87+
))}
4588
</div>
46-
<Button empty href="/docs" ariaLabel="See our managed clients">
89+
<Button
90+
empty
91+
href="/docs/create-client"
92+
ariaLabel="See our managed clients"
93+
>
4794
Learn more
4895
</Button>
4996
</div>

pwa/app/(common)/components/Cover.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export default function Cover() {
3737
<div className="relative w-full flex flex-col items-center text-center py-12 z-20 | md:w-7/12 md:ml-auto md:py-32 | lg:w-1/2">
3838
<Logo className="w-full max-w-sm" />
3939
<p className="font-title text-3xl my-6 font-semibold">
40-
The API first framework
40+
The API-first framework
4141
</p>
4242
<div className="flex flex-row flex-wrap items-center justify-center">
4343
<Button

pwa/app/(common)/components/Features.tsx

Lines changed: 34 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,41 +18,63 @@ export default function Features() {
1818
</Heading>
1919
<div className="w-full max-w-6xl mx-auto pt-12 flex flex-row flex-wrap justify-center">
2020
<FeatureItem Icon={icons.AuthenticationIcon} index={0}>
21-
<Link className="link" href="/docs/core/security/">
21+
<Link className="link" href="/docs/core/security/" prefetch={false}>
2222
Authentication and access control rules
2323
</Link>
2424
</FeatureItem>
2525
<FeatureItem Icon={icons.ValidationIcon} index={1}>
26-
<Link className="link" href="/docs/core/validation/">
26+
<Link
27+
className="link"
28+
href="/docs/core/validation/"
29+
prefetch={false}
30+
>
2731
Advanced data validation
2832
</Link>
2933
</FeatureItem>
3034
<FeatureItem Icon={icons.CacheIcon} index={2}>
31-
<Link className="link" href="/docs/core/performance/">
35+
<Link
36+
className="link"
37+
href="/docs/core/performance/"
38+
prefetch={false}
39+
>
3240
Invalidation-based HTTP cache
3341
</Link>
3442
</FeatureItem>
3543
<FeatureItem Icon={icons.AsynchronousIcon} index={3}>
3644
Asynchronous state processing
3745
</FeatureItem>
3846
<FeatureItem Icon={icons.VulcainIcon} index={4}>
39-
<a
47+
<Link
4048
className="link"
41-
href="https://vulcain.rocks"
42-
target="_blank"
43-
rel="noreferer noopener"
49+
href="/docs/core/push-relations/#pushing-related-resources-using-http2"
50+
prefetch={false}
4451
>
45-
Relation preloading avec Vulcain.rocks
46-
</a>
52+
Relation preloading with Vulcain.rocks
53+
</Link>
4754
</FeatureItem>
4855
<FeatureItem Icon={icons.CaddyIcon} index={5}>
49-
Caddy server integration HTTPS & HTTP/3
56+
<Link
57+
className="link"
58+
href="/docs/distribution/caddy/#configuring-the-caddy-web-server"
59+
prefetch={false}
60+
>
61+
Caddy server</Link> integration HTTPS & HTTP/3
5062
</FeatureItem>
5163
<FeatureItem Icon={icons.PaginationIcon} index={6}>
52-
Automatic pagination and filtering
64+
Automatic <Link
65+
className="link"
66+
href="/docs/core/pagination/"
67+
prefetch={false}
68+
>
69+
pagination</Link> and <Link
70+
className="link"
71+
href="/docs/core/filters/"
72+
prefetch={false}
73+
>filtering</Link>
74+
5375
</FeatureItem>
5476
<FeatureItem Icon={icons.DockerIcon} index={7}>
55-
<Link className="link" href="/docs/deployment/">
77+
<Link className="link" href="/docs/deployment/" prefetch={false}>
5678
Docker & Kubernetes setups included
5779
</Link>
5880
</FeatureItem>

pwa/app/(common)/components/RealTime.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export default function RealTime() {
2828
className="mt-8"
2929
empty
3030
external
31-
href="https://mercure.rocks"
31+
href="/docs/core/mercure/"
3232
ariaLabel="Real time with Mercure"
3333
>
3434
Learn more

pwa/app/(common)/components/ReferenceLogoItem.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import classNames from "classnames";
2-
import Link from "components/common/Link";
32
import Image from "next/image";
43
import { Reference } from "types";
54

@@ -56,7 +55,7 @@ export default function LogoItem({
5655
}
5756

5857
return (
59-
<Link
58+
<a
6059
target="_blank"
6160
rel="noopener noreferrer"
6261
href={reference.link}
@@ -74,6 +73,6 @@ export default function LogoItem({
7473
width={200}
7574
className="cursor-pointer h-full w-auto brightness-0 invert"
7675
/>
77-
</Link>
76+
</a>
7877
);
7978
}

pwa/app/(common)/components/References.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import Button from "components/common/Button";
22
import Heading from "components/common/typography/Heading";
33
import Image from "next/image";
4-
import Link from "components/common/Link";
54
import { Reference } from "types";
65
import LogoItem from "./ReferenceLogoItem";
76

@@ -71,7 +70,7 @@ export default function References({ refs, ossRefs }: ReferencesProps) {
7170
</div>
7271
<div className="flex flex-row flex-wrap py-12">
7372
{refs.map((ref) => (
74-
<Link
73+
<a
7574
key={ref.name}
7675
href={ref.link}
7776
target="_blank"
@@ -85,7 +84,7 @@ export default function References({ refs, ossRefs }: ReferencesProps) {
8584
width={200}
8685
className="max-w-[120px] mx-auto"
8786
/>
88-
</Link>
87+
</a>
8988
))}
9089
</div>
9190
<Button empty href="/references">

0 commit comments

Comments
 (0)