Skip to content

Commit c4d207b

Browse files
authored
fix(release): unify the node.js version used for binary (#363)
1 parent 35364f7 commit c4d207b

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

.github/workflows/release.yaml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Release
22
on:
33
push:
44
tags:
5-
- 'v*.*.*'
5+
- "v*.*.*"
66
jobs:
77
adc:
88
runs-on: ubuntu-latest
@@ -14,20 +14,21 @@ jobs:
1414
# Build and test ADC CLI
1515
- uses: actions/setup-node@v4
1616
with:
17-
node-version: 'lts/*'
17+
node-version: "lts/*"
1818
- uses: pnpm/action-setup@v4
1919
- name: Build ADC
2020
env:
2121
NODE_VERSION: 22.17.0
2222
run: |
23+
node -v
2324
pnpm install
2425
NODE_ENV=production npx nx build cli
2526
node --experimental-sea-config apps/cli/node-sea.json
26-
npx ts-node apps/cli/scripts/download-node.ts
27-
npx postject ./node-binary/linux-amd64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
28-
npx postject ./node-binary/linux-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
29-
npx postject ./node-binary/win-x64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
30-
npx postject ./node-binary/win-arm64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
27+
pnpx ts-node apps/cli/scripts/download-node.ts
28+
pnpx postject ./node-binary/linux-amd64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
29+
pnpx postject ./node-binary/linux-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
30+
pnpx postject ./node-binary/win-x64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
31+
pnpx postject ./node-binary/win-arm64.exe NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
3132
3233
- name: Compress ADC
3334
run: |
@@ -61,20 +62,20 @@ jobs:
6162
# Build and test ADC CLI
6263
- uses: actions/setup-node@v4
6364
with:
64-
node-version: 'lts/*'
65+
node-version: "lts/*"
6566
- uses: pnpm/action-setup@v2
66-
with:
67-
version: latest
6867
- name: Build ADC
68+
env:
69+
NODE_VERSION: 22.20.0
6970
run: |
7071
pnpm install
7172
NODE_ENV=production npx nx build cli
7273
node --experimental-sea-config apps/cli/node-sea.json
73-
npx ts-node apps/cli/scripts/download-node.ts
74+
pnpx ts-node apps/cli/scripts/download-node.ts
7475
codesign --remove-signature ./node-binary/darwin-arm64
7576
codesign --remove-signature ./node-binary/darwin-x64
76-
npx postject ./node-binary/darwin-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
77-
npx postject ./node-binary/darwin-x64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
77+
pnpx postject ./node-binary/darwin-arm64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
78+
pnpx postject ./node-binary/darwin-x64 NODE_SEA_BLOB sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2 --macho-segment-name NODE_SEA
7879
codesign --sign - ./node-binary/darwin-arm64
7980
codesign --sign - ./node-binary/darwin-x64
8081

apps/cli/scripts/download-node.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@ import { execSync } from 'child_process';
22
import { cpSync, existsSync, mkdirSync, rmSync, unlinkSync } from 'fs';
33
import { Listr } from 'listr2';
44

5-
const version = process.env.NODE_VERSION ?? '20.15.1';
5+
const version = process.env.NODE_VERSION;
6+
7+
if (!version) {
8+
console.error('empty NODE_VERSION environment variable');
9+
process.exit(1);
10+
}
611

712
const tasks = new Listr([
813
{

0 commit comments

Comments
 (0)