Skip to content

Commit 08c7333

Browse files
committed
apply suggestions
1 parent df4756f commit 08c7333

File tree

9 files changed

+30
-29
lines changed

9 files changed

+30
-29
lines changed

charts/templates/cluster_role.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: rbac.authorization.k8s.io/v1
22
kind: ClusterRole
33
metadata:
4-
name: api7-ingress-manager-role
4+
name: {{ .Release.Name }}-api7-ingress-manager-role
55
rules:
66
- apiGroups:
77
- ""
@@ -106,7 +106,7 @@ rules:
106106
apiVersion: rbac.authorization.k8s.io/v1
107107
kind: ClusterRole
108108
metadata:
109-
name: api7-ingress-metrics-auth-role
109+
name: {{ .Release.Name }}-api7-ingress-metrics-auth-role
110110
rules:
111111
- apiGroups:
112112
- authentication.k8s.io
@@ -124,7 +124,7 @@ rules:
124124
apiVersion: rbac.authorization.k8s.io/v1
125125
kind: ClusterRole
126126
metadata:
127-
name: api7-ingress-metrics-reader
127+
name: {{ .Release.Name }}-api7-ingress-metrics-reader
128128
rules:
129129
- nonResourceURLs:
130130
- /metrics

charts/templates/cluster_role_binding.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,25 +3,25 @@ kind: ClusterRoleBinding
33
metadata:
44
labels:
55
app.kubernetes.io/name: api7-ingress
6-
name: api7-ingress-manager-rolebinding
6+
name: {{ .Release.Name }}-{{ .Release.Name }}-api7-ingress-manager-rolebinding
77
roleRef:
88
apiGroup: rbac.authorization.k8s.io
99
kind: ClusterRole
10-
name: api7-ingress-manager-role
10+
name: {{ .Release.Name }}-api7-ingress-manager-role
1111
subjects:
1212
- kind: ServiceAccount
1313
name: {{ .Release.Name }}
14-
namespace: {{ .Values.namespace }}
14+
namespace: {{ .Release.Namespace }}
1515
---
1616
apiVersion: rbac.authorization.k8s.io/v1
1717
kind: ClusterRoleBinding
1818
metadata:
19-
name: api7-ingress-metrics-auth-rolebinding
19+
name: {{ .Release.Name }}-api7-ingress-metrics-auth-rolebinding
2020
roleRef:
2121
apiGroup: rbac.authorization.k8s.io
2222
kind: ClusterRole
23-
name: api7-ingress-metrics-auth-role
23+
name: {{ .Release.Name }}-api7-ingress-metrics-auth-role
2424
subjects:
2525
- kind: ServiceAccount
2626
name: {{ .Release.Name }}
27-
namespace: {{ .Values.namespace }}
27+
namespace: {{ .Release.Namespace }}

charts/templates/configmap.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
apiVersion: v1
22
kind: ConfigMap
33
metadata:
4-
name: ingress-config
5-
namespace: {{ .Values.namespace }}
4+
name: {{ .Release.Name }}-ingress-config
5+
namespace: {{ .Release.Namespace }}
66
data:
77
config.yaml: |
8-
log_level: "debug"
8+
log_level: "{{ .Values.logLevel | default "debug" }}"
99
1010
controller_name: {{ .Values.controllerName | default "gateway.api7.io/api7-ingress-controller" }}
1111
@@ -14,9 +14,9 @@ data:
1414
gateway_configs:
1515
- name: "api7ee"
1616
control_plane:
17-
admin_key: "{{ .Values.admin.key }}"
17+
admin_key: "{{ required "Provide a valid admin key!" .Values.admin.key }}"
1818
endpoints:
19-
- "{{ .Values.admin.adminEndpoint }}"
20-
tls_verify: {{ .Values.admin.adminTLSVerify }}
19+
- "{{ .Values.admin.endpoint }}"
20+
tls_verify: {{ .Values.admin.tlsVerify }}
2121
addresses: # record the status address of the gateway-api gateway
2222
- "{{ .Values.statusAddress }}"

charts/templates/deployment.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
app.kubernetes.io/name: api7-ingress
66
control-plane: controller-manager
77
name: {{ .Release.Name }}
8-
namespace: {{ .Values.namespace }}
8+
namespace: {{ .Release.Namespace }}
99
spec:
1010
replicas: {{ .Values.replicas }}
1111
selector:
@@ -19,9 +19,9 @@ spec:
1919
control-plane: controller-manager
2020
spec:
2121
containers:
22-
- image: api7/api7-ingress-controller:dev
22+
- image: "api7/api7-ingress-controller:{{ .Values.imageTag }}"
2323
volumeMounts:
24-
- name: ingress-config
24+
- name: {{ .Release.Name }}-ingress-config
2525
mountPath: /app/conf/config.yaml
2626
subPath: config.yaml
2727
livenessProbe:
@@ -50,9 +50,9 @@ spec:
5050
drop:
5151
- ALL
5252
volumes:
53-
- name: ingress-config
53+
- name: {{ .Release.Name }}-ingress-config
5454
configMap:
55-
name: ingress-config
55+
name: {{ .Release.Name }}-ingress-config
5656
securityContext:
5757
runAsNonRoot: true
5858
serviceAccountName: {{ .Release.Name }}

charts/templates/role.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ metadata:
44
labels:
55
app.kubernetes.io/name: api7-ingress
66
name: api7-ingress-leader-election-role
7-
namespace: {{ .Values.namespace }}
7+
namespace: {{ .Release.Namespace }}
88
rules:
99
- apiGroups:
1010
- ""

charts/templates/role_binding.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ metadata:
44
labels:
55
app.kubernetes.io/name: api7-ingress
66
name: api7-ingress-leader-election-rolebinding
7-
namespace: {{ .Values.namespace }}
7+
namespace: {{ .Release.Namespace }}
88
roleRef:
99
apiGroup: rbac.authorization.k8s.io
1010
kind: Role
1111
name: api7-ingress-leader-election-role
1212
subjects:
1313
- kind: ServiceAccount
1414
name: {{ .Release.Name }}
15-
namespace: {{ .Values.namespace }}
15+
namespace: {{ .Release.Namespace }}

charts/templates/service-account.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ metadata:
44
labels:
55
app.kubernetes.io/name: api7-ingress
66
name: {{ .Release.Name }}
7-
namespace: {{ .Values.namespace }}
7+
namespace: {{ .Release.Namespace }}

charts/templates/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ metadata:
55
app.kubernetes.io/name: api7-ingress
66
control-plane: controller-manager
77
name: {{ .Release.Name }}-metrics-service
8-
namespace: {{ .Values.namespace }}
8+
namespace: {{ .Release.Namespace }}
99
spec:
1010
ports:
1111
- name: https

charts/values.yaml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
controllerName: gateway.api7.io/api7-ingress-controller
22
replicas: 1
33
admin:
4-
key: '' # Pass the admin key generated for the ingress gateway group
5-
adminTLSVerify: false
6-
adminEndpoint: https://api7ee3-dashboard.api7-ee-e2e:7443/apisix/admin
7-
namespace: ingress-apisix
4+
key: 'a7adm-e8J8XAu6FX3W9LD1f84dg3JCpTIj22e733p5qLZ8NY304ksZIz-1ff6f82c482a41f6b8d86af79d3a1c20' # Pass the admin key generated for the ingress gateway group
5+
tlsVerify: false
6+
endpoint: https://api7ee3-dashboard.api7-ee-e2e:7443/apisix/admin
87
statusAddress: ''
8+
logLevel: debug
9+
imageTag: dev

0 commit comments

Comments
 (0)