f:

Author: dspo

internal/controller/httproute_controller.go

@@ -38,6 +38,7 @@ import (
 	"sigs.k8s.io/gateway-api/apis/v1alpha2"
 
 	"github.com/apache/apisix-ingress-controller/api/v1alpha1"
+	"github.com/apache/apisix-ingress-controller/internal/controller/config"
 	"github.com/apache/apisix-ingress-controller/internal/controller/indexer"
 	"github.com/apache/apisix-ingress-controller/internal/provider"
 )
@@ -207,44 +208,32 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 	}
 
 	// TODO: diff the old and new status
-	hrNN := types.NamespacedName{Namespace: hr.GetNamespace(), Name: hr.GetName()}
 	hr.Status.Parents = make([]gatewayv1.RouteParentStatus, 0, len(gateways))
 	for _, gateway := range gateways {
-		var (
-			parentStatus gatewayv1.RouteParentStatus
-			gwNN         = types.NamespacedName{
-				Namespace: gateway.Gateway.GetNamespace(),
-				Name:      gateway.Gateway.GetName(),
-			}
-			conditionAccepted = metav1.Condition{
-				Type:               string(gatewayv1.RouteConditionAccepted),
-				Status:             ConditionStatus(acceptStatus.status),
-				ObservedGeneration: hr.GetGeneration(),
-				LastTransitionTime: metav1.Now(),
-				Reason:             string(gatewayv1.RouteReasonAccepted),
-				Message:            acceptStatus.msg,
-			}
-		)
-		if ok := setControllerNameAndParentRef(&parentStatus, gwNN, hrNN); !ok {
-			conditionAccepted = metav1.Condition{
-				Type:               string(gatewayv1.RouteConditionAccepted),
-				Status:             metav1.ConditionFalse,
-				ObservedGeneration: hr.GetGeneration(),
-				LastTransitionTime: metav1.Now(),
-				Reason:             string(gatewayv1.RouteReasonNotAllowedByListeners),
-				Message: fmt.Sprintf("A HTTPRoute in the namespace %s failed to attach to a Gateway in another namespace %s",
-					hrNN.Namespace, gwNN.Namespace),
-			}
+		parentStatus := gatewayv1.RouteParentStatus{
+			ParentRef: gatewayv1.ParentReference{
+				Kind:      ptr.To(gatewayv1.Kind(KindGateway)),
+				Group:     ptr.To(gatewayv1.Group(gatewayv1.GroupName)),
+				Name:      gatewayv1.ObjectName(gateway.Gateway.GetName()),
+				Namespace: ptr.To(gatewayv1.Namespace(gateway.Gateway.GetNamespace())),
+			},
+			ControllerName: gatewayv1.GatewayController(config.ControllerConfig.ControllerName),
 		}
 		for _, condition := range gateway.Conditions {
 			parentStatus.Conditions = MergeCondition(parentStatus.Conditions, condition)
 		}
-		SetRouteConditionResolvedRefs(&parentStatus, hr.GetGeneration(), resolveRefStatus.status, resolveRefStatus.msg)
-		hr.Status.Parents = append(hr.Status.Parents, parentStatus)
 		if gateway.ListenerName == "" {
 			continue
 		}
-		SetRouteParentStatusCondtion(&parentStatus, conditionAccepted)
+		SetRouteConditionResolvedRefs(&parentStatus, hr.GetGeneration(), resolveRefStatus.status, resolveRefStatus.msg)
+		// if the HTTPRoute is not accepted, the length of .Status.Parents should be 0 or 1. If it is 1, it can only contain a condition with Status="False"
+		if accepted := SetRouteConditionAccepted(&parentStatus, gateway.Gateway, hr, acceptStatus.status, acceptStatus.msg); !accepted {
+			hr.Status.Parents = []gatewayv1.RouteParentStatus{
+				parentStatus,
+			}
+			break
+		}
+		hr.Status.Parents = append(hr.Status.Parents, parentStatus)
 	}
 	if err := r.Status().Update(ctx, hr); err != nil {
 		return ctrl.Result{}, err

internal/controller/utils.go

@@ -27,7 +27,6 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/types"
-	"k8s.io/utils/ptr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
@@ -231,10 +230,26 @@ func ConditionStatus(status bool) metav1.ConditionStatus {
 	return metav1.ConditionFalse
 }
 
-func SetRouteParentStatusCondtion(routeParentStatus *gatewayv1.RouteParentStatus, condition metav1.Condition) {
+func SetRouteConditionAccepted(routeParentStatus *gatewayv1.RouteParentStatus, gw *gatewayv1.Gateway, hr *gatewayv1.HTTPRoute, acceptedStatus bool, acceptStatusMsg string) (accepted bool) {
+	condition := metav1.Condition{
+		Type:               string(gatewayv1.RouteConditionAccepted),
+		Status:             ConditionStatus(acceptedStatus),
+		ObservedGeneration: hr.GetGeneration(),
+		LastTransitionTime: metav1.Now(),
+		Reason:             string(gatewayv1.RouteReasonAccepted),
+		Message:            acceptStatusMsg,
+	}
+	// if it is across the namespace between the Gateway and HTTPRoute, set .Status="False"
+	if gw.GetNamespace() != hr.GetNamespace() {
+		condition.Status = metav1.ConditionFalse
+		condition.Reason = string(gatewayv1.RouteReasonNotAllowedByListeners)
+		condition.Message = fmt.Sprintf("A HTTPRoute in the namespace %s failed to attach to a Gateway in another namespace %s",
+			hr.GetNamespace(), gw.GetNamespace())
+	}
 	if !IsConditionPresentAndEqual(routeParentStatus.Conditions, condition) {
 		routeParentStatus.Conditions = MergeCondition(routeParentStatus.Conditions, condition)
 	}
+	return condition.Status == metav1.ConditionTrue
 }
 
 func SetRouteConditionResolvedRefs(routeParentStatus *gatewayv1.RouteParentStatus, generation int64, status bool, message string) {
@@ -258,24 +273,6 @@ func SetRouteConditionResolvedRefs(routeParentStatus *gatewayv1.RouteParentStatu
 	}
 }
 
-// setControllerNameAndParentRef sets the ControllerName and ParentRef fields in the RouteParentStatus object.
-// It ensures ParentRef is only set if the Gateway and HTTPRoute are in the same namespace.
-// Returns true if ParentRef is set, otherwise false.
-func setControllerNameAndParentRef(status *gatewayv1.RouteParentStatus, gwNN, hrNN types.NamespacedName) bool {
-	status.ControllerName = gatewayv1.GatewayController(config.ControllerConfig.ControllerName)
-	// route should not have Parents set in status if cross namespace
-	if gwNN.Namespace == hrNN.Namespace {
-		status.ParentRef = gatewayv1.ParentReference{
-			Kind:      ptr.To(gatewayv1.Kind(KindGateway)),
-			Group:     ptr.To(gatewayv1.Group(gatewayv1.GroupName)),
-			Name:      gatewayv1.ObjectName(gwNN.Name),
-			Namespace: ptr.To(gatewayv1.Namespace(gwNN.Namespace)),
-		}
-		return true
-	}
-	return false
-}
-
 func ParseRouteParentRefs(
 	ctx context.Context, mgrc client.Client, route client.Object, parentRefs []gatewayv1.ParentReference,
 ) ([]RouteParentRefContext, error) {

test/conformance/suite_test.go

@@ -22,6 +22,7 @@ import (
 	"github.com/gruntwork-io/terratest/modules/retry"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	"k8s.io/utils/ptr"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
 
@@ -222,6 +223,14 @@ func patchGatewaysForConformanceTest(ctx context.Context, k8sClient client.Clien
 				},
 			}
 
+			if len(gateway.Spec.Listeners) > 0 {
+				gateway.Spec.Listeners[0].AllowedRoutes = &gatewayv1.AllowedRoutes{
+					Namespaces: &gatewayv1.RouteNamespaces{
+						From: ptr.To(gatewayv1.FromNamespaces("All")),
+					},
+				}
+			}
+
 			if err := k8sClient.Update(ctx, gateway); err != nil {
 				GinkgoT().Logf("Failed to patch Gateway %s: %v", gateway.Name, err)
 				continue