Skip to content

Commit 36134c5

Browse files
committed
resolve comments
1 parent ede4e55 commit 36134c5

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

.github/workflows/apisix-conformance-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,6 @@ jobs:
107107
if: ${{ github.event_name == 'pull_request' }}
108108
uses: mshick/add-pr-comment@v2
109109
with:
110-
message-id: '${{ matrix.target }}'
110+
message-id: 'apisix-conformance-test-report'
111111
message-path: |
112112
report.md

.github/workflows/conformance-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,6 @@ jobs:
125125
if: ${{ github.event_name == 'pull_request' }}
126126
uses: mshick/add-pr-comment@v2
127127
with:
128-
message-id: '${{ matrix.target }}'
128+
message-id: 'conformance-test-report'
129129
message-path: |
130130
report.md

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,6 @@ linux-build:
192192
.PHONY: build-image
193193
build-image: docker-build
194194

195-
.PHONY: build-image-with-adc-dev
196-
build-image-with-adc-dev: build
197-
$(CONTAINER_TOOL) build -t ${IMG} -f Dockerfile.dev .
198-
199195
.PHONY: build-push-image
200196
build-push-image: docker-build
201197
@docker push ${IMG}

internal/provider/adc/adc.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,9 @@ func (d *adcClient) Update(ctx context.Context, tctx *provider.TranslateContext,
171171

172172
switch d.BackendMode {
173173
case BackendModeAPISIXStandalone:
174+
// This mode is full synchronization,
175+
// which only needs to be saved in cache
176+
// and triggered by a timer for synchronization
174177
return nil
175178
case BackendModeAPI7EE:
176179
return d.sync(ctx, Task{
@@ -226,6 +229,9 @@ func (d *adcClient) Delete(ctx context.Context, obj client.Object) error {
226229

227230
switch d.BackendMode {
228231
case BackendModeAPISIXStandalone:
232+
// Full synchronization is performed on a gateway by gateway basis
233+
// and it is not possible to perform scheduled synchronization
234+
// on deleted gateway level resources
229235
if len(resourceTypes) == 0 {
230236
return d.sync(ctx, Task{
231237
Name: obj.GetName(),

test/e2e/coverage.txt.16

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)