fix: reduce the complexity of calculating route priority (#2459)

Signed-off-by: ashing <[email protected]>

(cherry picked from commit 14c29cc)

Author: ronething

.github/actions/add-pr-comment

@@ -31,6 +31,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 
+permissions:
+  pull-requests: write
+
 jobs:
   prepare:
     name: Prepare
@@ -116,7 +119,7 @@ jobs:
         if: ${{ github.event_name == 'push' }}
         uses: actions/upload-artifact@v4
         with:
-          name: apisix-ingress-controller-conformance-report.yaml
+          name: apisix-ingress-controller-conformance-report-${{ matrix.provider_type }}.yaml
           path: apisix-ingress-controller-conformance-report.yaml
 
       - name: Format Conformance Test Report
@@ -129,8 +132,8 @@ jobs:
 
       - name: Report Conformance Test Result to PR Comment
         if: ${{ github.event_name == 'pull_request' }}
-        uses: mshick/add-pr-comment@v2
+        uses: ./.github/actions/add-pr-comment
         with:
-          message-id: 'apisix-conformance-test-report'
+          message-id: 'apisix-conformance-test-report-${{ matrix.provider_type }}'
           message-path: |
             report.md

.github/workflows/apisix-conformance-test.yml

@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[submodule ".github/actions/paths-filter"]
+	path = .github/actions/paths-filter
+	url = https://github.com/dorny/paths-filter.git
+[submodule ".github/actions/markdown-link-check"]
+	path = .github/actions/markdown-link-check
+	url = https://github.com/gaurav-nelson/github-action-markdown-link-check.git
+[submodule ".github/actions/add-pr-comment"]
+	path = .github/actions/add-pr-comment
+	url = https://github.com/mshick/add-pr-comment.git

.gitmodules

@@ -382,14 +382,14 @@ func (t *Translator) translateBackendRef(tctx *provider.TranslateContext, ref ga
 // ref: https://github.com/Kong/kubernetes-ingress-controller/blob/57472721319e2c63e56cb8540425257e8e02520f/internal/dataplane/translator/subtranslator/httproute_atc.go#L279-L296
 func calculateHTTPRoutePriority(match *gatewayv1.HTTPRouteMatch, ruleIndex int, hosts []string) uint64 {
 	const (
-		// PreciseHostnameShiftBits assigns bit 43-50 for the length of hostname(max length=253).
-		PreciseHostnameShiftBits = 43
-		// HostnameLengthShiftBits assigns bits 35-42 for the length of hostname(max length=253).
-		HostnameLengthShiftBits = 35
-		// ExactPathShiftBits assigns bit 34 to mark if the match is exact path match.
-		ExactPathShiftBits = 34
-		// PathLengthShiftBits assigns bits 23-32 to path length. (max length = 1024, but must start with /)
-		PathLengthShiftBits = 23
+		// PreciseHostnameShiftBits assigns bit 31-38 for the length of hostname(max length=253).
+		// which has 8 bits, so the max length of hostname is 2^8-1 = 255.
+		PreciseHostnameShiftBits = 31
+
+		// HostnameLengthShiftBits assigns bits 23-30 for the length of hostname(max length=253).
+		// which has 8 bits, so the max length of hostname is 2^8-1 = 255.
+		HostnameLengthShiftBits = 23
+
 		// MethodMatchShiftBits assigns bit 22 to mark if method is specified.
 		MethodMatchShiftBits = 22
 		// HeaderNumberShiftBits assign bits 17-21 to number of headers. (max number of headers = 16)
@@ -430,20 +430,6 @@ func calculateHTTPRoutePriority(match *gatewayv1.HTTPRouteMatch, ruleIndex int,
 		priority |= (uint64(maxHostnameLength) << HostnameLengthShiftBits)
 	}
 
-	// ExactPathShiftBits
-	if match.Path != nil && match.Path.Type != nil && *match.Path.Type == gatewayv1.PathMatchExact {
-		priority |= (1 << ExactPathShiftBits)
-	}
-
-	// PathLengthShiftBits
-	// max length of path is 1024, but path must start with /, so we use PathLength-1 to fill the bits.
-	if match.Path != nil && match.Path.Value != nil {
-		pathLength := len(*match.Path.Value)
-		if pathLength > 0 {
-			priority |= (uint64(pathLength-1) << PathLengthShiftBits)
-		}
-	}
-
 	// MethodMatchShiftBits
 	if match.Method != nil {
 		priority |= (1 << MethodMatchShiftBits)