fix: r

Signed-off-by: ashing <[email protected]>

Author: ronething

internal/controller/httproute_controller.go

@@ -223,9 +223,7 @@ func (r *HTTPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
 			parentStatus.Conditions = MergeCondition(parentStatus.Conditions, condition)
 		}
 		SetRouteConditionAccepted(&parentStatus, hr.GetGeneration(), acceptStatus.status, acceptStatus.msg)
-
-		// Use the stored backend reference error directly with our new function
-		SetRouteConditionResolvedRefsWithError(&parentStatus, hr.GetGeneration(), backendRefErr)
+		SetRouteConditionResolvedRefs(&parentStatus, hr.GetGeneration(), backendRefErr)
 
 		hr.Status.Parents = append(hr.Status.Parents, parentStatus)
 	}
@@ -444,7 +442,11 @@ func (r *HTTPRouteReconciler) processHTTPRouteBackendRefs(tctx *provider.Transla
 
 		var service corev1.Service
 		if err := r.Get(tctx, serviceNS, &service); err != nil {
-			terr = NewBackendNotFoundError(namespace, name)
+			if client.IgnoreNotFound(err) == nil {
+				terr = NewBackendNotFoundError(namespace, name)
+			} else {
+				terr = err
+			}
 			continue
 		}
 		if service.Spec.Type == corev1.ServiceTypeExternalName {

internal/controller/utils.go

@@ -242,32 +242,8 @@ func SetRouteConditionAccepted(routeParentStatus *gatewayv1.RouteParentStatus, g
 	}
 }
 
-func SetRouteConditionResolvedRefs(routeParentStatus *gatewayv1.RouteParentStatus, generation int64, status bool, message string) {
-	reason := string(gatewayv1.RouteReasonResolvedRefs)
-	// check if the error message contains InvalidKind
-	if !status && strings.Contains(message, string(gatewayv1.RouteReasonInvalidKind)) {
-		reason = string(gatewayv1.RouteReasonInvalidKind)
-	}
-	if !status && strings.Contains(message, "Service") && strings.Contains(message, "not found") {
-		reason = string(gatewayv1.RouteReasonBackendNotFound)
-	}
-
-	condition := metav1.Condition{
-		Type:               string(gatewayv1.RouteConditionResolvedRefs),
-		Status:             ConditionStatus(status),
-		Reason:             reason,
-		ObservedGeneration: generation,
-		Message:            message,
-		LastTransitionTime: metav1.Now(),
-	}
-
-	if !IsConditionPresentAndEqual(routeParentStatus.Conditions, condition) {
-		routeParentStatus.Conditions = MergeCondition(routeParentStatus.Conditions, condition)
-	}
-}
-
-// SetRouteConditionResolvedRefsWithError sets the ResolvedRefs condition with proper reason based on error type
-func SetRouteConditionResolvedRefsWithError(routeParentStatus *gatewayv1.RouteParentStatus, generation int64, err error) {
+// SetRouteConditionResolvedRefs sets the ResolvedRefs condition with proper reason based on error type
+func SetRouteConditionResolvedRefs(routeParentStatus *gatewayv1.RouteParentStatus, generation int64, err error) {
 	var (
 		reason  string
 		status  = metav1.ConditionTrue