f:

Author: dspo

config/rbac/role.yaml

@@ -10,11 +10,7 @@ rules:
   - events
   verbs:
   - create
-  - get
-  - list
   - patch
-  - update
-  - watch
 - apiGroups:
   - ""
   resources:
@@ -30,7 +26,6 @@ rules:
   verbs:
   - get
   - list
-  - update
   - watch
 - apiGroups:
   - ""

internal/controller/gateway_controller.go

@@ -28,9 +28,6 @@ import (
 	"github.com/api7/api7-ingress-controller/internal/provider"
 )
 
-// +kubebuilder:rbac:groups="",resources=events,verbs=get;list;watch;update
-// +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;update
-
 // GatewayReconciler reconciles a Gateway object.
 type GatewayReconciler struct { //nolint:revive
 	client.Client

internal/controller/secret_controller.go

@@ -13,12 +13,11 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/controller"
 	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
-	"sigs.k8s.io/controller-runtime/pkg/predicate"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
-
-	"github.com/api7/api7-ingress-controller/internal/controller/indexer"
 )
 
+// +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch
+
 type SecretReconciler struct {
 	client.Client
 
@@ -38,8 +37,7 @@ func (r *SecretReconciler) SetupWithManager(mgr manager.Manager) error {
 				return r.Log
 			},
 		}).
-		For(&corev1.Secret{}). //builder.WithPredicates(r.predicateFuncs()),
-
+		For(&corev1.Secret{}).
 		Complete(r)
 }
 
@@ -55,22 +53,3 @@ func (r *SecretReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	}
 	return ctrl.Result{}, nil
 }
-
-func (r *SecretReconciler) predicateFuncs() predicate.Funcs {
-	predicateFuncs := predicate.NewPredicateFuncs(func(object client.Object) bool {
-		if _, ok := object.(*corev1.Secret); !ok {
-			return false
-		}
-		key := indexer.GenIndexKey(object.GetNamespace(), object.GetName())
-		refs, err := r.Indexer.ByIndex("referent", key)
-		if err != nil {
-			r.Log.Error(err, "failed to check whether secret referred", "namespace", object.GetNamespace(), "name", object.GetName())
-			return false
-		}
-		return len(refs) > 0
-	})
-	predicateFuncs.DeleteFunc = func(_ event.DeleteEvent) bool {
-		return true
-	}
-	return predicateFuncs
-}